All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Brenton Simpson <appsforartists@google.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Cameron Gutman <aicommander@gmail.com>,
	Erica Taylor <rickytaylor26@gmail.com>,
	Ismael Ferreras Morezuelas <swyterzone@gmail.com>,
	Jonathan Frederick <doublej472@gmail.com>,
	Matthias Benkmann <matthias.benkmann@gmail.com>,
	Matthias Berndt <matthias_berndt@gmx.de>,
	nate@yocom.org, Sam Lantinga <slouken@libsdl.org>,
	Vicki Pfau <vi@endrift.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org
Subject: Re: [PATCH] Input: xpad - sort xpad_device by vendor and product ID
Date: Fri, 9 Feb 2024 10:56:10 -0800	[thread overview]
Message-ID: <ZcZ1Sn_iPwlgfI3s@google.com> (raw)
In-Reply-To: <20240130231903.293265-1-appsforartists@google.com>

Hi Brenton,

On Tue, Jan 30, 2024 at 11:19:03PM +0000, Brenton Simpson wrote:
> Signed-off-by: Brenton Simpson <appsforartists@google.com>

Empty patch descriptions are frowned upon. You should be able to add at
least a single sentence why the change is being made.

...

>  
>  static const struct usb_device_id xpad_table[] = {
> +	/* Please keep this list sorted by vendor ID.  Because the lines use different
> +	 * macros, you may need to sort it by hand.
> +	 */

Kernel style of multi-line comments is:

	/*
	 * line 1
	 * line 2.
	 */

I adjusted and applied, thank you.

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-02-09 18:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 17:45 [PATCH] Input: xpad - add Lenovo Legion Go controllers Brenton Simpson
2023-11-16 18:20 ` Hans de Goede
2024-01-18 18:35 ` Brenton Simpson
2024-01-18 18:41   ` Brenton Simpson
2024-01-19  6:16   ` Vicki Pfau
2024-01-19  8:22     ` Brenton Simpson
2024-01-30 22:32       ` Dmitry Torokhov
2024-01-30 23:19         ` [PATCH] Input: xpad - sort xpad_device by vendor and product ID Brenton Simpson
2024-02-09 18:56           ` Dmitry Torokhov [this message]
2024-02-09 19:27             ` Brenton Simpson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcZ1Sn_iPwlgfI3s@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=aicommander@gmail.com \
    --cc=appsforartists@google.com \
    --cc=doublej472@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.benkmann@gmail.com \
    --cc=matthias_berndt@gmx.de \
    --cc=nate@yocom.org \
    --cc=rickytaylor26@gmail.com \
    --cc=slouken@libsdl.org \
    --cc=swyterzone@gmail.com \
    --cc=trivial@kernel.org \
    --cc=vi@endrift.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.