From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
"Tony Lindgren" <tony@atomide.com>
Subject: Re: [PATCH 3/4] platform/x86: x86-android-tablets: Fix serdev instantiation no longer working
Date: Fri, 16 Feb 2024 23:26:36 +0200 [thread overview]
Message-ID: <Zc_TDM0T7oPLruoJ@smile.fi.intel.com> (raw)
In-Reply-To: <20240216201721.239791-4-hdegoede@redhat.com>
On Fri, Feb 16, 2024 at 09:17:20PM +0100, Hans de Goede wrote:
> After commit b286f4e87e32 ("serial: core: Move tty and serdev to be
> children of serial core port device") x86_instantiate_serdev() no longer
> works due to the serdev-controller-device moving in the device hierarchy
> from (e.g.) /sys/devices/pci0000:00/8086228A:00/serial0 to
> /sys/devices/pci0000:00/8086228A:00/8086228A:00:0/8086228A:00:0.0/serial0
>
> Use the new get_serdev_controller() helper function to fix this.
...
> #include "x86-android-tablets.h"
> +#include "../serdev_helpers.h"
Seems Q more to the previous patch, why is this in the upper folder? Are we
expecting more users?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-16 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 20:17 [PATCH 0/4] platform/x86: x86-android-tablets: 2 regression fixes Hans de Goede
2024-02-16 20:17 ` [PATCH 1/4] platform/x86: x86-android-tablets: Fix keyboard touchscreen on Lenovo Yogabook1 X90 Hans de Goede
2024-02-16 20:17 ` [PATCH 2/4] platform/x86: Add new get_serdev_controller() helper Hans de Goede
2024-02-16 21:24 ` Andy Shevchenko
2024-02-16 22:36 ` Hans de Goede
2024-02-17 18:09 ` Andy Shevchenko
2024-02-18 13:25 ` Hans de Goede
2024-02-29 6:12 ` Tony Lindgren
2024-02-16 20:17 ` [PATCH 3/4] platform/x86: x86-android-tablets: Fix serdev instantiation no longer working Hans de Goede
2024-02-16 21:26 ` Andy Shevchenko [this message]
2024-02-16 20:17 ` [PATCH 4/4] platform/x86: x86-android-tablets: Fix acer_b1_750_goodix_gpios name Hans de Goede
2024-02-19 12:53 ` [PATCH 0/4] platform/x86: x86-android-tablets: 2 regression fixes Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc_TDM0T7oPLruoJ@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.