From: Mike Snitzer <snitzer@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Matthew Sakai <msakai@redhat.com>,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: dm vdo slab-depot: delete unnecessary check
Date: Sun, 11 Feb 2024 13:55:07 -0500 [thread overview]
Message-ID: <ZckYC4wyzbX2870P@redhat.com> (raw)
In-Reply-To: <16ffd614-48a9-42b8-961d-2dc8a69c48d6@moroto.mountain>
On Fri, Feb 09 2024 at 8:06P -0500,
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> This is a duplicate check so it can't be true. Delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/md/dm-vdo/slab-depot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c
> index 42126bd60242..2f4a2ae5e082 100644
> --- a/drivers/md/dm-vdo/slab-depot.c
> +++ b/drivers/md/dm-vdo/slab-depot.c
> @@ -4100,9 +4100,6 @@ static int allocate_components(struct slab_depot *depot,
> };
> }
>
> - if (result != VDO_SUCCESS)
> - return result;
> -
> slab_count = vdo_compute_slab_count(depot->first_block, depot->last_block,
> depot->slab_size_shift);
> if (thread_config->physical_zone_count > slab_count) {
> --
> 2.43.0
>
>
Looks good, I've picked this up.
Thanks,
Mike
prev parent reply other threads:[~2024-02-11 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 13:06 [PATCH] dm vdo slab-depot: delete unnecessary check Dan Carpenter
2024-02-11 18:29 ` Markus Elfring
2024-02-11 18:55 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZckYC4wyzbX2870P@redhat.com \
--to=snitzer@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dm-devel@lists.linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msakai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.