From: Dominique Martinet <asmadeus@codewreck.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: netdev@vger.kernel.org, Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
v9fs@lists.linux.dev, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH v2] 9p/trans_fd: remove Excess kernel-doc comment
Date: Mon, 12 Feb 2024 21:13:49 +0900 [thread overview]
Message-ID: <ZcoLfSBNtfgmeKaI@codewreck.org> (raw)
In-Reply-To: <20240212043341.4631-1-rdunlap@infradead.org>
Randy Dunlap wrote on Sun, Feb 11, 2024 at 08:33:41PM -0800:
> Remove the "@req" kernel-doc description since there is not 'req'
> member in the struct p9_conn.
>
> Fixes one kernel-doc warning:
> trans_fd.c:133: warning: Excess struct member 'req' description in 'p9_conn'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Sorry for the lack of reply, I intended to take the patch when the next
""real"" patch comes in but it doesn't look like we'll get much activity
this cycle so I've just queued it up to -next.
Thanks!
FWIW, I contemplated adding
Fixes: 6d35190f3953 ("9p: Rename req to rreq in trans_fd")
but that's basically been forever so I don't think anyone will care
about backports -- and I'm both surprised and ashamed I didn't see this
W=1 warning earlier, I thought I regularly build with that...
--
Dominique
prev parent reply other threads:[~2024-02-12 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 4:33 [PATCH v2] 9p/trans_fd: remove Excess kernel-doc comment Randy Dunlap
2024-02-12 12:13 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcoLfSBNtfgmeKaI@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.