From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A3FEC4829B for ; Mon, 12 Feb 2024 14:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Rcz1W0UiVaUdSslJipdwZvsPHNASgO9I6+zeGj5Sk8=; b=NoVyCA2UpRyIs8 aYIgqdUyXEd6CX67HUQwXP0X/mAHjT//J5A6fD1Hzhljq66zBG+XU14W4T+eqs2lJ+xVebyrOJEQ5 jtLJxe83jTK5/p78XtfpWyEgd7e8dcEMNmRDcfBrjuE9zS8Mz0/iCTz1G11lnuXEALfz/mdzZ91VW 7rGL+140BVXY1xCKsTvIdZzFlELeBEQsKwYZKc9a5+PEKfcaRp/bdOlKQwWWne6a1/w3vQGDToN4Q Ybv9JbkT5siKZjhfSAixrKxqUrJycb87Lj/0giQWbnpNFBOPVdM5HJjJiVXMCVkOP3keMHC3OKVzQ 6bIPydqybfnEoD2Rs+7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZWzv-00000005itO-3hmS; Mon, 12 Feb 2024 14:09:27 +0000 Received: from mgamail.intel.com ([198.175.65.14]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZWzt-00000005isT-0qnb for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 14:09:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707746965; x=1739282965; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OmHT/FrhDUBQDUhpYbJEhjhkJGs91DlOR2aZmGme0ZE=; b=jBlLp6EuwofK5vGOQ8SYmY3qIHW84n7fDK22MEqgeEnWgn2OhlsO7dVv muGWxbsLJWsb+yolktLSflvVd/6wtwTufVM7gFmQRlssuXAbTZUZ5Erlp +C4t9WUHA7vowB3TlYTO5lJbMDAQp15WW4mgUHnF6UZ6e68x9wXHOkR2c IYld7r75PbOlnk9SAjhEAulpY4vab8Kb/GhwOPUrcr2vxXETMfkpSSogw Qf0B+GpKvPXhb8QY1TF1uXYt5NauqkNau2gj8ShR6MEBsr8QP1zuyVXvQ Mz4B7h8JSbxRRy2S0rcdVIM6OTZF4syrcGF28LQeKdP1FiMlMUlYPx2+k Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="5536917" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="5536917" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:09:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="911493193" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="911493193" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:09:20 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rZWzn-00000003utH-0Cj3; Mon, 12 Feb 2024 16:09:19 +0200 Date: Mon, 12 Feb 2024 16:09:18 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Linus Walleij , Miguel Ojeda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Message-ID: References: <20240212083426.26757-1-krzysztof.kozlowski@linaro.org> <906db6a6-48ba-41e5-be23-1dea0ecf96ee@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <906db6a6-48ba-41e5-be23-1dea0ecf96ee@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_060925_299134_2F941FF1 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 12, 2024 at 02:56:43PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2024 14:39, Andy Shevchenko wrote: > > On Mon, Feb 12, 2024 at 09:34:24AM +0100, Krzysztof Kozlowski wrote: ... > >> - i2c { > >> - #address-cells = <1>; > >> - #size-cells = <0>; > >> > >> - pcf8574: pcf8574@27 { > >> - compatible = "nxp,pcf8574"; > >> - reg = <0x27>; > >> - gpio-controller; > >> - #gpio-cells = <2>; > >> - }; > >> - }; > > > > In patch 3 you updated the lines that have lost their sense due to this one. > > How did they lose it? Now they are referring to the non-existed node in the example. OTOH, there is already hc595 case... The Q here (as you pointed out that it's better to name nodes in generic way), how these names are okay with the schema (hc595, pcf8574) as being referred to? ... > > And I agree with others, please leave this example in place. > > What for? Why this binding is special and 99% of others do not need GPIO > expander in the example? Some people already tried to explain you their point of view, but I see that: - the unrelated nodes in the schemas are not welcome (as per your talks and documentation); - the current file has other references that have no existing node in the example; - you are DT maintainer, so I believe you know this better. With this, I'm almost (see above question though) satisfied with the series. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6403CF41; Mon, 12 Feb 2024 14:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707746966; cv=none; b=tdBTtlcsYmh7uFCIFai/nFvJmd6wInO9SiRM8P0gKZNVhyeeUZtGr/QllPAPpxpFLyyyQ9281a7fagdeS3kSkyuHXzf/0r+OVtB5uKlDY6OPOXQ4ZCVv83CRhlAHtcc69LvD7W5uLfvUbN1uuSLpeTvtyE3zEiXjz5ZEKYpX1Yg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707746966; c=relaxed/simple; bh=OmHT/FrhDUBQDUhpYbJEhjhkJGs91DlOR2aZmGme0ZE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BuOak+LfBZiAHnnD4dGjiaAYdI1SE9jeqzgIN7IdoAO/f5+u0NVnv8FICcanUUj1mf+dWXG1a2WyHypssaLJfKQGAusY/YmU+MZCcUaNY8WV84wzCq7ts+aMNV1pix0myQ7PceYNiIwiYZ+mq89GFjvQSEAczlLiWpNp5t8+9nw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JpdGu26Z; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JpdGu26Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707746966; x=1739282966; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OmHT/FrhDUBQDUhpYbJEhjhkJGs91DlOR2aZmGme0ZE=; b=JpdGu26ZalTrkWHSQxOCb/8u7pi+JSHdjSvetd6XkWueBdE/ZtXm/+Zk BwkFwUxjNID9AvLL0Rp53KJTEJKHJoC1/chmf5kmw6shBUVNxLvKCusVB 0t3Av85PJJLKAf1HXoY+M0KpH4Ut+KXTkg4cXjhxxgdtaVtppZUglDcsc ENSVE5siJkNxr4c0VhQ/A2eSHdjMhoQ9sGJxWt+vojBL0rSqeVjwE9b5k JLfTEamLCAt3VlfeQe5TCUbgiWrZlfT8Lrnll8zTpLVfafrsHi3rREe6g CTm8uHHmxsngi0tA3C02oXJA/AYqNt7dy3PgTtUxocgN+9lBGvVCxipVe Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="5536913" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="5536913" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:09:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="911493193" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="911493193" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:09:20 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rZWzn-00000003utH-0Cj3; Mon, 12 Feb 2024 16:09:19 +0200 Date: Mon, 12 Feb 2024 16:09:18 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Linus Walleij , Miguel Ojeda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Message-ID: References: <20240212083426.26757-1-krzysztof.kozlowski@linaro.org> <906db6a6-48ba-41e5-be23-1dea0ecf96ee@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <906db6a6-48ba-41e5-be23-1dea0ecf96ee@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 12, 2024 at 02:56:43PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2024 14:39, Andy Shevchenko wrote: > > On Mon, Feb 12, 2024 at 09:34:24AM +0100, Krzysztof Kozlowski wrote: ... > >> - i2c { > >> - #address-cells = <1>; > >> - #size-cells = <0>; > >> > >> - pcf8574: pcf8574@27 { > >> - compatible = "nxp,pcf8574"; > >> - reg = <0x27>; > >> - gpio-controller; > >> - #gpio-cells = <2>; > >> - }; > >> - }; > > > > In patch 3 you updated the lines that have lost their sense due to this one. > > How did they lose it? Now they are referring to the non-existed node in the example. OTOH, there is already hc595 case... The Q here (as you pointed out that it's better to name nodes in generic way), how these names are okay with the schema (hc595, pcf8574) as being referred to? ... > > And I agree with others, please leave this example in place. > > What for? Why this binding is special and 99% of others do not need GPIO > expander in the example? Some people already tried to explain you their point of view, but I see that: - the unrelated nodes in the schemas are not welcome (as per your talks and documentation); - the current file has other references that have no existing node in the example; - you are DT maintainer, so I believe you know this better. With this, I'm almost (see above question though) satisfied with the series. -- With Best Regards, Andy Shevchenko