From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 354C0C4829B for ; Mon, 12 Feb 2024 14:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AiBi1BMzMohcPCAwIR5MNGowsItJ/VqCCrRTEN169aM=; b=L3VnzVwc3LEUfK oBkCL0moF7JW/ilimayBLSNTFS3OtYgtlzQqwQUh8JjAcoXMMRVSEiY7P5shwVwc+fr6FANQdq/lS S38MzmTPUbCEoFw0pXjX5IBrTwPiJOi1FwbnhA90qrYGaXss/BdVMBjf5I6PADKtJqv/8QVoA7Piu SwuJTSS3fFvbiaDvXHRtT617RgAUxIDc+oGhej2SzB5yp1I7n7BrbJX3mjVnYtG+7hmHD2b0goTqX WoR0QE3vFjydEUwPKZvVIm/gVuqbGFshJZaXis8w7TYmQ9qELouwybuBPhXr3YX412A9CZUv2xq2u 4Jd486P3S5E3coinzPlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZXLn-00000005o2h-0r0Y; Mon, 12 Feb 2024 14:32:03 +0000 Received: from mgamail.intel.com ([198.175.65.13]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZXLk-00000005o1W-446R for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 14:32:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707748321; x=1739284321; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3JKFf0dcMk7JwnUdDXS61uJeYNwcS3K7/8lxDPV9RgE=; b=jY1qCqV0FBkRnb/WyuDegEVRjQww5L+tbd7yk2ruHrsuiNs7EILSKMEz 16g+AZOBfkcGxCZpyrB4/c6y/JRg3bYCOEzb8KDUIDI2MMOqglk5DN+TE S/jUzo4JYKGjRY2jw0XBOfgKDQUHVaRSv9dhtJeXx01xjxj8M7IdSrpg9 16CwNukhfnEGLCppW1gvncKBdUHJ7RVnI1TXED+WDSOmvSZMiSq5J0osU pzrNmzlZ75B/6cGKTXG3ZCns1F+orsIRscOrzjMxBNM4E/YD+MdakHJls 4yCGLJ2Ctb8ASIAodFPSzqxei5PAtOP62Hs32hgVCoCQPxWVvBF5Od4BM w==; X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="12814858" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="12814858" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:31:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="911497299" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="911497299" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:31:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rZXLZ-00000003vFt-1yfL; Mon, 12 Feb 2024 16:31:49 +0200 Date: Mon, 12 Feb 2024 16:31:49 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Linus Walleij , Miguel Ojeda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Message-ID: References: <20240212083426.26757-1-krzysztof.kozlowski@linaro.org> <906db6a6-48ba-41e5-be23-1dea0ecf96ee@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_063201_079739_4E38CB62 X-CRM114-Status: GOOD ( 19.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 12, 2024 at 03:20:26PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2024 15:09, Andy Shevchenko wrote: > > On Mon, Feb 12, 2024 at 02:56:43PM +0100, Krzysztof Kozlowski wrote: > >> On 12/02/2024 14:39, Andy Shevchenko wrote: > >>> On Mon, Feb 12, 2024 at 09:34:24AM +0100, Krzysztof Kozlowski wrote: ... > >>>> - i2c { > >>>> - #address-cells = <1>; > >>>> - #size-cells = <0>; > >>>> > >>>> - pcf8574: pcf8574@27 { > >>>> - compatible = "nxp,pcf8574"; > >>>> - reg = <0x27>; > >>>> - gpio-controller; > >>>> - #gpio-cells = <2>; > >>>> - }; > >>>> - }; > >>> > >>> In patch 3 you updated the lines that have lost their sense due to this one. > >> > >> How did they lose it? > > > > Now they are referring to the non-existed node in the example. OTOH, there is > > already hc595 case... > > All of the bindings examples do it. It's expected. > > > > > The Q here (as you pointed out that it's better to name nodes in generic way), > > how these names are okay with the schema (hc595, pcf8574) as being referred to? > > They are not OK, although I don't see the name "hc595". There is phandle > to the hc595 label, but that's fine. Not a node name. Ah, okay, so it's a semantic difference. Thank you for your patience and elaboration! -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE75FC16; Mon, 12 Feb 2024 14:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707748317; cv=none; b=GSKXJvQup/zOSWctbq7jPkEC3o1HWgyo11v9TYyZ11tXy6C+dVkamYzF6lzANgf5Sf4lJQ5WIzhxn/B1btrnH55ioCY4phls58418bK8D0y+ijytGTqHZMnFj45WhJiizURhMhZHezBWflFD/byv0tmSFaVshHIh6XRLfG4K/jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707748317; c=relaxed/simple; bh=3JKFf0dcMk7JwnUdDXS61uJeYNwcS3K7/8lxDPV9RgE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oeS2BSZWVoM/Ei0zqE5jBwtybW5wQOGVdI0sxb4ElrtZd+GOS+m+Qh3UJDPleLFDm9TmY2ktJcEvFsNGjVJln8vsglI35FyZAd6xOIeMUaRxnBcqLAmTUJdmFL1aHCJgDVZ1F0JYZJ4Tfyhwt+Q3UZMHnlUyh7ijs9+U6Kw0sTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AYdgzBft; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AYdgzBft" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707748317; x=1739284317; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3JKFf0dcMk7JwnUdDXS61uJeYNwcS3K7/8lxDPV9RgE=; b=AYdgzBftByJ9b3K/t/7JXfNkdatGGyVw1sIZM1siuQDWHb3pydei2Nfn LnFaH7pUqe4E//WodbSEnBxDaxpUvcSUMGc8Diu8UwBsxXUzpqNi8fhMP VuE5IDgnum4RmAuU70ux9/Y8zWD6Xnw3BmFLSwksUuRmbzu3VK1okc6lk wqpc9+RBfziIUQa75+AXB8XIJMTYRUSj6U0V4uPjlOh51260b0vsemfad IOA7H5nquR1BQ0BIcel6iIHGs3TKfHrzRYDPEMPz9EfF0Mkrz/cqWnOxU VRSS0jesQUwhDUXOzXrV0Onz5QrkjRKdH1bYyImhdrwqtae8aEu2+5JNG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="12814863" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="12814863" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:31:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="911497299" X-IronPort-AV: E=Sophos;i="6.06,264,1705392000"; d="scan'208";a="911497299" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 06:31:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rZXLZ-00000003vFt-1yfL; Mon, 12 Feb 2024 16:31:49 +0200 Date: Mon, 12 Feb 2024 16:31:49 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Linus Walleij , Miguel Ojeda , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node Message-ID: References: <20240212083426.26757-1-krzysztof.kozlowski@linaro.org> <906db6a6-48ba-41e5-be23-1dea0ecf96ee@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 12, 2024 at 03:20:26PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2024 15:09, Andy Shevchenko wrote: > > On Mon, Feb 12, 2024 at 02:56:43PM +0100, Krzysztof Kozlowski wrote: > >> On 12/02/2024 14:39, Andy Shevchenko wrote: > >>> On Mon, Feb 12, 2024 at 09:34:24AM +0100, Krzysztof Kozlowski wrote: ... > >>>> - i2c { > >>>> - #address-cells = <1>; > >>>> - #size-cells = <0>; > >>>> > >>>> - pcf8574: pcf8574@27 { > >>>> - compatible = "nxp,pcf8574"; > >>>> - reg = <0x27>; > >>>> - gpio-controller; > >>>> - #gpio-cells = <2>; > >>>> - }; > >>>> - }; > >>> > >>> In patch 3 you updated the lines that have lost their sense due to this one. > >> > >> How did they lose it? > > > > Now they are referring to the non-existed node in the example. OTOH, there is > > already hc595 case... > > All of the bindings examples do it. It's expected. > > > > > The Q here (as you pointed out that it's better to name nodes in generic way), > > how these names are okay with the schema (hc595, pcf8574) as being referred to? > > They are not OK, although I don't see the name "hc595". There is phandle > to the hc595 label, but that's fine. Not a node name. Ah, okay, so it's a semantic difference. Thank you for your patience and elaboration! -- With Best Regards, Andy Shevchenko