From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE625D91C for ; Tue, 13 Feb 2024 15:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707838982; cv=none; b=iHCm+arT2+N1dLf/9uzu1voZixxsBHQ8Ir2koGVxhgJBHYCFrZWLDKghVplEbJlPk3ZNUlD5BteOQxufRjw3FpiKO1S7uVG/fxHQawU49QFD+gBAGLupyEQYlXG0QEwFYtaVxOP4L+GIIr41QaXugIravPuCxf2+U24VbCrHRYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707838982; c=relaxed/simple; bh=6/AT8iJeTcyl0pH7C+fpkpyARJZx4RvtTWgT4hA4oP0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LD8NVGuZ3Ig9iGX+wV8nsWIP0LGhEn9bDMEuxpw+qlhHsWsdjmxPFW8hxn0z8Z+DRBebvKgwkNZku8w4QCAK4KrK/zra2CsmLQ/7CrtzOTasZ5UVOAsjf7m1Sw0LN6y/0ZGTfAlmG0JFE0tD1/Pm0hLaAmO+TpZMVQ9k/ZMCzOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=031i9T6I; arc=none smtp.client-ip=209.85.166.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="031i9T6I" Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-36427a3c284so3065ab.1 for ; Tue, 13 Feb 2024 07:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707838980; x=1708443780; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=IQj4uDUjleUNCBs7Qf2PtjvmRXZjXT8PKaV2xAnFLBE=; b=031i9T6ID2zcaRleSVS4wJe+BoSrTo4lS4Q9/k+TPKTCHmsa44jO0mpKs5eJlnppbZ dqS2A6r3ZnS1+4LoIrRUandUKkrNbAISQvVyPVp0PBA6OWH5L+9SlewL9wd4R8yTERs9 SNkfi8B2NdWOBwtf+x52av8t/x9a6VFvvZ9K5auN9vbk/fCaKiX9ZFbbNE9kBavPn/td olHoRxw2PZPzhuXYSj8lm/RX1ySvOLufvLdyzgbOO80AMMCc1hLlEwMHhfC4gqEQ4YS3 Y0AJXKFhPYvD1GalyMJEZqJu6Otg4M7JK02aWbx7AAtxPwbRWIHdgwgkerljuA3KiFu1 6mig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707838980; x=1708443780; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IQj4uDUjleUNCBs7Qf2PtjvmRXZjXT8PKaV2xAnFLBE=; b=jGZPTl+F/4+HGt1LFPAqSUuRwnEx38WM7hWv6wdrUl6K247d/tOAD6aBkV3BHo4+ZE 3draS2ZLaHZPKI4Ezj/b91icCRe18k0esSjMHFmhjoy0wVbo/XOaJ7Sb9WsQ0GR9yf+r DQPGSykqQdso/xsrfq9WVNhhohgJTth5Ihjg3atwaWx71whPjLKF5H5lxiBAjJtatXa5 vNueDXhIe2mRcNDp7Gd1b8TZgV98HeirpcId/enSjKGiKIP4pTxD5cV+csifKHIA/9k7 AxmAG0qZQKVWX6f7nI1TLgw1iPG0kkhaxTX2RQ1tpwa1vS5BUnEHWDxAOm9YA/NfcC3p YHGw== X-Gm-Message-State: AOJu0YygqavF4eqNG+JawGq7ibfNwv1EdJ3fyYKg0A+gvyiJ9j5Pr4sz cOowuxQ6SbHoVG5qNE2dQeXn59q+r/vmf1H07TSAIWG0OYIlJNPbgGz96nr+dQ== X-Google-Smtp-Source: AGHT+IHrmt2yIYNczd9dlMrOYLjL0HvWgFOQEgQ4dUIGRMglwxWo6MZ5EwZZ07CEHSW7fv6EX0rvOg== X-Received: by 2002:a05:6e02:2:b0:363:ca7e:91d with SMTP id bb2-20020a056e02000200b00363ca7e091dmr157249ilb.21.1707838979628; Tue, 13 Feb 2024 07:42:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXvxD2AtspGmOWuZJ2M5EAm6FsThntWIjcBIt6gmDrpuNhYqzgUWgZy8OmLxEJXlRa4YNKfovhu1N0OA22phRbZcdaYsmA95Ig58UygBl9asphYwptHxRyuhbtg0FZpcjTtZ8RDU+wIY1H/auMWliWvvxrkZFu03a8r9VF6dvoeJ75yFoUbWMcI+scdMlbZXULtdcIpHJMGPnp2gmavIxa6PSyJfB7ikoMSAkNxah3QC+sOBQwOlVv5rfzP23zLIoaBzzgatPtNfTyANKVTlVaN4DR7uxn+id0Q3tSTN5e/4+8KU7PnpzGeo85GSvESxcJbLdbofhg4Vf0UaULka6lj7o6iVb4z58C4fYvncRTxxav3u+jclq4XBuRA4ZjrvZhGn296hCxqPfuJp7VykFyImyxLXUBiLXqXNrx0KbugFJmkwZ17lnVwOlphOjHrB4pqihVQl5/hJK8oQdaCZ2j0jwgElwsPsDKdis8OHrVd9o8HCi9hpQ== Received: from google.com (185.83.140.34.bc.googleusercontent.com. [34.140.83.185]) by smtp.gmail.com with ESMTPSA id l186-20020a0dfbc3000000b005ffc15cea80sm1775540ywf.26.2024.02.13.07.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 07:42:59 -0800 (PST) Date: Tue, 13 Feb 2024 15:42:53 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Lu Baolu , Jean-Philippe Brucker , Joerg Roedel , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Zhangfei Gao Subject: Re: [PATCH v5 09/17] iommu/arm-smmu-v3: Put writing the context descriptor in the right order Message-ID: References: <0-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> <9-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> Hi Jason, On Tue, Feb 06, 2024 at 11:12:46AM -0400, Jason Gunthorpe wrote: > Get closer to the IOMMU API ideal that changes between domains can be > hitless. The ordering for the CD table entry is not entirely clean from > this perspective. > > When switching away from a STE with a CD table programmed in it we should > write the new STE first, then clear any old data in the CD entry. > > If we are programming a CD table for the first time to a STE then the CD > entry should be programmed before the STE is loaded. > > If we are replacing a CD table entry when the STE already points at the CD > entry then we just need to do the make/break sequence. > > Lift this code out of arm_smmu_detach_dev() so it can all be sequenced > properly. The only other caller is arm_smmu_release_device() and it is > going to free the cdtable anyhow, so it doesn't matter what is in it. > > Reviewed-by: Michael Shavit > Reviewed-by: Nicolin Chen > Tested-by: Shameer Kolothum > Tested-by: Nicolin Chen > Tested-by: Moritz Fischer > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 29 ++++++++++++++------- > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 340f3dc82c9ce0..2a6ac0af932c54 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2575,14 +2575,6 @@ static void arm_smmu_detach_dev(struct arm_smmu_master *master) > > master->domain = NULL; > master->ats_enabled = false; > - /* > - * Clearing the CD entry isn't strictly required to detach the domain > - * since the table is uninstalled anyway, but it helps avoid confusion > - * in the call to arm_smmu_write_ctx_desc on the next attach (which > - * expects the entry to be empty). > - */ > - if (smmu_domain->stage == ARM_SMMU_DOMAIN_S1 && master->cd_table.cdtab) > - arm_smmu_write_ctx_desc(master, IOMMU_NO_PASID, NULL); > } > > static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > @@ -2659,6 +2651,17 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > master->domain = NULL; > goto out_list_del; > } > + } else { > + /* > + * arm_smmu_write_ctx_desc() relies on the entry being > + * invalid to work, clear any existing entry. > + */ > + ret = arm_smmu_write_ctx_desc(master, IOMMU_NO_PASID, > + NULL); > + if (ret) { > + master->domain = NULL; > + goto out_list_del; > + } Instead of having duplicate if (ret) { master->domain = NULL; goto out_list_del; } In the if and the else, we can just move it outside. > } > > ret = arm_smmu_write_ctx_desc(master, IOMMU_NO_PASID, &smmu_domain->cd); > @@ -2668,15 +2671,23 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > } > > arm_smmu_make_cdtable_ste(&target, master); > + arm_smmu_install_ste_for_dev(master, &target); > break; > case ARM_SMMU_DOMAIN_S2: > arm_smmu_make_s2_domain_ste(&target, master, smmu_domain); > + arm_smmu_install_ste_for_dev(master, &target); > + if (master->cd_table.cdtab) > + arm_smmu_write_ctx_desc(master, IOMMU_NO_PASID, > + NULL); > break; > case ARM_SMMU_DOMAIN_BYPASS: > arm_smmu_make_bypass_ste(&target); > + arm_smmu_install_ste_for_dev(master, &target); > + if (master->cd_table.cdtab) > + arm_smmu_write_ctx_desc(master, IOMMU_NO_PASID, > + NULL); > break; > } This invalidates the CD while the STE is in bypass/S2 which is a new behavior to the driver, I don’t see anything from the user manual about this, so I believe that is fine. Reviewed-by: Mostafa Saleh > - arm_smmu_install_ste_for_dev(master, &target); > > arm_smmu_enable_ats(master); > goto out_unlock; > -- > 2.43.0 > Thanks, Mostafa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F12C4829A for ; Tue, 13 Feb 2024 15:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ugJbyp5+KjoccOeG0ZsigODVFHhkATh4Uiq6kRmjv+4=; b=Vu5qNGxVbaVrAQ ykvvsVmvBdAaxmbt12Y3I2VRI9VTpvZacysq6df0gvFPr2JY3K7hnWxzqaSWVl8TOxXBIRGt/8bEG AzrNfgD2MpfMsTD8qflWoeolwWQZ3MZNEgiEr2z9+P2hRLzSyjC2TLa/AjEah46GZUMi2cWMgRBgI P/JcZsvHIy8uzrP05QrY8iHJsmaL/Q5/P/5EsFd2zQVWoBq8iUI3m2PF8dsA1L4BkZXbP2Kg9WZr3 OmvFIRuhas/hbQTSMlhzwSbcPwxXmBelokC6KDmheaxvsfcMBJcXqFBZL9oMb4pOuuiFXiGAaP/NV H7lAj4UXlxNXSzjOViSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZuw4-00000009nzT-2Yct; Tue, 13 Feb 2024 15:43:04 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZuw0-00000009nyX-3iqb for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 15:43:03 +0000 Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-363c980faa2so105545ab.0 for ; Tue, 13 Feb 2024 07:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707838980; x=1708443780; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=IQj4uDUjleUNCBs7Qf2PtjvmRXZjXT8PKaV2xAnFLBE=; b=ovzYSZ8QwZ3fjgvMW5tjz5w6FkJpzyDRy8bj2dqXSU2qdygsG63jwsWpZSAioiwlgf UJm9kGtQtxac+jF32jkiRWEzxBB9t5GUiUDMj99/Oh63gJ4mXjFoHvl9R+ydg9zI6GSm V5mRk4Ny6GI68bByVMFvuD/zGs2e1Z5iIlcKSM8uU88eCO5JEvwFTRoXlEng2rLypG5V ksrW8JqGZ6IkmDOMr02+6Wp8mVLq2ujBj0YdLBvhrME/qd1D/BRRTqiCz52T+czRov7f hHBsMb5tN1zK78RjvJJFJ/PcNscv3FrjFIue9YJQ+fTCudVeooogGImrynSYSuw5KCUw 8N/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707838980; x=1708443780; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IQj4uDUjleUNCBs7Qf2PtjvmRXZjXT8PKaV2xAnFLBE=; b=BgqLFxx5jKnbhTw6ShQhSQjqMmyVhupoUK0aSAb0p5uZ1b9zJ8Qn37xlhVoJdzUVTb XYcz1pBe5/gSrLHp5aP3JLeBaqfeYdA3Ztxfe4b/ikmZQQ5DcpxrTJHD56N0Gdoc2y2z vMq0q5y54YdLeIHboJ1HA+S5miAAgX3hByXQ09tnzvKmqRERmjRTbhNK8W/gVPqhxRTx Q4Q1l3I0X1jUqrwCUi+Yp66A+Rqk8gdkntCLoZHe9kmTKsg7XtpBRr9imhNSEto9fhNs bopvQ7Bx79YSDxHoqEGFuO+4smHM5fX6OD1568OGDT63DC8bj7RjtpsxBcSalMFKPuXs G4Zw== X-Forwarded-Encrypted: i=1; AJvYcCW+tW9WIpUCQoj3BQ1StdKDLsVzs8N0oDiQddtFMCc4zzJ0iaNpCygatku+ud/zZTDJCeQATg1rkGI+AtQN8mYJcPZli44sXMbF+iRGvhokHksv6AI= X-Gm-Message-State: AOJu0YzRGr2u5SMAQcLeTtnIDYjVIGhu2qF196aD6RlwRxq9iPAtXyYP MYqsp2tyMWZiwdHYI618IcvE11k3BkYuCDjuXEyBMXFYQwCt6Kedbnp2sqOWsg== X-Google-Smtp-Source: AGHT+IHrmt2yIYNczd9dlMrOYLjL0HvWgFOQEgQ4dUIGRMglwxWo6MZ5EwZZ07CEHSW7fv6EX0rvOg== X-Received: by 2002:a05:6e02:2:b0:363:ca7e:91d with SMTP id bb2-20020a056e02000200b00363ca7e091dmr157249ilb.21.1707838979628; Tue, 13 Feb 2024 07:42:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXvxD2AtspGmOWuZJ2M5EAm6FsThntWIjcBIt6gmDrpuNhYqzgUWgZy8OmLxEJXlRa4YNKfovhu1N0OA22phRbZcdaYsmA95Ig58UygBl9asphYwptHxRyuhbtg0FZpcjTtZ8RDU+wIY1H/auMWliWvvxrkZFu03a8r9VF6dvoeJ75yFoUbWMcI+scdMlbZXULtdcIpHJMGPnp2gmavIxa6PSyJfB7ikoMSAkNxah3QC+sOBQwOlVv5rfzP23zLIoaBzzgatPtNfTyANKVTlVaN4DR7uxn+id0Q3tSTN5e/4+8KU7PnpzGeo85GSvESxcJbLdbofhg4Vf0UaULka6lj7o6iVb4z58C4fYvncRTxxav3u+jclq4XBuRA4ZjrvZhGn296hCxqPfuJp7VykFyImyxLXUBiLXqXNrx0KbugFJmkwZ17lnVwOlphOjHrB4pqihVQl5/hJK8oQdaCZ2j0jwgElwsPsDKdis8OHrVd9o8HCi9hpQ== Received: from google.com (185.83.140.34.bc.googleusercontent.com. [34.140.83.185]) by smtp.gmail.com with ESMTPSA id l186-20020a0dfbc3000000b005ffc15cea80sm1775540ywf.26.2024.02.13.07.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 07:42:59 -0800 (PST) Date: Tue, 13 Feb 2024 15:42:53 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Lu Baolu , Jean-Philippe Brucker , Joerg Roedel , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Zhangfei Gao Subject: Re: [PATCH v5 09/17] iommu/arm-smmu-v3: Put writing the context descriptor in the right order Message-ID: References: <0-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> <9-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_074301_016601_3A688881 X-CRM114-Status: GOOD ( 34.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFzb24sCgpPbiBUdWUsIEZlYiAwNiwgMjAyNCBhdCAxMToxMjo0NkFNIC0wNDAwLCBKYXNv biBHdW50aG9ycGUgd3JvdGU6Cj4gR2V0IGNsb3NlciB0byB0aGUgSU9NTVUgQVBJIGlkZWFsIHRo YXQgY2hhbmdlcyBiZXR3ZWVuIGRvbWFpbnMgY2FuIGJlCj4gaGl0bGVzcy4gVGhlIG9yZGVyaW5n IGZvciB0aGUgQ0QgdGFibGUgZW50cnkgaXMgbm90IGVudGlyZWx5IGNsZWFuIGZyb20KPiB0aGlz IHBlcnNwZWN0aXZlLgo+IAo+IFdoZW4gc3dpdGNoaW5nIGF3YXkgZnJvbSBhIFNURSB3aXRoIGEg Q0QgdGFibGUgcHJvZ3JhbW1lZCBpbiBpdCB3ZSBzaG91bGQKPiB3cml0ZSB0aGUgbmV3IFNURSBm aXJzdCwgdGhlbiBjbGVhciBhbnkgb2xkIGRhdGEgaW4gdGhlIENEIGVudHJ5Lgo+IAo+IElmIHdl IGFyZSBwcm9ncmFtbWluZyBhIENEIHRhYmxlIGZvciB0aGUgZmlyc3QgdGltZSB0byBhIFNURSB0 aGVuIHRoZSBDRAo+IGVudHJ5IHNob3VsZCBiZSBwcm9ncmFtbWVkIGJlZm9yZSB0aGUgU1RFIGlz IGxvYWRlZC4KPiAKPiBJZiB3ZSBhcmUgcmVwbGFjaW5nIGEgQ0QgdGFibGUgZW50cnkgd2hlbiB0 aGUgU1RFIGFscmVhZHkgcG9pbnRzIGF0IHRoZSBDRAo+IGVudHJ5IHRoZW4gd2UganVzdCBuZWVk IHRvIGRvIHRoZSBtYWtlL2JyZWFrIHNlcXVlbmNlLgo+IAo+IExpZnQgdGhpcyBjb2RlIG91dCBv ZiBhcm1fc21tdV9kZXRhY2hfZGV2KCkgc28gaXQgY2FuIGFsbCBiZSBzZXF1ZW5jZWQKPiBwcm9w ZXJseS4gVGhlIG9ubHkgb3RoZXIgY2FsbGVyIGlzIGFybV9zbW11X3JlbGVhc2VfZGV2aWNlKCkg YW5kIGl0IGlzCj4gZ29pbmcgdG8gZnJlZSB0aGUgY2R0YWJsZSBhbnlob3csIHNvIGl0IGRvZXNu J3QgbWF0dGVyIHdoYXQgaXMgaW4gaXQuCj4gCj4gUmV2aWV3ZWQtYnk6IE1pY2hhZWwgU2hhdml0 IDxtc2hhdml0QGdvb2dsZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IE5pY29saW4gQ2hlbiA8bmljb2xp bmNAbnZpZGlhLmNvbT4KPiBUZXN0ZWQtYnk6IFNoYW1lZXIgS29sb3RodW0gPHNoYW1lZXJhbGku a29sb3RodW0udGhvZGlAaHVhd2VpLmNvbT4KPiBUZXN0ZWQtYnk6IE5pY29saW4gQ2hlbiA8bmlj b2xpbmNAbnZpZGlhLmNvbT4KPiBUZXN0ZWQtYnk6IE1vcml0eiBGaXNjaGVyIDxtb3JpdHpmQGdv b2dsZS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbnZpZGlhLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyB8 IDI5ICsrKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9u cygrKSwgOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9hcm0v YXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYz L2FybS1zbW11LXYzLmMKPiBpbmRleCAzNDBmM2RjODJjOWNlMC4uMmE2YWMwYWY5MzJjNTQgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYwo+ ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMKPiBAQCAt MjU3NSwxNCArMjU3NSw2IEBAIHN0YXRpYyB2b2lkIGFybV9zbW11X2RldGFjaF9kZXYoc3RydWN0 IGFybV9zbW11X21hc3RlciAqbWFzdGVyKQo+ICAKPiAgCW1hc3Rlci0+ZG9tYWluID0gTlVMTDsK PiAgCW1hc3Rlci0+YXRzX2VuYWJsZWQgPSBmYWxzZTsKPiAtCS8qCj4gLQkgKiBDbGVhcmluZyB0 aGUgQ0QgZW50cnkgaXNuJ3Qgc3RyaWN0bHkgcmVxdWlyZWQgdG8gZGV0YWNoIHRoZSBkb21haW4K PiAtCSAqIHNpbmNlIHRoZSB0YWJsZSBpcyB1bmluc3RhbGxlZCBhbnl3YXksIGJ1dCBpdCBoZWxw cyBhdm9pZCBjb25mdXNpb24KPiAtCSAqIGluIHRoZSBjYWxsIHRvIGFybV9zbW11X3dyaXRlX2N0 eF9kZXNjIG9uIHRoZSBuZXh0IGF0dGFjaCAod2hpY2gKPiAtCSAqIGV4cGVjdHMgdGhlIGVudHJ5 IHRvIGJlIGVtcHR5KS4KPiAtCSAqLwo+IC0JaWYgKHNtbXVfZG9tYWluLT5zdGFnZSA9PSBBUk1f U01NVV9ET01BSU5fUzEgJiYgbWFzdGVyLT5jZF90YWJsZS5jZHRhYikKPiAtCQlhcm1fc21tdV93 cml0ZV9jdHhfZGVzYyhtYXN0ZXIsIElPTU1VX05PX1BBU0lELCBOVUxMKTsKPiAgfQo+ICAKPiAg c3RhdGljIGludCBhcm1fc21tdV9hdHRhY2hfZGV2KHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFp biwgc3RydWN0IGRldmljZSAqZGV2KQo+IEBAIC0yNjU5LDYgKzI2NTEsMTcgQEAgc3RhdGljIGlu dCBhcm1fc21tdV9hdHRhY2hfZGV2KHN0cnVjdCBpb21tdV9kb21haW4gKmRvbWFpbiwgc3RydWN0 IGRldmljZSAqZGV2KQo+ICAJCQkJbWFzdGVyLT5kb21haW4gPSBOVUxMOwo+ICAJCQkJZ290byBv dXRfbGlzdF9kZWw7Cj4gIAkJCX0KPiArCQl9IGVsc2Ugewo+ICsJCQkvKgo+ICsJCQkgKiBhcm1f c21tdV93cml0ZV9jdHhfZGVzYygpIHJlbGllcyBvbiB0aGUgZW50cnkgYmVpbmcKPiArCQkJICog aW52YWxpZCB0byB3b3JrLCBjbGVhciBhbnkgZXhpc3RpbmcgZW50cnkuCj4gKwkJCSAqLwo+ICsJ CQlyZXQgPSBhcm1fc21tdV93cml0ZV9jdHhfZGVzYyhtYXN0ZXIsIElPTU1VX05PX1BBU0lELAo+ ICsJCQkJCQkgICAgICBOVUxMKTsKPiArCQkJaWYgKHJldCkgewo+ICsJCQkJbWFzdGVyLT5kb21h aW4gPSBOVUxMOwo+ICsJCQkJZ290byBvdXRfbGlzdF9kZWw7Cj4gKwkJCX0KCkluc3RlYWQgb2Yg aGF2aW5nIGR1cGxpY2F0ZQogICAgICAgICAgIGlmIChyZXQpIHsKICAgICAgICAgICAgICAgbWFz dGVyLT5kb21haW4gPSBOVUxMOwogICAgICAgICAgICAgICBnb3RvIG91dF9saXN0X2RlbDsKICAg ICAgICAgICB9CgpJbiB0aGUgaWYgYW5kIHRoZSBlbHNlLCB3ZSBjYW4ganVzdCBtb3ZlIGl0IG91 dHNpZGUuCgo+ICAJCX0KPiAgCj4gIAkJcmV0ID0gYXJtX3NtbXVfd3JpdGVfY3R4X2Rlc2MobWFz dGVyLCBJT01NVV9OT19QQVNJRCwgJnNtbXVfZG9tYWluLT5jZCk7Cj4gQEAgLTI2NjgsMTUgKzI2 NzEsMjMgQEAgc3RhdGljIGludCBhcm1fc21tdV9hdHRhY2hfZGV2KHN0cnVjdCBpb21tdV9kb21h aW4gKmRvbWFpbiwgc3RydWN0IGRldmljZSAqZGV2KQo+ICAJCX0KPiAgCj4gIAkJYXJtX3NtbXVf bWFrZV9jZHRhYmxlX3N0ZSgmdGFyZ2V0LCBtYXN0ZXIpOwo+ICsJCWFybV9zbW11X2luc3RhbGxf c3RlX2Zvcl9kZXYobWFzdGVyLCAmdGFyZ2V0KTsKPiAgCQlicmVhazsKPiAgCWNhc2UgQVJNX1NN TVVfRE9NQUlOX1MyOgo+ICAJCWFybV9zbW11X21ha2VfczJfZG9tYWluX3N0ZSgmdGFyZ2V0LCBt YXN0ZXIsIHNtbXVfZG9tYWluKTsKPiArCQlhcm1fc21tdV9pbnN0YWxsX3N0ZV9mb3JfZGV2KG1h c3RlciwgJnRhcmdldCk7Cj4gKwkJaWYgKG1hc3Rlci0+Y2RfdGFibGUuY2R0YWIpCj4gKwkJCWFy bV9zbW11X3dyaXRlX2N0eF9kZXNjKG1hc3RlciwgSU9NTVVfTk9fUEFTSUQsCj4gKwkJCQkJCSAg ICAgIE5VTEwpOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSBBUk1fU01NVV9ET01BSU5fQllQQVNTOgo+ ICAJCWFybV9zbW11X21ha2VfYnlwYXNzX3N0ZSgmdGFyZ2V0KTsKPiArCQlhcm1fc21tdV9pbnN0 YWxsX3N0ZV9mb3JfZGV2KG1hc3RlciwgJnRhcmdldCk7Cj4gKwkJaWYgKG1hc3Rlci0+Y2RfdGFi bGUuY2R0YWIpCj4gKwkJCWFybV9zbW11X3dyaXRlX2N0eF9kZXNjKG1hc3RlciwgSU9NTVVfTk9f UEFTSUQsCj4gKwkJCQkJCSAgICAgIE5VTEwpOwo+ICAJCWJyZWFrOwo+ICAJfQpUaGlzIGludmFs aWRhdGVzIHRoZSBDRCB3aGlsZSB0aGUgU1RFIGlzIGluIGJ5cGFzcy9TMiB3aGljaCBpcyBhIG5l dyBiZWhhdmlvcgp0byB0aGUgZHJpdmVyLCBJIGRvbuKAmXQgc2VlIGFueXRoaW5nIGZyb20gdGhl IHVzZXIgbWFudWFsIGFib3V0IHRoaXMsIHNvIEkKYmVsaWV2ZSB0aGF0IGlzIGZpbmUuCgpSZXZp ZXdlZC1ieTogTW9zdGFmYSBTYWxlaCA8c21vc3RhZmFAZ29vZ2xlLmNvbT4KCj4gLQlhcm1fc21t dV9pbnN0YWxsX3N0ZV9mb3JfZGV2KG1hc3RlciwgJnRhcmdldCk7Cj4gIAo+ICAJYXJtX3NtbXVf ZW5hYmxlX2F0cyhtYXN0ZXIpOwo+ICAJZ290byBvdXRfdW5sb2NrOwo+IC0tIAo+IDIuNDMuMAo+ CgpUaGFua3MsCk1vc3RhZmEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK