From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 560D1C5478C for ; Mon, 26 Feb 2024 22:47:55 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rejlH-00048p-TT; Mon, 26 Feb 2024 22:47:52 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rejlG-00048g-99 for linux-f2fs-devel@lists.sourceforge.net; Mon, 26 Feb 2024 22:47:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8lbptSU57JD2hlE6MWgKbuhahaE/sQ4zzkDcWOQfFpA=; b=fT00DyfdUAUcK5bDWbBIBqlFtK +brALYAK28MTd8nNJ/yhtspLlSPtjko/IS9HxjgjhH8Ba4rLJw3irwmQ7nBkpC5fVaI/+hyVwYBQT lUFryrf09+gGTj9ePlLtdmkebPd9Hb9xPKbPa5pQKraK/algUtJ2i0pHOnYWxONQOIQM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8lbptSU57JD2hlE6MWgKbuhahaE/sQ4zzkDcWOQfFpA=; b=PFAhPQ1A4A36kXbTr8SXFEtAlH M6jAAGKXx2En+CbetOd5UQOgMqLPMlsyK9B76/z6pmp67eF9uTs+SXtCWA/8FLwV+ipMbOgquYjzJ 03Obs2US46It8PNzzGt4qP8a7Jgz4iPkoaMBbHWm+1llouZ9J9HBJ5jfFod5fJlKrg/4=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rejlF-0002IJ-1t for linux-f2fs-devel@lists.sourceforge.net; Mon, 26 Feb 2024 22:47:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5465ACE062B; Mon, 26 Feb 2024 22:47:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C472C433C7; Mon, 26 Feb 2024 22:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708987656; bh=SIF6l2OHEXEE3BAbQV6qsonqNnLgzP8DvqtGYEaQfO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p00DO6ydaneDwhDZD87n2MMe5t7m6vJWietj9ki3VDSivg0mFNftdWa+kwiBfnfZY uUTWl2aw3awaqTWx6rU1iWJXAP0Urgz0r2xkvwbXAbfTPqcEHRDDjT4qpc5RrQt1O1 pl7KzGBS0BGdDvNQcx7U961icohJeNW3AzOE0NbaUE63ZF/gM/eeulShaEZmPzVxcr 8xd1UKweq57OMo57Sm4Vj6SDhXOMrtVUr2clqZgtK34L7cgZSWBn+yTfBG8EGO9Ku1 fntyYzlhzyi1YIo9QPm1xGaSdV/tst2hNuclApwV4HFpjqKKXhcdMvgGeNN0xlfL9b WEoqzCPEXU0vw== Date: Mon, 26 Feb 2024 14:47:34 -0800 From: Jaegeuk Kim To: Daeho Jeong Message-ID: References: <20240223205535.307307-1-jaegeuk@kernel.org> <20240223205535.307307-5-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1rejlF-0002IJ-1t Subject: Re: [f2fs-dev] [PATCH 5/5] f2fs: allow to mount if cap is 100 X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDIvMjYsIERhZWhvIEplb25nIHdyb3RlOgo+IE9uIEZyaSwgRmViIDIzLCAyMDI0IGF0IDEy OjU24oCvUE0gSmFlZ2V1ayBLaW0gPGphZWdldWtAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4g RG9uJ3QgYmxvY2sgbW91bnRpbmcgdGhlIHBhcnRpdGlvbiwgaWYgY2FwIGlzIDEwMCUuCj4gPgo+ ID4gU2lnbmVkLW9mZi1ieTogSmFlZ2V1ayBLaW0gPGphZWdldWtAa2VybmVsLm9yZz4KPiA+IC0t LQo+ID4gIGZzL2YyZnMvc2VnbWVudC5jIHwgMyArKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2ZzL2YyZnMvc2VnbWVudC5jIGIvZnMv ZjJmcy9zZWdtZW50LmMKPiA+IGluZGV4IDZkNTg2YWU4YjU1Zi4uZjExMzYxMTUyZDJhIDEwMDY0 NAo+ID4gLS0tIGEvZnMvZjJmcy9zZWdtZW50LmMKPiA+ICsrKyBiL2ZzL2YyZnMvc2VnbWVudC5j Cj4gPiBAQCAtOTA0LDYgKzkwNCw5IEBAIGludCBmMmZzX2Rpc2FibGVfY3BfYWdhaW4oc3RydWN0 IGYyZnNfc2JfaW5mbyAqc2JpLCBibG9ja190IHVudXNhYmxlKQo+ID4gIHsKPiA+ICAgICAgICAg aW50IG92cF9ob2xlX3NlZ3MgPQo+ID4gICAgICAgICAgICAgICAgIChvdmVycHJvdmlzaW9uX3Nl Z21lbnRzKHNiaSkgLSByZXNlcnZlZF9zZWdtZW50cyhzYmkpKTsKPiA+ICsKPiA+ICsgICAgICAg aWYgKEYyRlNfT1BUSU9OKHNiaSkudW51c2FibGVfY2FwX3BlcmMgPT0gMTAwKQo+ID4gKyAgICAg ICAgICAgICAgIHJldHVybiAwOwo+IAo+IFdpdGggdGhpcywgZjJmcyB3aWxsIG5vdCBleGVjdXRl IEdDLiBXaGF0IGlzIHRoaXMgMTAwCj4gdW51c2FibGVfY2FwX3BlcmMgdXNlZCBmb3I/CgpUaGVv cml0aWNhbGx5LCBpdCB3b24ndCwgYnV0IEkgd2FzIGhpdHRpbmcgYSBHQyBsb29wLCBhbmQgSSBz dXNwZWN0ZWQgYSB3cm9uZwpzZWN0aW9uL3NlZ21lbnQgbGF5b3V0LiBTbywgSSBwb3N0ZWQgdGhl IGJlbG93LCBhbmQgZ3Vlc3Mgd2UgbmVlZCB0aGlzIHBhdGNoCmFzIHdvcmthcm91bmQuCgpodHRw czovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QvZjJmcy9wYXRjaC8yMDI0MDIyNDAxMTQx MS4zODIwNzE5LTEtamFlZ2V1a0BrZXJuZWwub3JnLwoKPiAKPiA+ICAgICAgICAgaWYgKHVudXNh YmxlID4gRjJGU19PUFRJT04oc2JpKS51bnVzYWJsZV9jYXApCj4gPiAgICAgICAgICAgICAgICAg cmV0dXJuIC1FQUdBSU47Cj4gPiAgICAgICAgIGlmIChpc19zYmlfZmxhZ19zZXQoc2JpLCBTQklf Q1BfRElTQUJMRURfUVVJQ0spICYmCj4gPiAtLQo+ID4gMi40NC4wLnJjMC4yNTguZzczMjBlOTU4 ODYtZ29vZwo+ID4KPiA+Cj4gPgo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiA+IExpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiBMaW51 eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldAo+ID4gaHR0cHM6Ly9saXN0cy5zb3Vy Y2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFp bGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8v bGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DD9130AEE for ; Mon, 26 Feb 2024 22:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708987657; cv=none; b=sDiLYkU93KZDgHqJI6yTrExguBBnNGfi3VE3G0aPGxeMlepJOoSQyI6hhV5zv5K4JkvFhUn3rW+GWB9xQspXVQ36tKh35ewUitgvYkMCDKWM4dvagvQYj1A67xuR2HVd5Hmv9cbDXoxINiBzLkJULr7d4LuiCYYNnQIfiJhz5kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708987657; c=relaxed/simple; bh=SIF6l2OHEXEE3BAbQV6qsonqNnLgzP8DvqtGYEaQfO4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bZ+4twaqO+QAgMVyWBYtFFhGz9BTW6PxD12grjxicam7vzBGiWGN+jCmZkFP4xREFcw6+8xZ76L3ecRUZ0OrZhE8p5DU/C4R5iZouB45WHIYHTQbPaFEloRWTTbkmaDAihLbUj7k1STOnVoRyIQdcYntvbbgGyCWIC2uDFMkZp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p00DO6yd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p00DO6yd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C472C433C7; Mon, 26 Feb 2024 22:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708987656; bh=SIF6l2OHEXEE3BAbQV6qsonqNnLgzP8DvqtGYEaQfO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p00DO6ydaneDwhDZD87n2MMe5t7m6vJWietj9ki3VDSivg0mFNftdWa+kwiBfnfZY uUTWl2aw3awaqTWx6rU1iWJXAP0Urgz0r2xkvwbXAbfTPqcEHRDDjT4qpc5RrQt1O1 pl7KzGBS0BGdDvNQcx7U961icohJeNW3AzOE0NbaUE63ZF/gM/eeulShaEZmPzVxcr 8xd1UKweq57OMo57Sm4Vj6SDhXOMrtVUr2clqZgtK34L7cgZSWBn+yTfBG8EGO9Ku1 fntyYzlhzyi1YIo9QPm1xGaSdV/tst2hNuclApwV4HFpjqKKXhcdMvgGeNN0xlfL9b WEoqzCPEXU0vw== Date: Mon, 26 Feb 2024 14:47:34 -0800 From: Jaegeuk Kim To: Daeho Jeong Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 5/5] f2fs: allow to mount if cap is 100 Message-ID: References: <20240223205535.307307-1-jaegeuk@kernel.org> <20240223205535.307307-5-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 02/26, Daeho Jeong wrote: > On Fri, Feb 23, 2024 at 12:56 PM Jaegeuk Kim wrote: > > > > Don't block mounting the partition, if cap is 100%. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/segment.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > > index 6d586ae8b55f..f11361152d2a 100644 > > --- a/fs/f2fs/segment.c > > +++ b/fs/f2fs/segment.c > > @@ -904,6 +904,9 @@ int f2fs_disable_cp_again(struct f2fs_sb_info *sbi, block_t unusable) > > { > > int ovp_hole_segs = > > (overprovision_segments(sbi) - reserved_segments(sbi)); > > + > > + if (F2FS_OPTION(sbi).unusable_cap_perc == 100) > > + return 0; > > With this, f2fs will not execute GC. What is this 100 > unusable_cap_perc used for? Theoritically, it won't, but I was hitting a GC loop, and I suspected a wrong section/segment layout. So, I posted the below, and guess we need this patch as workaround. https://patchwork.kernel.org/project/f2fs/patch/20240224011411.3820719-1-jaegeuk@kernel.org/ > > > if (unusable > F2FS_OPTION(sbi).unusable_cap) > > return -EAGAIN; > > if (is_sbi_flag_set(sbi, SBI_CP_DISABLED_QUICK) && > > -- > > 2.44.0.rc0.258.g7320e95886-goog > > > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel