From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF2DBC5478C for ; Tue, 27 Feb 2024 10:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tVtKE/5zNMbPKj1Kmatdr0cshT6X8wqumQk98VsKgEA=; b=JrloYET/Ou4c8p EA9q1g8vy58TcKQhDGlJTM6B2wwIXK1UPtRE/lFrDPzk822LNweIz9MwK9X87jXJHcb6AW6knEDtc Xg/qPwHc9cCtCJ1Qt3Q2cmvqp0vRTfdyFwPdDDLV0ubI0YeFJB/uRTLf1auUU1jUF+APSRQ5nLiN8 kwKZpR8GN5rj5hmUB5uKAOR4UniDU8pPdEHJwXGx+WWKICMXcHG5k/CgeEOUhuz7u/WlxjTKaDevn faKCwCR4X3/CqOvI7dMuPs/MCr9lCC6TByfCP6sZSnX66oY4OgPx61VrECBGrc5AzYAuY2J+im24v P3kFer7b0BeGt2YXU2cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reuPj-00000004fFD-0IBn; Tue, 27 Feb 2024 10:10:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reuPg-00000004fEQ-2DPe for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 10:10:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7124FDA7; Tue, 27 Feb 2024 02:10:53 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.79.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 805E83F762; Tue, 27 Feb 2024 02:10:13 -0800 (PST) Date: Tue, 27 Feb 2024 10:10:09 +0000 From: Mark Rutland To: takakura@valinux.co.jp Cc: catalin.marinas@arm.com, will@kernel.org, ardb@kernel.org, rmk+kernel@armlinux.org.uk, Jonathan.Cameron@huawei.com, gregkh@linuxfoundation.org, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/kernel/setup: Update comment on interrupt masking Message-ID: References: <20240225021812.4834-1-takakura@valinux.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240225021812.4834-1-takakura@valinux.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_021016_634254_9539DE98 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 25, 2024 at 11:18:12AM +0900, takakura@valinux.co.jp wrote: > From: Ryo Takakura > > DAIF_PROCCTX_NOIRQ contains FIQ bit. > Update the comment as only asynchronous aborts are unmasked > and FIQ is still masked. > > Signed-off-by: Ryo Takakura > --- > arch/arm64/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index 0ea45b6d0177..9b9fdb64c684 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -298,7 +298,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > dynamic_scs_init(); > > /* > - * Unmask asynchronous aborts and fiq after bringing up possible > + * Unmask asynchronous aborts after bringing up possible > * earlycon. (Report possible System Errors once we can report this > * occurred). > */ I think we can further simplify/clarify that as: /* * Unmask SError as soon as possible after initializing earlycon so * that we can report any SErrors immediately. */ With that wording: Acked-by: Mark Rutland Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C96561369AB for ; Tue, 27 Feb 2024 10:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709028618; cv=none; b=EAZWOaxILpypKFM5qSUHEbvjdvNT77lQcIgOSA0jJFcL2zE5Onp9S95qWVHRBbaiaZF1kjhBU+6n1c2B7VG+RqXs0EzN+eDaOBgglE45auluBhUF1Jqf3OfbLF20Gt5FRq80po0HbAzeNnmkN6c/b0ARpAxteAgHu3zz7SQSN3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709028618; c=relaxed/simple; bh=5DeHCpzgrmkG2dRXy0tfVP5G0gRI3ljJctqxS1/EEvo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BKlYHvRCGj+4DEfjCjC4Gt1/zOZCUOFdpvErwcLHZg8cwU5sRjPgIwLj11khTsaSrdf7vmt5qt45a95IHAsni+BmzjjjjwFY8p2UZWMYV97y+NjBtTQ3Rz6nxai+p9/wTUr7SJJHYF0Y0/BrD6s83fURXN8UXQAxnqMVoa4Rzc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7124FDA7; Tue, 27 Feb 2024 02:10:53 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.79.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 805E83F762; Tue, 27 Feb 2024 02:10:13 -0800 (PST) Date: Tue, 27 Feb 2024 10:10:09 +0000 From: Mark Rutland To: takakura@valinux.co.jp Cc: catalin.marinas@arm.com, will@kernel.org, ardb@kernel.org, rmk+kernel@armlinux.org.uk, Jonathan.Cameron@huawei.com, gregkh@linuxfoundation.org, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/kernel/setup: Update comment on interrupt masking Message-ID: References: <20240225021812.4834-1-takakura@valinux.co.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240225021812.4834-1-takakura@valinux.co.jp> On Sun, Feb 25, 2024 at 11:18:12AM +0900, takakura@valinux.co.jp wrote: > From: Ryo Takakura > > DAIF_PROCCTX_NOIRQ contains FIQ bit. > Update the comment as only asynchronous aborts are unmasked > and FIQ is still masked. > > Signed-off-by: Ryo Takakura > --- > arch/arm64/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index 0ea45b6d0177..9b9fdb64c684 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -298,7 +298,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > dynamic_scs_init(); > > /* > - * Unmask asynchronous aborts and fiq after bringing up possible > + * Unmask asynchronous aborts after bringing up possible > * earlycon. (Report possible System Errors once we can report this > * occurred). > */ I think we can further simplify/clarify that as: /* * Unmask SError as soon as possible after initializing earlycon so * that we can report any SErrors immediately. */ With that wording: Acked-by: Mark Rutland Mark.