From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24A82C5478C for ; Tue, 27 Feb 2024 15:02:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D78C710E7E0; Tue, 27 Feb 2024 15:02:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="hS0GFSIZ"; dkim-atps=neutral Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3DBDE10E8C4 for ; Tue, 27 Feb 2024 15:02:15 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 77551C0005; Tue, 27 Feb 2024 15:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709046132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vR8V0WErYwpzeuyXZR2XstON7tK8EAywBDaXljEOHbM=; b=hS0GFSIZEFjR1CcZ98qQIo7wPJVSpoGAlUKPunXp/pnELIr6vI3Nb0Jxr9nZkY8eXTvmku A53V7Vq3v15CCCmLA0cNERf7NraoWwTRFa5lz5T7FZRzii8R4F5/cys+sMlkLE8B00I1KT o33VNzQfSuAgwUR7ZdcaWUCtqb4P6p6uaUPegpAyC8PN9HMSnvvT/2SYspmjwczV2MbXZS le9KaZ41iUYx6jBRzPBWDnHcWELlwZDs3QtZkhd9crChG4BxKp/AeNmIvvmkf9FtmKRknX uULmoqih6lkWdxiMOLduq8+tAh61DbpmccTVu7XxZcYCbsSNF0Eu+7Hdzk9nPw== Date: Tue, 27 Feb 2024 16:02:10 +0100 From: Louis Chauvet To: Pekka Paalanen Cc: Rodrigo Siqueira , Melissa Wen , =?iso-8859-1?Q?Ma=EDra?= Canal , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , arthurgrillo@riseup.net, Jonathan Corbet , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com Subject: Re: [PATCH v2 7/9] drm/vkms: Add range and encoding properties to pixel_read function Message-ID: Mail-Followup-To: Pekka Paalanen , Rodrigo Siqueira , Melissa Wen , =?iso-8859-1?Q?Ma=EDra?= Canal , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , arthurgrillo@riseup.net, Jonathan Corbet , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com References: <20240223-yuv-v2-0-aa6be2827bb7@bootlin.com> <20240223-yuv-v2-7-aa6be2827bb7@bootlin.com> <20240226142343.459f23f7.pekka.paalanen@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240226142343.459f23f7.pekka.paalanen@collabora.com> X-GND-Sasl: louis.chauvet@bootlin.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" (same as for PATCHv2 6/9, I took the patch from Arthur with no modifications) Le 26/02/24 - 14:23, Pekka Paalanen a écrit : > On Fri, 23 Feb 2024 12:37:27 +0100 > Louis Chauvet wrote: > > > From: Arthur Grillo > > > > Create range and encoding properties. This should be noop, as none of > > the conversion functions need those properties. > > None of the conversion function needs this? How can one say so? > The previous patch is making use of them already, AFAICT? It's my fault, I mixed the commits (in Arthur's series, "Add range..." was before "Add YUV support"), but for me it makes no sens to have the color property without the support in the driver. Maybe it's better just to merge "Add range..." with "Add YUV support"? > How is this a noop? Is it not exposing new UAPI from VKMS? It's not a no-op from userspace, but from the driver side, yes. Kind regards, Louis Chauvet > Thanks, > pq > > > > > Signed-off-by: Arthur Grillo > > [Louis Chauvet: retained only relevant parts] > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/vkms/vkms_plane.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > > index 427ca67c60ce..95dfde297377 100644 > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > @@ -228,5 +228,14 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev, > > drm_plane_create_rotation_property(&plane->base, DRM_MODE_ROTATE_0, > > DRM_MODE_ROTATE_MASK | DRM_MODE_REFLECT_MASK); > > > > + drm_plane_create_color_properties(&plane->base, > > + BIT(DRM_COLOR_YCBCR_BT601) | > > + BIT(DRM_COLOR_YCBCR_BT709) | > > + BIT(DRM_COLOR_YCBCR_BT2020), > > + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | > > + BIT(DRM_COLOR_YCBCR_FULL_RANGE), > > + DRM_COLOR_YCBCR_BT601, > > + DRM_COLOR_YCBCR_FULL_RANGE); > > + > > return plane; > > } > > > -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com