From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 4/4] x86/spec: do not print thunk option selection if not built-in
Date: Tue, 27 Feb 2024 12:20:55 +0100 [thread overview]
Message-ID: <Zd3Fl6nx-R4aq2wR@macbook> (raw)
In-Reply-To: <30e1bfea-d76b-4e3d-b148-f25d1c811f8d@suse.com>
On Mon, Feb 26, 2024 at 01:54:54PM +0100, Jan Beulich wrote:
> On 26.02.2024 12:07, Roger Pau Monne wrote:
> > Now that the thunk built-in enable is printed as part of the "Compiled-in
> > support:" line, avoid printing anything in "Xen settings:" if the thunk is
> > disabled at build time.
>
> Why "Now that ..."? It's other logging the earlier patch adds there.
'Now that ...' would refer to patch 1/4.
> > Note the BTI-Thunk option printing is also adjusted to print a colon in the
> > same way the other options on the line do.
> >
> > Requested-by: Jan Beulich <jbeulich@suse.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> With either a clarification of what's meant or e.g. s/Now that/Since/
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
'Since' is likely more appropriate.
Thanks, Roger.
next prev parent reply other threads:[~2024-02-27 11:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 11:07 [PATCH v3 0/4] x86/spec: improve command line parsing Roger Pau Monne
2024-02-26 11:07 ` [PATCH v3 1/4] x86/spec: print the built-in SPECULATIVE_HARDEN_* options Roger Pau Monne
2024-02-26 12:39 ` Jan Beulich
2024-02-27 11:13 ` Roger Pau Monné
2024-02-26 11:07 ` [PATCH v3 2/4] x86/spec: fix BRANCH_HARDEN option to only be set when build-enabled Roger Pau Monne
2024-02-26 12:42 ` Jan Beulich
2024-02-26 11:07 ` [PATCH v3 3/4] x86/spec: fix INDIRECT_THUNK " Roger Pau Monne
2024-02-26 12:50 ` Jan Beulich
2024-02-27 11:18 ` Roger Pau Monné
2024-02-26 11:07 ` [PATCH v3 4/4] x86/spec: do not print thunk option selection if not built-in Roger Pau Monne
2024-02-26 12:54 ` Jan Beulich
2024-02-27 11:20 ` Roger Pau Monné [this message]
2024-02-27 13:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd3Fl6nx-R4aq2wR@macbook \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.