From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] generic: check logical-sector sized O_DIRECT
Date: Wed, 28 Feb 2024 08:04:10 -0800 [thread overview]
Message-ID: <Zd9ZeiWiaxncmxk4@infradead.org> (raw)
In-Reply-To: <20240228155929.GD1927156@frogsfrogsfrogs>
On Wed, Feb 28, 2024 at 07:59:29AM -0800, Darrick J. Wong wrote:
> On Mon, Nov 07, 2022 at 12:56:18PM +0800, Zorro Lang wrote:
> > If the physical sector size is 4096, but the logical sector size
> > is 512, the 512b dio write/read should be allowed.
>
> Huh, did we all completely forget to review this patch?
Looks like it. The test also is a bit overzealous as for copy on
write file systems we can't do logical sector size aligned writes,
e.g. btrfs or always_cow xfs. So we'll need to find a way to
check for those cases.
next prev parent reply other threads:[~2024-02-28 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 4:56 [PATCH] generic: check logical-sector sized O_DIRECT Zorro Lang
2022-11-07 10:53 ` Andrey Albershteyn
2024-02-28 15:59 ` Darrick J. Wong
2024-02-28 16:04 ` Christoph Hellwig [this message]
2024-02-29 0:52 ` Zorro Lang
2024-02-29 1:41 ` Darrick J. Wong
2024-02-29 1:55 ` Zorro Lang
2024-02-29 11:39 ` Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd9ZeiWiaxncmxk4@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.