All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Jonathan Cameron" <jonathan.cameron@huawei.com>,
	"Fan Ni" <fan.ni@samsung.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	qemu-trivial@nongnu.org, "Zhao Liu" <zhao1.liu@intel.com>
Subject: Re: [PATCH v2 1/7] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config()
Date: Thu, 29 Feb 2024 00:09:34 +0800	[thread overview]
Message-ID: <Zd9avh8nPazzTSsN@intel.com> (raw)
In-Reply-To: <877cip3v24.fsf@pond.sub.org>

> No need to quote the dereferences in full.
> 
>   But in cxl_fixed_memory_window_config(), @errp is dereferenced in 2
>   places without ERRP_GUARD().
> 
>   In these two places, we check "*errp", because neither function
> 
> would do.
> 
> Same for the other commit messages.
> 
> Hardly worth a respin, though :)
> 

I over-understood your reply. I'll pay attention to that in the follow
up.

Thanks,
Zhao



  reply	other threads:[~2024-02-28 15:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23  8:56 [PATCH v2 0/7] Cleanup and fix @errp dereference Zhao Liu
2024-02-23  8:56 ` [PATCH v2 1/7] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config() Zhao Liu
2024-02-26 16:07   ` Jonathan Cameron
2024-02-26 16:07     ` Jonathan Cameron via
2024-02-28  7:30   ` Markus Armbruster
2024-02-28 16:09     ` Zhao Liu [this message]
2024-02-23  8:56 ` [PATCH v2 2/7] hw/display/macfb: Fix missing ERRP_GUARD() in macfb_nubus_realize() Zhao Liu
2024-02-23  8:56 ` [PATCH v2 3/7] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize() Zhao Liu
2024-02-26 16:07   ` Jonathan Cameron
2024-02-26 16:07     ` Jonathan Cameron via
2024-02-26 16:07     ` Jonathan Cameron via
2024-02-23  8:56 ` [PATCH v2 4/7] hw/misc/xlnx-versal-trng: Check returned bool in trng_prop_fault_event_set() Zhao Liu
2024-02-23 17:53   ` Philippe Mathieu-Daudé
2024-02-23  8:56 ` [PATCH v2 5/7] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize() Zhao Liu
2024-02-26 16:07   ` Jonathan Cameron
2024-02-26 16:07     ` Jonathan Cameron via
2024-02-26 16:07     ` Jonathan Cameron via
2024-03-12 10:39   ` Thomas Huth
2024-02-23  8:56 ` [PATCH v2 6/7] hw/vfio/iommufd: Fix missing ERRP_GUARD() in iommufd_cdev_getfd() Zhao Liu
2024-02-23  8:56 ` [PATCH v2 7/7] hw/intc: Check @errp to handle the error of IOAPICCommonClass.realize() Zhao Liu
2024-02-23 17:52   ` Philippe Mathieu-Daudé
2024-03-11  3:51 ` [PATCH v2 0/7] Cleanup and fix @errp dereference Zhao Liu
2024-03-12 16:43   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zd9avh8nPazzTSsN@intel.com \
    --to=zhao1.liu@linux.intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=armbru@redhat.com \
    --cc=clg@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=fan.ni@samsung.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=laurent@vivier.eu \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.