From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Christian Stewart <christian@aperture.us>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] build failure on Ubuntu 22.04 LTS: TIME_BITS=64 is allowed only with FILE_OFFSET_BITS=64
Date: Sat, 17 Feb 2024 18:46:27 +0100 [thread overview]
Message-ID: <ZdDw86IWya-Bjbn5@landeda> (raw)
In-Reply-To: <ZdCevcKap6z2nmqV@landeda>
Christian, All,
On 2024-02-17 12:55 +0100, Yann E. MORIN spake thusly:
[--SNIP--]
> The first, which is the easiest to fix, is that the call to cpp is
> piped into a call to sed. cpp fails, but because of the pipe, its exit
> status is lost. The sed succeeds, though, so the rule as a whole
> succeeds. Then the call to gcc fails, which is fortunate, or we'd have
> missed the previous failure of cpp. This is trivial to fix: use a temp
> file for the output of cpp, and run the sed with that temp file as
> input, as a separate command in the same rule:
>
> --- lib/util/Makefile.orig 2024-02-17 12:25:13.554448884 +0100
> +++ lib/util/Makefile 2024-02-17 12:26:20.727968989 +0100
> @@ -273,10 +273,12 @@
> fi
>
> mksiglist.h: $(srcdir)/sys_siglist.h
> - $(CPP) $(CPPFLAGS) $(srcdir)/sys_siglist.h | $(SED) -e '1,/^int sudo_end_of_headers;/d' -e '/^#/d' > mksiglist.h
> + $(CPP) $(CPPFLAGS) $(srcdir)/sys_siglist.h > mksiglist.h.tmp
> + $(SED) -e '1,/^int sudo_end_of_headers;/d' -e '/^#/d' < mksiglist.h.tmp > mksiglist.h
>
> mksigname.h: $(srcdir)/sys_signame.h
> - $(CPP) $(CPPFLAGS) $(srcdir)/sys_signame.h | $(SED) -e '1,/^int sudo_end_of_headers;/d' -e '/^#/d' > mksigname.h
> + $(CPP) $(CPPFLAGS) $(srcdir)/sys_signame.h > mksigname.h.tmp
> + $(SED) -e '1,/^int sudo_end_of_headers;/d' -e '/^#/d' < mksigname.h.tmp > mksigname.h
>
> closefrom_test: $(CLOSEFROM_TEST_OBJS) libsudo_util.la
> $(LIBTOOL) $(LTFLAGS) --mode=link $(CC) -o $@ $(CLOSEFROM_TEST_OBJS) libsudo_util.la $(ASAN_LDFLAGS) $(PIE_LDFLAGS) $(HARDENING_LDFLAGS) $(TEST_LDFLAGS) $(TEST_LIBS)
I've now sent a patch for that:
https://github.com/sudo-project/sudo/pull/360
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-17 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 9:32 [Buildroot] build failure on Ubuntu 22.04 LTS: TIME_BITS=64 is allowed only with FILE_OFFSET_BITS=64 Christian Stewart via buildroot
2024-02-17 10:28 ` Christian Stewart via buildroot
2024-02-17 11:55 ` Yann E. MORIN
2024-02-17 17:31 ` Yann E. MORIN
2024-02-17 17:46 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdDw86IWya-Bjbn5@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=christian@aperture.us \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.