From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7300AC48BF6 for ; Sun, 18 Feb 2024 20:13:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2BB2440727; Sun, 18 Feb 2024 20:13:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3N4tK1wRJDlG; Sun, 18 Feb 2024 20:13:05 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org ADFF74061F Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id ADFF74061F; Sun, 18 Feb 2024 20:13:05 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 6FA251BF488 for ; Sun, 18 Feb 2024 20:13:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5D7CE60675 for ; Sun, 18 Feb 2024 20:13:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xFVF02wP9gaJ for ; Sun, 18 Feb 2024 20:13:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=212.27.42.3; helo=smtp3-g21.free.fr; envelope-from=yann.morin.1998@free.fr; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 28B3A60639 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 28B3A60639 Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3]) by smtp3.osuosl.org (Postfix) with ESMTPS id 28B3A60639 for ; Sun, 18 Feb 2024 20:13:03 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8290:3800:e05a:3b8d:ff83:9629]) (Authenticated sender: yann.morin.1998@free.fr) by smtp3-g21.free.fr (Postfix) with ESMTPSA id C746813F86A; Sun, 18 Feb 2024 21:12:56 +0100 (CET) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sun, 18 Feb 2024 21:12:56 +0100 Date: Sun, 18 Feb 2024 21:12:56 +0100 From: "Yann E. MORIN" To: Giulio Benetti Message-ID: References: <20240218082012.3425825-1-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240218082012.3425825-1-giulio.benetti@benettiengineering.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1708287180; bh=nwV9oj6zpy+xB4H7HgdaaIjN32OsH6XFdYPTsZ8r4hA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NoFubjfHFfqQdZ+JPZJT91TR2SHef4jC++boySJHd7wbjQMSdiJ5wTXG+XG20Nrlx g+ZYR81pitRq4x1Z8i43Ta8N92/utgTICZevl0e9NE5O6LsJpyTMVe12co2IOevJlx kQNuoFP9fPoK9zROD2fTJo8JbY6c5BU7BcBdIagCWPwa6/0qDhndbbxf1fJNVdJ4k7 jq98YciulDHt2nB21lMj7Sa7Hva+OTmwuY7xELPM7I+Ni+Al4qoUKBoWE7Mt17j9RV ZgQ/9h/aBqZc8Ur3OvdkjEYbgb4g46r8/Bmks1cStIokknb0iMwTspZZYE5WH1VMVE dbYs2pFJhlZvw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=free.fr X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=NoFubjfH Subject: Re: [Buildroot] [PATCH v3] package/attr: fix build failure on Microblaze architecture X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" giulio, all, On 2024-02-18 09:20 +0100, Giulio Benetti spake thusly: > On Microblaze architecture __has_attribute(__symver__) support is broken > and always return true even if symver is not supported so let's add an > upstream patch to detect if symver is supported during autoreconf. Let's > also add ATTR_AUTORECONF = YES to let patch to affect building. > > Fixes: > http://autobuild.buildroot.org/results/29c76e02becedf922bd7dc0533338c078bf77d2a > > Signed-off-by: Giulio Benetti Applied to master, thanks. Regards, Yann E. MORIN. > --- > V1->V2: > * written commit log as suggested by Thomas(there was no commit log at all > since this patch has been pointed during Buildroot Dev Days in IRC to me) > * re-sent local patch to the correct maililng list and updated Upstream: > URL > V2->V3: > * since patch has been upstreamed after a little rework, use it and point > upstream commit URL > --- > ...dd-detection-of-symver-gcc-attribute.patch | 75 +++++++++++++++++++ > package/attr/attr.mk | 3 + > 2 files changed, 78 insertions(+) > create mode 100644 package/attr/0002-configure.ac-add-detection-of-symver-gcc-attribute.patch > > diff --git a/package/attr/0002-configure.ac-add-detection-of-symver-gcc-attribute.patch b/package/attr/0002-configure.ac-add-detection-of-symver-gcc-attribute.patch > new file mode 100644 > index 0000000000..ee029e9735 > --- /dev/null > +++ b/package/attr/0002-configure.ac-add-detection-of-symver-gcc-attribute.patch > @@ -0,0 +1,75 @@ > +From 365426c28f8bf73d34d77cc06b7d5ffeae17f13a Mon Sep 17 00:00:00 2001 > +From: Thomas Petazzoni > +Date: Tue, 6 Feb 2024 15:33:15 +0100 > +Subject: [PATCH] configure.ac: add detection of symver gcc attribute > + > +On non-ELF platforms, such as microblaze, builds will fail when trying > +to add symver information because __attribute__((symver ..)) is not > +supported even though __has_attribute(__symver__) returns true. > + > +Support for symver needs to be detected via a compile test since > +__has_attribute can report false positives [0]. > + > +Add a configure compile check for __attribute__((symver ..)) to ensure > +it is supported and define a variable to advertise support. > + > +[0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101766#c1 > + > +Upstream: https://git.savannah.nongnu.org/cgit/attr.git/commit/?id=943c776089dbb24ebbfb7432ba9841f1845bf95a > + > +Signed-off-by: Thomas Petazzoni > +[Giulio: rework local patch for #if nesting] > +Signed-off-by: Giulio Benetti > +--- > + configure.ac | 15 +++++++++++++++ > + libattr/syscalls.c | 8 ++++---- > + 2 files changed, 19 insertions(+), 4 deletions(-) > + > +diff --git a/configure.ac b/configure.ac > +index 7e362e9..98477b5 100644 > +--- a/configure.ac > ++++ b/configure.ac > +@@ -57,6 +57,21 @@ AS_CASE([$host_os], > + [linux*], [os_linux=yes]) > + AM_CONDITIONAL([OS_LINUX], [test "x$os_linux" = "xyes"]) > + > ++AC_CACHE_CHECK(whether __attribute__((__symver__())) is supported, > ++ gcc_cv_symver_attribute, > ++ [cat > conftest.c < ++void foo (void) {} > ++__typeof(foo) foo __attribute__ ((__symver__("foo@foo"))); > ++EOF > ++ gcc_cv_symver_attribute=no > ++ if ${CC-cc} -Werror -S conftest.c -o conftest.s >/dev/null 2>&1; then \ > ++ gcc_cv_symver_attribute=yes > ++ fi > ++ rm -f conftest.[cs] > ++]) > ++AS_IF([test $gcc_cv_symver_attribute = yes], > ++ [AC_DEFINE(HAVE_SYMVER_ATTRIBUTE, [], [GCC supports symver attribute])]) > ++ > + AC_CONFIG_COMMANDS([include/attr], > + [dnl > + rm -rf include/attr > +diff --git a/libattr/syscalls.c b/libattr/syscalls.c > +index 907560a..7ee6d39 100644 > +--- a/libattr/syscalls.c > ++++ b/libattr/syscalls.c > +@@ -31,10 +31,10 @@ > + * prefer symver attribute if available (since gcc 10), > + * fall back to traditional .symver asm directive otherwise. > + */ > +-#ifdef __has_attribute > +-# if __has_attribute(__symver__) > +-# define SYMVER(cn, vn) __typeof(cn) cn __attribute__((__symver__(vn))) > +-# elif __has_attribute(__no_reorder__) > ++#if defined(HAVE_SYMVER_ATTRIBUTE) > ++# define SYMVER(cn, vn) __typeof(cn) cn __attribute__((__symver__(vn))) > ++#elif defined(__has_attribute) > ++# if __has_attribute(__no_reorder__) > + /* > + * Avoid wrong partitioning with older gcc and LTO. May not work reliably > + * with all versions; use -flto-partition=none if you encounter problems. > +-- > +2.34.1 > + > diff --git a/package/attr/attr.mk b/package/attr/attr.mk > index d1397921ff..1d24144f46 100644 > --- a/package/attr/attr.mk > +++ b/package/attr/attr.mk > @@ -11,6 +11,9 @@ ATTR_LICENSE = GPL-2.0+ (programs), LGPL-2.1+ (libraries) > ATTR_LICENSE_FILES = doc/COPYING doc/COPYING.LGPL > ATTR_CPE_ID_VALID = YES > > +# Flag added for patch dealing with symver in configure.ac > +ATTR_AUTORECONF = YES > + > ATTR_INSTALL_STAGING = YES > > ATTR_CONF_OPTS = --disable-nls > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot