From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 757B4C48BF8 for ; Mon, 19 Feb 2024 19:54:42 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rc9ip-0000e5-RS; Mon, 19 Feb 2024 19:54:40 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rc9io-0000dz-Eo for linux-f2fs-devel@lists.sourceforge.net; Mon, 19 Feb 2024 19:54:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YPYlqKudaClcKbNFamdeE7+QrC6+8XojTMUekGJ9pw4=; b=FgTHqZJne5++pLiVwLTnnqFIg9 4KWyTWo91xsbfwV7t26bPbiSKfi3lyRNEMZP9UOukhJja7QNC4/SnllXRMI7SCJQul2CM1XDNbE2u ViSmXi69aHQMgNCGkurMuxE2Teedf0BHlP1CVXNJB/wY5IS2+4t+9EtmhGO++YLcuYqg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YPYlqKudaClcKbNFamdeE7+QrC6+8XojTMUekGJ9pw4=; b=kU8/CVDoDOEk4s0h/cmPw3lrY+ /EfCeG39j1ODXgjBvo5wS1ZH713kjUfzvwLtqNU2VKP3cl71YI1iio7bk+U+N+gTlPgjQwrnt1Jwv 7LGOC3dmwkf4hKlfkJfYlFHO+bkLj4sq5UeRiBHSxX7yxb2hQiKTBpdzb66Sy3KtTNJQ=; Received: from mail-ed1-f45.google.com ([209.85.208.45]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rc9il-0005uM-Ry for linux-f2fs-devel@lists.sourceforge.net; Mon, 19 Feb 2024 19:54:38 +0000 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-561587ce966so9570507a12.1 for ; Mon, 19 Feb 2024 11:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708372466; x=1708977266; darn=lists.sourceforge.net; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=YPYlqKudaClcKbNFamdeE7+QrC6+8XojTMUekGJ9pw4=; b=Cv4VAXppgHazob8GHnNNPqScul1ZDq3uEXLAVS8/WtkP+qKipdooIQEera5ZvzW0mt +CqF0xxootuoHD+DTM1N6mMEsd5qSxJypn7a3V7J9Kzpc3kGhw34Kh+c209X4w5+7j9C ZrILiSF7rQnAVRdsJQtx+Os8VMkWaVJsBp7Hm8cb8vkqMmoBjIIHDLI6z2q5sfg37qwm zL8uWF44kj7EUeAtUWktoroskdb0vhIqmWK0WNVRELnhUZIAqvQHqVwRopnkxIy1moLK FSpNlVXRdAxVU1xssJw6YfDG6Di9cnSL+fwTe5ogpbYZomQdSWPbj20Q93ojzq4CkDfl O5xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708372466; x=1708977266; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YPYlqKudaClcKbNFamdeE7+QrC6+8XojTMUekGJ9pw4=; b=knLR6lcuNC7mXEtvJusbGUie9taxe5rL037uTeeM2L5A831vAhYtzDQeuPidyLU9nY fQytL9owSvOMKu23nOm2kdXD+LGzojQZllYhXO/N88App9A23G9AWrTSNHsgKSrqehEo gZmISbRYGQMe8LATnnt6If4ZDRlHLXJDwgdnnrcnRr/M7IvZ/l6K1/Fvs7Kv98HYR0ni U5dJcKdRstjyB8lZ9xG72rSQgsvVYRIRI9r4RPp92OPVF19Cz3pb02nK9X4ASCVYmPf0 /I0kH4T7ZdAERgE22UcKQQt0X8Lq97v1IsTluKRhGi6sFmmNyo1Kw+SXDxtRAaGEbpGp YTVg== X-Forwarded-Encrypted: i=1; AJvYcCWzIxv2tIflYTS4HOSFdciVR6GrqrcxnI4R+h+nqC+9PsHo4xt2E9vkZCLMHbFrYc0xIdHMyR34Vl5ZVJ//9D4yFH4Ierga+XRG7tC/cLWSKyFa2nhVbA== X-Gm-Message-State: AOJu0Ywg+pDAkqPo0sTMDtsFlB/U4+EVj4t230TqHq/e0Ax7r1LDaRHe 3+jXU+J/8aEXer1mPGVSxJ8DBSmP8zthcbUK8tAFM8yhxvM0+fKN X-Google-Smtp-Source: AGHT+IGy17EHv3w5kRGCvBk4IxezGA5nNXlG3sjHaPpclSP5gUQDDuET4mul61ghYdEBQQf2Q15JQQ== X-Received: by 2002:a05:6402:5207:b0:564:4211:faa3 with SMTP id s7-20020a056402520700b005644211faa3mr5547391edd.1.1708372465382; Mon, 19 Feb 2024 11:54:25 -0800 (PST) Received: from eldamar.lan (c-82-192-242-114.customer.ggaweb.ch. [82.192.242.114]) by smtp.gmail.com with ESMTPSA id fi17-20020a056402551100b005612025465asm2964948edb.74.2024.02.19.11.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 11:54:24 -0800 (PST) Received: by eldamar.lan (Postfix, from userid 1000) id EF00EBE2EE8; Mon, 19 Feb 2024 20:54:23 +0100 (CET) Date: Mon, 19 Feb 2024 20:54:23 +0100 From: Salvatore Bonaccorso To: Chao Yu Message-ID: References: <170736382774.1975.1861975122613668970.reportbug@tsuga.picorealm.net> <6d14ea70-ac1c-46f2-af1d-ba34ea0165aa@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d14ea70-ac1c-46f2-af1d-ba34ea0165aa@kernel.org> X-Headers-End: 1rc9il-0005uM-Ry Subject: Re: [f2fs-dev] [regression 6.1.y] f2fs: invalid zstd compress level: 6 X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: regressions@lists.linux.dev, 1063422@bugs.debian.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Dhya , Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi, On Mon, Feb 19, 2024 at 10:35:13AM +0800, Chao Yu wrote: > On 2024/2/9 4:19, Salvatore Bonaccorso wrote: > > Hi Jaegeuk Kim, Chao Yu, > > > > In Debian the following regression was reported after a Dhya updated > > to 6.1.76: > > > > On Wed, Feb 07, 2024 at 10:43:47PM -0500, Dhya wrote: > > > Package: src:linux > > > Version: 6.1.76-1 > > > Severity: critical > > > Justification: breaks the whole system > > > > > > Dear Maintainer, > > > > > > After upgrade to linux-image-6.1.0-18-amd64 6.1.76-1 F2FS filesystem > > > fails to mount rw. Message in the boot journal: > > > > > > kernel: F2FS-fs (nvme0n1p6): invalid zstd compress level: 6 > > > > > > There was recently an f2fs patch to the 6.1 kernel tree which might be > > > related: https://www.spinics.net/lists/stable-commits/msg329957.html > > > > > > Was able to recover the system by doing: > > > > > > sudo mount -o remount,rw,relatime,lazytime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,extent_cache,mode=adaptive,active_logs=6,alloc_mode=default,checkpoint_merge,fsync_mode=posix,compress_algorithm=lz4,compress_log_size=2,compress_mode=fs,atgc,discard_unit=block,memory=normal /dev/nvme0n1p6 / > > > > > > under the running bad 6.1.0-18-amd64 kernel, then editing > > > /etc/default/grub: > > > > > > GRUB_DEFAULT="Advanced options for Debian GNU/Linux>Debian GNU/Linux, with Linux 6.1.0-17-amd64" > > > > > > and running 'update-grub' and rebooting to boot the 6.1.0-17-amd64 > > > kernel. > > > > The issue is easily reproducible by: > > > > # dd if=/dev/zero of=test.img count=100 bs=1M > > # mkfs.f2fs -f -O compression,extra_attr ./test.img > > # mount -t f2fs -o compress_algorithm=zstd:6,compress_chksum,atgc,gc_merge,lazytime ./test.img /mnt > > > > resulting in > > > > [ 60.789982] F2FS-fs (loop0): invalid zstd compress level: 6 > > Hi Salvatore, > > Can you please try below fixes: > > [PATCH 6.1] f2fs: add helper to check compression level > https://lore.kernel.org/linux-f2fs-devel/20240212160530.1017205-1-chao@kernel.org Confirmed that this fixes the reported issue as it was reported to us in Debian in https://bugs.debian.org/1063422 . Thanks a lot! (note just tested with the first commit as it landed in 6.1.78 to confirm the immediate regression). #regzbot fixed-by: cf3d57ad6ff8b566deba3544b9ad3384781fb604 Regards, Salvatore _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F38151016 for ; Mon, 19 Feb 2024 19:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708372469; cv=none; b=iQY7wumTle/romJ0UWDxIOylrBrnFbu6oclI/q+zyVyqPidNLzIYQY5jEU0TKwKvMkqdDz/19GQQBXy38FyabJtc7h1FIlhDpO6BCIsL5sMi0U75OTRJwSjvt1h3bxVBDjC3+SyD6hXKuKq3nRlwA+CvFrKlVOV7ydh5MiCSvpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708372469; c=relaxed/simple; bh=ahdS3Zn+QIu0uhv09EiJ8/j1ihnNP5swBR9x0i0/BHw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fa+mExaJt3VEbBwxO9VGDRr4AyLPHaWr8exYEAkHLBXZyZaQVuEDlG0i9EBb0/QTYE0yw76jtKLKV512Vu3HQIHIlFF/Ex9vxi9oltp2O2jZLNavkPpe3utmgO+8Bw8HERf3K4aNyE0AdI8YIBBnLRHT95KRaMraxkw503VoYCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kNX9LvPH; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kNX9LvPH" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-56454c695e6so2449675a12.0 for ; Mon, 19 Feb 2024 11:54:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708372466; x=1708977266; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=YPYlqKudaClcKbNFamdeE7+QrC6+8XojTMUekGJ9pw4=; b=kNX9LvPHYtFMx5JBbZ3li68QEAd4ncMXT6UgpsKbWNqmE0+IV4+Mm238CPRNm2CrbB MfvmCFLp7TCSBkOx4tIVVnERhgqVgF4lOzWMD7SxI+zmlbqI4Jtp1NBiL/Jue5FunVF2 q1FqP/oD0u7m3oTOfrx2wYhKnknEIBjcViWNrR+r0xpM8abQeTx6sQlbv0EN6oVsUNgU Ku5P6pgaq4uqipqg73FcVv5oB+lggEb0pXIWvRVrmrs/AKc36FqnNoh83UrE+sbaSWS/ zfTdUHj6qj63SkMHTNHKd26+2MufvyD76Ft6Db+T+uxJstPg/RMjePNK8K9O4eFKd5yr OtCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708372466; x=1708977266; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YPYlqKudaClcKbNFamdeE7+QrC6+8XojTMUekGJ9pw4=; b=ZYhpxwkQrdUE3fSpS/G9CvNiY0MPLCzCbHcG46d+w7juDDhv96N5LNaBiEAaHyJil4 wYIiRjC426LAXlgfUcfqdqgZ411x6/v50ZG9Hoj/+un9+d2U2LFkrJXZGubnHnA6NGh/ BOn7YHHVEtXcwL5lYFbp2WWmuiM4mbozdskiys1Kbaj/XSldAZzB/ynqzu3R41QCiknf HE5dh5pEoXVfr7PdpcQQU7l/GpZbCJXacgiagnItADnjtvRIJjOjy2RWtFov91H6uO4u dqQtGicfibdFXuM3xT1IggB1CEdZdVW3SaulqTlBLD/RzzcVuqaKGD+jjQl7fyzXHwz+ oy0w== X-Forwarded-Encrypted: i=1; AJvYcCVCvzMEpmQp7yf1VRsZiz+j/aP1wD+DIRraCdMaaZr3Rwty5AbPtkQ0p+P3Hc7UUD34FGje6x1DCXHaQPn4adzFY8VNRepq74/rqwQ= X-Gm-Message-State: AOJu0Yyv1+69ltSn8cb1OiIEb9PstPJ6i/rY7CHAjmYAxArvgzrlT34z iNIFawqQDLkrtvah6s81sPfqSSP3Y/sz/K6nQoMF2ye/n2RY9t0n X-Google-Smtp-Source: AGHT+IGy17EHv3w5kRGCvBk4IxezGA5nNXlG3sjHaPpclSP5gUQDDuET4mul61ghYdEBQQf2Q15JQQ== X-Received: by 2002:a05:6402:5207:b0:564:4211:faa3 with SMTP id s7-20020a056402520700b005644211faa3mr5547391edd.1.1708372465382; Mon, 19 Feb 2024 11:54:25 -0800 (PST) Received: from eldamar.lan (c-82-192-242-114.customer.ggaweb.ch. [82.192.242.114]) by smtp.gmail.com with ESMTPSA id fi17-20020a056402551100b005612025465asm2964948edb.74.2024.02.19.11.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 11:54:24 -0800 (PST) Sender: Salvatore Bonaccorso Received: by eldamar.lan (Postfix, from userid 1000) id EF00EBE2EE8; Mon, 19 Feb 2024 20:54:23 +0100 (CET) Date: Mon, 19 Feb 2024 20:54:23 +0100 From: Salvatore Bonaccorso To: Chao Yu Cc: Dhya , 1063422@bugs.debian.org, Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [regression 6.1.y] f2fs: invalid zstd compress level: 6 Message-ID: References: <170736382774.1975.1861975122613668970.reportbug@tsuga.picorealm.net> <6d14ea70-ac1c-46f2-af1d-ba34ea0165aa@kernel.org> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d14ea70-ac1c-46f2-af1d-ba34ea0165aa@kernel.org> Hi, On Mon, Feb 19, 2024 at 10:35:13AM +0800, Chao Yu wrote: > On 2024/2/9 4:19, Salvatore Bonaccorso wrote: > > Hi Jaegeuk Kim, Chao Yu, > > > > In Debian the following regression was reported after a Dhya updated > > to 6.1.76: > > > > On Wed, Feb 07, 2024 at 10:43:47PM -0500, Dhya wrote: > > > Package: src:linux > > > Version: 6.1.76-1 > > > Severity: critical > > > Justification: breaks the whole system > > > > > > Dear Maintainer, > > > > > > After upgrade to linux-image-6.1.0-18-amd64 6.1.76-1 F2FS filesystem > > > fails to mount rw. Message in the boot journal: > > > > > > kernel: F2FS-fs (nvme0n1p6): invalid zstd compress level: 6 > > > > > > There was recently an f2fs patch to the 6.1 kernel tree which might be > > > related: https://www.spinics.net/lists/stable-commits/msg329957.html > > > > > > Was able to recover the system by doing: > > > > > > sudo mount -o remount,rw,relatime,lazytime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,extent_cache,mode=adaptive,active_logs=6,alloc_mode=default,checkpoint_merge,fsync_mode=posix,compress_algorithm=lz4,compress_log_size=2,compress_mode=fs,atgc,discard_unit=block,memory=normal /dev/nvme0n1p6 / > > > > > > under the running bad 6.1.0-18-amd64 kernel, then editing > > > /etc/default/grub: > > > > > > GRUB_DEFAULT="Advanced options for Debian GNU/Linux>Debian GNU/Linux, with Linux 6.1.0-17-amd64" > > > > > > and running 'update-grub' and rebooting to boot the 6.1.0-17-amd64 > > > kernel. > > > > The issue is easily reproducible by: > > > > # dd if=/dev/zero of=test.img count=100 bs=1M > > # mkfs.f2fs -f -O compression,extra_attr ./test.img > > # mount -t f2fs -o compress_algorithm=zstd:6,compress_chksum,atgc,gc_merge,lazytime ./test.img /mnt > > > > resulting in > > > > [ 60.789982] F2FS-fs (loop0): invalid zstd compress level: 6 > > Hi Salvatore, > > Can you please try below fixes: > > [PATCH 6.1] f2fs: add helper to check compression level > https://lore.kernel.org/linux-f2fs-devel/20240212160530.1017205-1-chao@kernel.org Confirmed that this fixes the reported issue as it was reported to us in Debian in https://bugs.debian.org/1063422 . Thanks a lot! (note just tested with the first commit as it landed in 6.1.78 to confirm the immediate regression). #regzbot fixed-by: cf3d57ad6ff8b566deba3544b9ad3384781fb604 Regards, Salvatore