From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D041657DF for ; Tue, 20 Feb 2024 11:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708428468; cv=none; b=BIJZ13ILlv0igwuBB5T4V9vAd1tzuyxl/+0coRJOPMgE5FipkTXEXd/uv3RWh99KcolCiVBHitxhOpvnBDaz+myJcrrI2wbJQfF5IoLh7yeKlOFA/tBAE+CrQ2w3XZQXb6ZcbLUEi+6o4qqtePGrvU9lYgIkSJgVJ2YYrwrwGlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708428468; c=relaxed/simple; bh=Mipp2WNrLFK4BBvNJ8I27aEf24TMVYEu5ip2QcqVhxI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B/Oe59fMphj1MOTBbhlUmw49J/7OxcKL10QTFLLafUjIoO1AMi6+wLZ1Gq5wZs/9zDgf4Zp62Y+8B2J09hSTJ/wET/szOW7TqzFTAkHXsgCKXj3otYDSjwJbDyKKkXPsXUP/rxWz97GqLLThEPuck49fZ9Ec+HR087pWFsdLYRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=O6lRSVZh; arc=none smtp.client-ip=140.211.166.137 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="O6lRSVZh" Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A789B403EC for ; Tue, 20 Feb 2024 11:27:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -2.098 X-Spam-Level: Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ME0znmebxzhY for ; Tue, 20 Feb 2024 11:27:45 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2001:4d48:ad52:32c8:5054:ff:fe00:142; helo=pandora.armlinux.org.uk; envelope-from=linux+acpica-devel=lists.linuxfoundation.org@armlinux.org.uk; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9A46940670 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9A46940670 Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.a=rsa-sha256 header.s=pandora-2019 header.b=O6lRSVZh Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9A46940670 for ; Tue, 20 Feb 2024 11:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YAbiUOeHNTOOtMQq3T2dYQUt8NBgKEvDfS/NrGbV6TI=; b=O6lRSVZhxbh5i6u+BH25w3f3Cm 1Vw7wxiDSgvtyuvUnEQCtl4LHsD0HzY1J+QnwBBfWvzYrZnw4ZdEKbmD4OvhU0znyUN2QW3v3TQK6 acFANS/gPds8L+eRUinfOfYI/5P5/HHW8+MaTKOwBEFBIXcdD2h/rAjy4+NEGoLQ4VhzrvLbGSILa e4bVQ4JEXiZ5ggyFjiYKM2SMFHyueGtUiByprCY7LB4A0i9T5NoqAM9yDfSyA8mANNn7sjoowzKXf gZg39Bgc4AYxKTEmwc/LOvXE0VrkkOYgYtUo08k1FAqXJPZDFh0Fdt9VSeb+Bh6zHM/C3MKPJvsVF UW/+AtXw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54660) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rcOHQ-0002Id-2W; Tue, 20 Feb 2024 11:27:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rcOHM-0000pR-05; Tue, 20 Feb 2024 11:27:16 +0000 Date: Tue, 20 Feb 2024 11:27:15 +0000 From: "Russell King (Oracle)" To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, acpica-devel@lists.linuxfoundation.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Jonathan Cameron Subject: Re: [PATCH RFC v4 02/15] ACPI: processor: Register all CPUs from acpi_processor_get_info() Message-ID: References: Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) On Thu, Feb 15, 2024 at 08:22:29PM +0100, Rafael J. Wysocki wrote: > On Wed, Jan 31, 2024 at 5:50 PM Russell King wrote: > > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c > > index cf7c1cca69dd..a68c475cdea5 100644 > > --- a/drivers/acpi/acpi_processor.c > > +++ b/drivers/acpi/acpi_processor.c > > @@ -314,6 +314,18 @@ static int acpi_processor_get_info(struct acpi_device *device) > > cpufreq_add_device("acpi-cpufreq"); > > } > > > > + /* > > + * Register CPUs that are present. get_cpu_device() is used to skip > > + * duplicate CPU descriptions from firmware. > > + */ > > + if (!invalid_logical_cpuid(pr->id) && cpu_present(pr->id) && > > + !get_cpu_device(pr->id)) { > > + int ret = arch_register_cpu(pr->id); > > + > > + if (ret) > > + return ret; > > + } > > + > > /* > > * Extra Processor objects may be enumerated on MP systems with > > * less than the max # of CPUs. They should be ignored _iff > > This is interesting, because right below there is the following code: > > if (invalid_logical_cpuid(pr->id) || !cpu_present(pr->id)) { > int ret = acpi_processor_hotadd_init(pr); > > if (ret) > return ret; > } > > and acpi_processor_hotadd_init() essentially calls arch_register_cpu() > with some extra things around it (more about that below). > > I do realize that acpi_processor_hotadd_init() is defined under > CONFIG_ACPI_HOTPLUG_CPU, so for the sake of the argument let's > consider an architecture where CONFIG_ACPI_HOTPLUG_CPU is set. > > So why are the two conditionals that almost contradict each other both > needed? It looks like the new code could be combined with > acpi_processor_hotadd_init() to do the right thing in all cases. > > Now, acpi_processor_hotadd_init() does some extra things that look > like they should be done by the new code too. > > 1. It checks invalid_phys_cpuid() which appears to be a good idea to me. > > 2. It uses locking around arch_register_cpu() which doesn't seem > unreasonable either. > > 3. It calls acpi_map_cpu() and I'm not sure why this is not done by > the new code. > > The only thing that can be dropped from it is the _STA check AFAICS, > because acpi_processor_add() won't even be called if the CPU is not > present (and not enabled after the first patch). > > So why does the code not do 1 - 3 above? Honestly, I'm out of my depth with this and can't answer your questions - and I really don't want to try fiddling with this code because it's just too icky (even in its current form in mainline) to be understandable to anyone who hasn't gained a detailed knowledge of this code. It's going to require a lot of analysis - how acpi_map_cpuid() behaves in all circumstances, what this means for invalid_logical_cpuid() and invalid_phys_cpuid(), what paths will be taken in each case. This code is already just too hairy for someone who isn't an experienced ACPI hacker to be able to follow and I don't see an obvious way to make it more readable. James' additions make it even more complex and less readable. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 812A1C48BC4 for ; Tue, 20 Feb 2024 11:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VIkecCwmHuH+ypTV+zcYsgBSuiKJxNerZMa1lmyk6Yw=; b=fWe1O2OCWwZgkx rKFy79JxQAEvoN2yJS1Fda63iptI8vVixCGlYjqhciTJm3lTu3eKG2IVbsT9/1fQOm9PmR8x7V7C1 /RpzHdZtxhPRnQwI1iBvrKJXVQ5LQGQa2Q6WzVaEEiw/I/FPACm8R/ps+IpJ7kQTIvu09Dkcl++zr UWKe87RsFK2Tr8Otqx9PCQzBQvkN3igHnVdfZhtuxjDV4nIEM75G25oQWEzk8V/2cYHbE/0iA90sk UwA3/75kTmMU7nyDZ2lTzGQ9zaGaKS7vA8xdLOtYd6xH1tL+xOd3mgKnBNUlQrNkk0LA9ai4jfgrR Fh7Y95xFvI/nlK9n7scA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcOJg-0000000ESbo-0Fzp; Tue, 20 Feb 2024 11:29:40 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcOJc-0000000ES4E-40b8; Tue, 20 Feb 2024 11:29:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YAbiUOeHNTOOtMQq3T2dYQUt8NBgKEvDfS/NrGbV6TI=; b=O6lRSVZhxbh5i6u+BH25w3f3Cm 1Vw7wxiDSgvtyuvUnEQCtl4LHsD0HzY1J+QnwBBfWvzYrZnw4ZdEKbmD4OvhU0znyUN2QW3v3TQK6 acFANS/gPds8L+eRUinfOfYI/5P5/HHW8+MaTKOwBEFBIXcdD2h/rAjy4+NEGoLQ4VhzrvLbGSILa e4bVQ4JEXiZ5ggyFjiYKM2SMFHyueGtUiByprCY7LB4A0i9T5NoqAM9yDfSyA8mANNn7sjoowzKXf gZg39Bgc4AYxKTEmwc/LOvXE0VrkkOYgYtUo08k1FAqXJPZDFh0Fdt9VSeb+Bh6zHM/C3MKPJvsVF UW/+AtXw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54660) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rcOHQ-0002Id-2W; Tue, 20 Feb 2024 11:27:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rcOHM-0000pR-05; Tue, 20 Feb 2024 11:27:16 +0000 Date: Tue, 20 Feb 2024 11:27:15 +0000 From: "Russell King (Oracle)" To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, acpica-devel@lists.linuxfoundation.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Jonathan Cameron Subject: Re: [PATCH RFC v4 02/15] ACPI: processor: Register all CPUs from acpi_processor_get_info() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_032937_011079_84A72BBE X-CRM114-Status: GOOD ( 33.17 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMTUsIDIwMjQgYXQgMDg6MjI6MjlQTSArMDEwMCwgUmFmYWVsIEouIFd5c29j a2kgd3JvdGU6Cj4gT24gV2VkLCBKYW4gMzEsIDIwMjQgYXQgNTo1MOKAr1BNIFJ1c3NlbGwgS2lu ZyA8cm1rK2tlcm5lbEBhcm1saW51eC5vcmcudWs+IHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvYWNwaS9hY3BpX3Byb2Nlc3Nvci5jIGIvZHJpdmVycy9hY3BpL2FjcGlfcHJvY2Vzc29y LmMKPiA+IGluZGV4IGNmN2MxY2NhNjlkZC4uYTY4YzQ3NWNkZWE1IDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9hY3BpL2FjcGlfcHJvY2Vzc29yLmMKPiA+ICsrKyBiL2RyaXZlcnMvYWNwaS9hY3Bp X3Byb2Nlc3Nvci5jCj4gPiBAQCAtMzE0LDYgKzMxNCwxOCBAQCBzdGF0aWMgaW50IGFjcGlfcHJv Y2Vzc29yX2dldF9pbmZvKHN0cnVjdCBhY3BpX2RldmljZSAqZGV2aWNlKQo+ID4gICAgICAgICAg ICAgICAgICAgICAgICAgY3B1ZnJlcV9hZGRfZGV2aWNlKCJhY3BpLWNwdWZyZXEiKTsKPiA+ICAg ICAgICAgfQo+ID4KPiA+ICsgICAgICAgLyoKPiA+ICsgICAgICAgICogUmVnaXN0ZXIgQ1BVcyB0 aGF0IGFyZSBwcmVzZW50LiBnZXRfY3B1X2RldmljZSgpIGlzIHVzZWQgdG8gc2tpcAo+ID4gKyAg ICAgICAgKiBkdXBsaWNhdGUgQ1BVIGRlc2NyaXB0aW9ucyBmcm9tIGZpcm13YXJlLgo+ID4gKyAg ICAgICAgKi8KPiA+ICsgICAgICAgaWYgKCFpbnZhbGlkX2xvZ2ljYWxfY3B1aWQocHItPmlkKSAm JiBjcHVfcHJlc2VudChwci0+aWQpICYmCj4gPiArICAgICAgICAgICAhZ2V0X2NwdV9kZXZpY2Uo cHItPmlkKSkgewo+ID4gKyAgICAgICAgICAgICAgIGludCByZXQgPSBhcmNoX3JlZ2lzdGVyX2Nw dShwci0+aWQpOwo+ID4gKwo+ID4gKyAgICAgICAgICAgICAgIGlmIChyZXQpCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+ID4gKyAgICAgICB9Cj4gPiArCj4gPiAgICAg ICAgIC8qCj4gPiAgICAgICAgICAqICBFeHRyYSBQcm9jZXNzb3Igb2JqZWN0cyBtYXkgYmUgZW51 bWVyYXRlZCBvbiBNUCBzeXN0ZW1zIHdpdGgKPiA+ICAgICAgICAgICogIGxlc3MgdGhhbiB0aGUg bWF4ICMgb2YgQ1BVcy4gVGhleSBzaG91bGQgYmUgaWdub3JlZCBfaWZmCj4gCj4gVGhpcyBpcyBp bnRlcmVzdGluZywgYmVjYXVzZSByaWdodCBiZWxvdyB0aGVyZSBpcyB0aGUgZm9sbG93aW5nIGNv ZGU6Cj4gCj4gICAgIGlmIChpbnZhbGlkX2xvZ2ljYWxfY3B1aWQocHItPmlkKSB8fCAhY3B1X3By ZXNlbnQocHItPmlkKSkgewo+ICAgICAgICAgaW50IHJldCA9IGFjcGlfcHJvY2Vzc29yX2hvdGFk ZF9pbml0KHByKTsKPiAKPiAgICAgICAgIGlmIChyZXQpCj4gICAgICAgICAgICAgcmV0dXJuIHJl dDsKPiAgICAgfQo+IAo+IGFuZCBhY3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdCgpIGVzc2VudGlh bGx5IGNhbGxzIGFyY2hfcmVnaXN0ZXJfY3B1KCkKPiB3aXRoIHNvbWUgZXh0cmEgdGhpbmdzIGFy b3VuZCBpdCAobW9yZSBhYm91dCB0aGF0IGJlbG93KS4KPiAKPiBJIGRvIHJlYWxpemUgdGhhdCBh Y3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdCgpIGlzIGRlZmluZWQgdW5kZXIKPiBDT05GSUdfQUNQ SV9IT1RQTFVHX0NQVSwgc28gZm9yIHRoZSBzYWtlIG9mIHRoZSBhcmd1bWVudCBsZXQncwo+IGNv bnNpZGVyIGFuIGFyY2hpdGVjdHVyZSB3aGVyZSBDT05GSUdfQUNQSV9IT1RQTFVHX0NQVSBpcyBz ZXQuCj4gCj4gU28gd2h5IGFyZSB0aGUgdHdvIGNvbmRpdGlvbmFscyB0aGF0IGFsbW9zdCBjb250 cmFkaWN0IGVhY2ggb3RoZXIgYm90aAo+IG5lZWRlZD8gIEl0IGxvb2tzIGxpa2UgdGhlIG5ldyBj b2RlIGNvdWxkIGJlIGNvbWJpbmVkIHdpdGgKPiBhY3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdCgp IHRvIGRvIHRoZSByaWdodCB0aGluZyBpbiBhbGwgY2FzZXMuCj4gCj4gTm93LCBhY3BpX3Byb2Nl c3Nvcl9ob3RhZGRfaW5pdCgpIGRvZXMgc29tZSBleHRyYSB0aGluZ3MgdGhhdCBsb29rCj4gbGlr ZSB0aGV5IHNob3VsZCBiZSBkb25lIGJ5IHRoZSBuZXcgY29kZSB0b28uCj4gCj4gMS4gSXQgY2hl Y2tzIGludmFsaWRfcGh5c19jcHVpZCgpIHdoaWNoIGFwcGVhcnMgdG8gYmUgYSBnb29kIGlkZWEg dG8gbWUuCj4gCj4gMi4gSXQgdXNlcyBsb2NraW5nIGFyb3VuZCBhcmNoX3JlZ2lzdGVyX2NwdSgp IHdoaWNoIGRvZXNuJ3Qgc2VlbQo+IHVucmVhc29uYWJsZSBlaXRoZXIuCj4gCj4gMy4gSXQgY2Fs bHMgYWNwaV9tYXBfY3B1KCkgYW5kIEknbSBub3Qgc3VyZSB3aHkgdGhpcyBpcyBub3QgZG9uZSBi eQo+IHRoZSBuZXcgY29kZS4KPiAKPiBUaGUgb25seSB0aGluZyB0aGF0IGNhbiBiZSBkcm9wcGVk IGZyb20gaXQgaXMgdGhlIF9TVEEgY2hlY2sgQUZBSUNTLAo+IGJlY2F1c2UgYWNwaV9wcm9jZXNz b3JfYWRkKCkgd29uJ3QgZXZlbiBiZSBjYWxsZWQgaWYgdGhlIENQVSBpcyBub3QKPiBwcmVzZW50 IChhbmQgbm90IGVuYWJsZWQgYWZ0ZXIgdGhlIGZpcnN0IHBhdGNoKS4KPiAKPiBTbyB3aHkgZG9l cyB0aGUgY29kZSBub3QgZG8gMSAtIDMgYWJvdmU/CgpIb25lc3RseSwgSSdtIG91dCBvZiBteSBk ZXB0aCB3aXRoIHRoaXMgYW5kIGNhbid0IGFuc3dlciB5b3VyCnF1ZXN0aW9ucyAtIGFuZCBJIHJl YWxseSBkb24ndCB3YW50IHRvIHRyeSBmaWRkbGluZyB3aXRoIHRoaXMgY29kZQpiZWNhdXNlIGl0 J3MganVzdCB0b28gaWNreSAoZXZlbiBpbiBpdHMgY3VycmVudCBmb3JtIGluIG1haW5saW5lKQp0 byBiZSB1bmRlcnN0YW5kYWJsZSB0byBhbnlvbmUgd2hvIGhhc24ndCBnYWluZWQgYSBkZXRhaWxl ZCBrbm93bGVkZ2UKb2YgdGhpcyBjb2RlLgoKSXQncyBnb2luZyB0byByZXF1aXJlIGEgbG90IG9m IGFuYWx5c2lzIC0gaG93IGFjcGlfbWFwX2NwdWlkKCkgYmVoYXZlcwppbiBhbGwgY2lyY3Vtc3Rh bmNlcywgd2hhdCB0aGlzIG1lYW5zIGZvciBpbnZhbGlkX2xvZ2ljYWxfY3B1aWQoKSBhbmQKaW52 YWxpZF9waHlzX2NwdWlkKCksIHdoYXQgcGF0aHMgd2lsbCBiZSB0YWtlbiBpbiBlYWNoIGNhc2Uu IFRoaXMgY29kZQppcyBhbHJlYWR5IGp1c3QgdG9vIGhhaXJ5IGZvciBzb21lb25lIHdobyBpc24n dCBhbiBleHBlcmllbmNlZCBBQ1BJCmhhY2tlciB0byBiZSBhYmxlIHRvIGZvbGxvdyBhbmQgSSBk b24ndCBzZWUgYW4gb2J2aW91cyB3YXkgdG8gbWFrZSBpdAptb3JlIHJlYWRhYmxlLgoKSmFtZXMn IGFkZGl0aW9ucyBtYWtlIGl0IGV2ZW4gbW9yZSBjb21wbGV4IGFuZCBsZXNzIHJlYWRhYmxlLgoK LS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVs b3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUhIDgwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50 IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 947C7C48BC4 for ; Tue, 20 Feb 2024 11:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QAT37mxzSMgHutvEwxD1RoIugNxlu5hRSWyeCNRlZeI=; b=tMjnsIGIHIbB07 WuNZK+MBgaklCf8lxtXWsziERUCzICK4vw/37HXf7nZM6cdXlBlSJdz8aDisIPQMt0NGeiZ7kJxsN QyQsNfScuZxYxPCtiszHeX3B1UFluffQPg4dKLqJOLpcxVjuivXFi51T1qz/7ldto3uDeybueje71 ysIl4iU9LX7KDvf0oHhi8rd/ctJU/XkIr3no9EtJKS0/Bz+EB+qokEyZ8SUDp8emPPzK9x/tKjc6T f6aKHp/OaHKjxF7pajzpPYrUKnboHRQqWrKA9Z6OlxaeNTcy9fsYEnlFAGWvUG+pLzP4G/CYtSJFt BbRsEZzDhspoNgi1a8JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcOJf-0000000ESbY-21kh; Tue, 20 Feb 2024 11:29:39 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcOJc-0000000ES4E-40b8; Tue, 20 Feb 2024 11:29:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YAbiUOeHNTOOtMQq3T2dYQUt8NBgKEvDfS/NrGbV6TI=; b=O6lRSVZhxbh5i6u+BH25w3f3Cm 1Vw7wxiDSgvtyuvUnEQCtl4LHsD0HzY1J+QnwBBfWvzYrZnw4ZdEKbmD4OvhU0znyUN2QW3v3TQK6 acFANS/gPds8L+eRUinfOfYI/5P5/HHW8+MaTKOwBEFBIXcdD2h/rAjy4+NEGoLQ4VhzrvLbGSILa e4bVQ4JEXiZ5ggyFjiYKM2SMFHyueGtUiByprCY7LB4A0i9T5NoqAM9yDfSyA8mANNn7sjoowzKXf gZg39Bgc4AYxKTEmwc/LOvXE0VrkkOYgYtUo08k1FAqXJPZDFh0Fdt9VSeb+Bh6zHM/C3MKPJvsVF UW/+AtXw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54660) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rcOHQ-0002Id-2W; Tue, 20 Feb 2024 11:27:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rcOHM-0000pR-05; Tue, 20 Feb 2024 11:27:16 +0000 Date: Tue, 20 Feb 2024 11:27:15 +0000 From: "Russell King (Oracle)" To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, acpica-devel@lists.linuxfoundation.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Jonathan Cameron Subject: Re: [PATCH RFC v4 02/15] ACPI: processor: Register all CPUs from acpi_processor_get_info() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_032937_011079_84A72BBE X-CRM114-Status: GOOD ( 33.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMTUsIDIwMjQgYXQgMDg6MjI6MjlQTSArMDEwMCwgUmFmYWVsIEouIFd5c29j a2kgd3JvdGU6Cj4gT24gV2VkLCBKYW4gMzEsIDIwMjQgYXQgNTo1MOKAr1BNIFJ1c3NlbGwgS2lu ZyA8cm1rK2tlcm5lbEBhcm1saW51eC5vcmcudWs+IHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvYWNwaS9hY3BpX3Byb2Nlc3Nvci5jIGIvZHJpdmVycy9hY3BpL2FjcGlfcHJvY2Vzc29y LmMKPiA+IGluZGV4IGNmN2MxY2NhNjlkZC4uYTY4YzQ3NWNkZWE1IDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9hY3BpL2FjcGlfcHJvY2Vzc29yLmMKPiA+ICsrKyBiL2RyaXZlcnMvYWNwaS9hY3Bp X3Byb2Nlc3Nvci5jCj4gPiBAQCAtMzE0LDYgKzMxNCwxOCBAQCBzdGF0aWMgaW50IGFjcGlfcHJv Y2Vzc29yX2dldF9pbmZvKHN0cnVjdCBhY3BpX2RldmljZSAqZGV2aWNlKQo+ID4gICAgICAgICAg ICAgICAgICAgICAgICAgY3B1ZnJlcV9hZGRfZGV2aWNlKCJhY3BpLWNwdWZyZXEiKTsKPiA+ICAg ICAgICAgfQo+ID4KPiA+ICsgICAgICAgLyoKPiA+ICsgICAgICAgICogUmVnaXN0ZXIgQ1BVcyB0 aGF0IGFyZSBwcmVzZW50LiBnZXRfY3B1X2RldmljZSgpIGlzIHVzZWQgdG8gc2tpcAo+ID4gKyAg ICAgICAgKiBkdXBsaWNhdGUgQ1BVIGRlc2NyaXB0aW9ucyBmcm9tIGZpcm13YXJlLgo+ID4gKyAg ICAgICAgKi8KPiA+ICsgICAgICAgaWYgKCFpbnZhbGlkX2xvZ2ljYWxfY3B1aWQocHItPmlkKSAm JiBjcHVfcHJlc2VudChwci0+aWQpICYmCj4gPiArICAgICAgICAgICAhZ2V0X2NwdV9kZXZpY2Uo cHItPmlkKSkgewo+ID4gKyAgICAgICAgICAgICAgIGludCByZXQgPSBhcmNoX3JlZ2lzdGVyX2Nw dShwci0+aWQpOwo+ID4gKwo+ID4gKyAgICAgICAgICAgICAgIGlmIChyZXQpCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+ID4gKyAgICAgICB9Cj4gPiArCj4gPiAgICAg ICAgIC8qCj4gPiAgICAgICAgICAqICBFeHRyYSBQcm9jZXNzb3Igb2JqZWN0cyBtYXkgYmUgZW51 bWVyYXRlZCBvbiBNUCBzeXN0ZW1zIHdpdGgKPiA+ICAgICAgICAgICogIGxlc3MgdGhhbiB0aGUg bWF4ICMgb2YgQ1BVcy4gVGhleSBzaG91bGQgYmUgaWdub3JlZCBfaWZmCj4gCj4gVGhpcyBpcyBp bnRlcmVzdGluZywgYmVjYXVzZSByaWdodCBiZWxvdyB0aGVyZSBpcyB0aGUgZm9sbG93aW5nIGNv ZGU6Cj4gCj4gICAgIGlmIChpbnZhbGlkX2xvZ2ljYWxfY3B1aWQocHItPmlkKSB8fCAhY3B1X3By ZXNlbnQocHItPmlkKSkgewo+ICAgICAgICAgaW50IHJldCA9IGFjcGlfcHJvY2Vzc29yX2hvdGFk ZF9pbml0KHByKTsKPiAKPiAgICAgICAgIGlmIChyZXQpCj4gICAgICAgICAgICAgcmV0dXJuIHJl dDsKPiAgICAgfQo+IAo+IGFuZCBhY3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdCgpIGVzc2VudGlh bGx5IGNhbGxzIGFyY2hfcmVnaXN0ZXJfY3B1KCkKPiB3aXRoIHNvbWUgZXh0cmEgdGhpbmdzIGFy b3VuZCBpdCAobW9yZSBhYm91dCB0aGF0IGJlbG93KS4KPiAKPiBJIGRvIHJlYWxpemUgdGhhdCBh Y3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdCgpIGlzIGRlZmluZWQgdW5kZXIKPiBDT05GSUdfQUNQ SV9IT1RQTFVHX0NQVSwgc28gZm9yIHRoZSBzYWtlIG9mIHRoZSBhcmd1bWVudCBsZXQncwo+IGNv bnNpZGVyIGFuIGFyY2hpdGVjdHVyZSB3aGVyZSBDT05GSUdfQUNQSV9IT1RQTFVHX0NQVSBpcyBz ZXQuCj4gCj4gU28gd2h5IGFyZSB0aGUgdHdvIGNvbmRpdGlvbmFscyB0aGF0IGFsbW9zdCBjb250 cmFkaWN0IGVhY2ggb3RoZXIgYm90aAo+IG5lZWRlZD8gIEl0IGxvb2tzIGxpa2UgdGhlIG5ldyBj b2RlIGNvdWxkIGJlIGNvbWJpbmVkIHdpdGgKPiBhY3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdCgp IHRvIGRvIHRoZSByaWdodCB0aGluZyBpbiBhbGwgY2FzZXMuCj4gCj4gTm93LCBhY3BpX3Byb2Nl c3Nvcl9ob3RhZGRfaW5pdCgpIGRvZXMgc29tZSBleHRyYSB0aGluZ3MgdGhhdCBsb29rCj4gbGlr ZSB0aGV5IHNob3VsZCBiZSBkb25lIGJ5IHRoZSBuZXcgY29kZSB0b28uCj4gCj4gMS4gSXQgY2hl Y2tzIGludmFsaWRfcGh5c19jcHVpZCgpIHdoaWNoIGFwcGVhcnMgdG8gYmUgYSBnb29kIGlkZWEg dG8gbWUuCj4gCj4gMi4gSXQgdXNlcyBsb2NraW5nIGFyb3VuZCBhcmNoX3JlZ2lzdGVyX2NwdSgp IHdoaWNoIGRvZXNuJ3Qgc2VlbQo+IHVucmVhc29uYWJsZSBlaXRoZXIuCj4gCj4gMy4gSXQgY2Fs bHMgYWNwaV9tYXBfY3B1KCkgYW5kIEknbSBub3Qgc3VyZSB3aHkgdGhpcyBpcyBub3QgZG9uZSBi eQo+IHRoZSBuZXcgY29kZS4KPiAKPiBUaGUgb25seSB0aGluZyB0aGF0IGNhbiBiZSBkcm9wcGVk IGZyb20gaXQgaXMgdGhlIF9TVEEgY2hlY2sgQUZBSUNTLAo+IGJlY2F1c2UgYWNwaV9wcm9jZXNz b3JfYWRkKCkgd29uJ3QgZXZlbiBiZSBjYWxsZWQgaWYgdGhlIENQVSBpcyBub3QKPiBwcmVzZW50 IChhbmQgbm90IGVuYWJsZWQgYWZ0ZXIgdGhlIGZpcnN0IHBhdGNoKS4KPiAKPiBTbyB3aHkgZG9l cyB0aGUgY29kZSBub3QgZG8gMSAtIDMgYWJvdmU/CgpIb25lc3RseSwgSSdtIG91dCBvZiBteSBk ZXB0aCB3aXRoIHRoaXMgYW5kIGNhbid0IGFuc3dlciB5b3VyCnF1ZXN0aW9ucyAtIGFuZCBJIHJl YWxseSBkb24ndCB3YW50IHRvIHRyeSBmaWRkbGluZyB3aXRoIHRoaXMgY29kZQpiZWNhdXNlIGl0 J3MganVzdCB0b28gaWNreSAoZXZlbiBpbiBpdHMgY3VycmVudCBmb3JtIGluIG1haW5saW5lKQp0 byBiZSB1bmRlcnN0YW5kYWJsZSB0byBhbnlvbmUgd2hvIGhhc24ndCBnYWluZWQgYSBkZXRhaWxl ZCBrbm93bGVkZ2UKb2YgdGhpcyBjb2RlLgoKSXQncyBnb2luZyB0byByZXF1aXJlIGEgbG90IG9m IGFuYWx5c2lzIC0gaG93IGFjcGlfbWFwX2NwdWlkKCkgYmVoYXZlcwppbiBhbGwgY2lyY3Vtc3Rh bmNlcywgd2hhdCB0aGlzIG1lYW5zIGZvciBpbnZhbGlkX2xvZ2ljYWxfY3B1aWQoKSBhbmQKaW52 YWxpZF9waHlzX2NwdWlkKCksIHdoYXQgcGF0aHMgd2lsbCBiZSB0YWtlbiBpbiBlYWNoIGNhc2Uu IFRoaXMgY29kZQppcyBhbHJlYWR5IGp1c3QgdG9vIGhhaXJ5IGZvciBzb21lb25lIHdobyBpc24n dCBhbiBleHBlcmllbmNlZCBBQ1BJCmhhY2tlciB0byBiZSBhYmxlIHRvIGZvbGxvdyBhbmQgSSBk b24ndCBzZWUgYW4gb2J2aW91cyB3YXkgdG8gbWFrZSBpdAptb3JlIHJlYWRhYmxlLgoKSmFtZXMn IGFkZGl0aW9ucyBtYWtlIGl0IGV2ZW4gbW9yZSBjb21wbGV4IGFuZCBsZXNzIHJlYWRhYmxlLgoK LS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVs b3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUhIDgwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50 IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=