All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, ying.huang@intel.com,
	stable@vger.kernel.org, hyeongtak.ji@sk.com, hannes@cmpxchg.org,
	baolin.wang@linux.alibaba.com, byungchul@sk.com
Subject: Re: + mm-vmscan-fix-a-bug-calling-wakeup_kswapd-with-a-wrong-zone-index.patch added to mm-hotfixes-unstable branch
Date: Tue, 20 Feb 2024 19:46:14 +0100	[thread overview]
Message-ID: <ZdTzdnYeyK4nXfGo@localhost.localdomain> (raw)
In-Reply-To: <20240220032539.63C25C433F1@smtp.kernel.org>

On Mon, Feb 19, 2024 at 07:25:38PM -0800, Andrew Morton wrote:
> From: Byungchul Park <byungchul@sk.com>
> Subject: mm/vmscan: fix a bug calling wakeup_kswapd() with a wrong zone index
> Date: Fri, 16 Feb 2024 20:15:02 +0900
> 
> With numa balancing on, when a numa system is running where a numa node
> doesn't have its local memory so it has no managed zones, the following
> oops has been observed.  It's because wakeup_kswapd() is called with a
> wrong zone index, -1.  Fixed it by checking the index before calling
> wakeup_kswapd().
...
...

> 
> Link: https://lkml.kernel.org/r/20240216111502.79759-1-byungchul@sk.com
> Signed-off-by: Byungchul Park <byungchul@sk.com>
> Reported-by: Hyeongtak Ji <hyeongtak.ji@sk.com>
> Fixes: c574bbe917036 ("NUMA balancing: optimize page placement for memory tiering system")
> Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
> Cc: "Huang, Ying" <ying.huang@intel.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

It's a shame that N_MEMORY can actually have no memory (e.g: memmap
consuming all zone's memory), but here we are:

Reviewed-by: Oscar Salvador <osalvador@suse.de>


-- 
Oscar Salvador
SUSE Labs

      reply	other threads:[~2024-02-20 18:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20  3:25 + mm-vmscan-fix-a-bug-calling-wakeup_kswapd-with-a-wrong-zone-index.patch added to mm-hotfixes-unstable branch Andrew Morton
2024-02-20 18:46 ` Oscar Salvador [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdTzdnYeyK4nXfGo@localhost.localdomain \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=byungchul@sk.com \
    --cc=hannes@cmpxchg.org \
    --cc=hyeongtak.ji@sk.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.