From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Kadambini Nema <kadambini.nema@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package dhcpdump: bump to version 1.9
Date: Tue, 20 Feb 2024 22:35:33 +0100 [thread overview]
Message-ID: <ZdUbJf_FE4FfMaLa@landeda> (raw)
In-Reply-To: <20240219215458.187716-1-kadambini.nema@gmail.com>
Kadambini, All,
On 2024-02-19 13:54 -0800, Kadambini Nema spake thusly:
> - Change the site to a well maintained fork - https://github.com/bbonev/dhcpdump
You could also add a blurb that Fedora 39, at least, also uses that as
an upstream.
> Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
[--SNIP--]
> delete mode 100644 package/dhcpdump/0001-use-non-bsd-structures.patch
$ ./utils/docker-run make check-package
.checkpackageignore:290: ignored file package/dhcpdump/0001-use-non-bsd-structures.patch is missing
Since the file is no longer present, there is no longer any need to
exclude it from being checked.
> diff --git a/package/dhcpdump/0001-Fix-build-with-gcc4.8-use-br-fortify.patch b/package/dhcpdump/0001-Fix-build-with-gcc4.8-use-br-fortify.patch
> new file mode 100644
> index 0000000000..c48d28c23d
> --- /dev/null
> +++ b/package/dhcpdump/0001-Fix-build-with-gcc4.8-use-br-fortify.patch
> @@ -0,0 +1,12 @@
> +Upstream: None
Why? Ideally, we want patches to be submitted upstream, so that they get
applied there, and so we can drop them in the future when we bump to a
future version that carries that patch.
Also, as I explained in my previous review: patches should be
git-formatted (at least when the upstream is git-hosted), with a proper
commit log. Having such a commit log will help make an argument for
upstream to accept the patch, or to sucggest an alternative.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-20 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 1:33 [Buildroot] [PATCH 1/1] package dhcpdump: bump to version 1.9 Kadambini Nema
2024-02-18 21:27 ` Yann E. MORIN
2024-02-19 21:54 ` Kadambini Nema
2024-02-20 21:35 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdUbJf_FE4FfMaLa@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=kadambini.nema@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.