From: Michal Hocko <mhocko@suse.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/4] Convert memcontrol charge moving to use folios
Date: Wed, 21 Feb 2024 08:48:48 +0100 [thread overview]
Message-ID: <ZdWq4K2O9Lpk7SBo@tiehlicka> (raw)
In-Reply-To: <20240111181219.3462852-1-willy@infradead.org>
Hi,
On Thu 11-01-24 18:12:15, Matthew Wilcox wrote:
> No part of these patches should change behaviour; all the called functions
> already convert from page to folio, so this ought to simply be a reduction
> in the number of calls to compound_head().
>
> Matthew Wilcox (Oracle) (4):
> memcg: Convert mem_cgroup_move_charge_pte_range() to use a folio
> memcg: Return the folio in union mc_target
> memcg: Use a folio in get_mctgt_type
> memcg: Use a folio in get_mctgt_type_thp
>
> mm/memcontrol.c | 88 ++++++++++++++++++++++++++-----------------------
> 1 file changed, 46 insertions(+), 42 deletions(-)
sorry, I have missed this before. Thanks for the conversion, all seem
fine. The code is rarely executed because it is not enabled by cgroup
v2. But I do agree that it nicer that it fits to the new folio scheme
after these patches.
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2024-02-21 7:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 18:12 [PATCH 0/4] Convert memcontrol charge moving to use folios Matthew Wilcox (Oracle)
2024-01-11 18:12 ` [PATCH 1/4] memcg: Convert mem_cgroup_move_charge_pte_range() to use a folio Matthew Wilcox (Oracle)
2024-01-15 8:03 ` Muchun Song
2024-01-11 18:12 ` [PATCH 2/4] memcg: Return the folio in union mc_target Matthew Wilcox (Oracle)
2024-01-15 3:49 ` Muchun Song
2024-01-11 18:12 ` [PATCH 3/4] memcg: Use a folio in get_mctgt_type Matthew Wilcox (Oracle)
2024-01-11 19:34 ` Johannes Weiner
2024-01-15 3:48 ` Muchun Song
2024-01-11 18:12 ` [PATCH 4/4] memcg: Use a folio in get_mctgt_type_thp Matthew Wilcox (Oracle)
2024-01-12 1:57 ` Roman Gushchin
2024-01-15 3:47 ` Muchun Song
2024-01-26 17:57 ` [PATCH 0/4] Convert memcontrol charge moving to use folios Shakeel Butt
2024-02-21 7:48 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdWq4K2O9Lpk7SBo@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.