From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F226C48BF6 for ; Wed, 21 Feb 2024 11:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5GlrmlyAJrJ12K3iKJU0P8cKbVqRnxJlBS/USBHFM+E=; b=QD5gWn1dyscw0R a0eE9rGyYrJS+1nYw0gaMwLVl9e3YOLdxzoJTGlrIvs2+X93xb3LQ2WWdljHqtouMoOQ08AX1+1+R /r/jqiAXfWU0GMA6BdCDzkj/Jf9WSY6vj3Vlc4Ribb7LfMt3I6/2jbDwPMu+/yWGgJVsDKXXT3xKu JaM8aPdGq68ZLNu+zxN1VxpDO4deBlVgiNgZABrHABmKtjH8IJZu6Zfo2jZvoJmP88IzIUFYXiMhu 3GXbpQkFA0ZBQfRfHR/mGFO1CnWM7j3oEtem2EyxT/5w+O1+tDEWxo2qRm3aahO/rIE3ttY1jplxd pnjHOB62zRUhngUSE5dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rclCM-00000000lv6-0o0F; Wed, 21 Feb 2024 11:55:38 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rclCI-00000000ltC-0Tbs for linux-riscv@lists.infradead.org; Wed, 21 Feb 2024 11:55:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708516532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=gNnIhRuwWXTUPY94+SLGU4tBD9l1D8CovC5/vKWMsRxSlPhO0cBiF7pFB87rnB2tPz8nlg CfGMNE02QxUeMZoUBo4mmcfUsIsK6cXArci/zzuUbYND48wcArZo8zcGHK2oMZrjIseIlr Sz0tdoqwe0K0Dyl0iMU/DpEAjjqFupA= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-vVMa6fDGM5iEEZK7zf3FNA-1; Wed, 21 Feb 2024 06:55:31 -0500 X-MC-Unique: vVMa6fDGM5iEEZK7zf3FNA-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-6e36ee0fd27so251291b3a.1 for ; Wed, 21 Feb 2024 03:55:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708516530; x=1709121330; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=ZJSm5WK/2VuFElu4/nu75tJ7pUbo6G76e6EhuHU5m0j0FzB0Hq/ZleKGyf11wQvx21 8Z1RauTWKZQ3k0dgAnMEHK0396SJy4RSzZ19UmpYTNeVbcic/tiFkDcpFAZXVTh+VcXu jV8k/cYiS2LCqg4uEKHlcYnO398ZOEgA9wY/72lNBzuebu6xO9l5P5eyg3Hh9K1FDAW9 dLXat0+kjTO9qu4T5Pj7ZNeeKXHDpCMaOErb0gmjGTfl93eGkCS/kxyqXbSyLftekv9b sH+czCOOD88Rjz0zg1lbaC083f9z1Wt6vJOWTkqXZH/oIitEPxXtPq0vJfygqcXitzzO jXeQ== X-Forwarded-Encrypted: i=1; AJvYcCUXasPQkwI3cxR5qVkoYVwIldt4qz/MTYYOkQL/JoDxBUydU1QNq+NkAjJ3nVNmajdGNkfM4N8Zt5W2JvqQyzEIQQw+qxS+ld5QfB9O/E3j X-Gm-Message-State: AOJu0YzohuUhyNHv9GuDkjRoZsybEp1bQbNO0ZLR1HzdOHvKdtNzv/Aj afZ7nb4c7NJKi8yb17BFyyIrH+3XwKXRBL+Ip5dsW/Cx+IrmIVdMC+tXp0h4bd7YcTzE8kSfa75 kj9WB9adpeNeNotZbqfKrjrrOAADG3ZykqXjuzCrVEY5yy2VFDTrX+k+Mezfr6Pw09Q== X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196499pzb.3.1708516530441; Wed, 21 Feb 2024 03:55:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRO+9lM9EY5N92dCc9bYoUlt/pUN8sgkXoKwNhU9AZ+BNLKu2lSvew+Aw+SPUl5ZIlIuODvw== X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196492pzb.3.1708516530136; Wed, 21 Feb 2024 03:55:30 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id b3-20020a170902a9c300b001dc0955c635sm4149309plr.244.2024.02.21.03.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 03:55:29 -0800 (PST) Date: Wed, 21 Feb 2024 19:55:17 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-7-peterx@redhat.com> <20240115183748.GR734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115183748.GR734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_035535_083489_4FEF8F20 X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote: > > Drop that check, not only because it'll never be true for hugepd per any > > known plan, but also it paves way for reusing the function outside > > fast-gup. > > I didn't see any other caller of this function in this series? When > does this re-use happen?? It's reused in patch 12 ("mm/gup: Handle hugepd for follow_page()"). Thanks, -- Peter Xu _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C250C48BF6 for ; Wed, 21 Feb 2024 11:56:22 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KHnlCIhA; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KHnlCIhA; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tfvr50yydz3dSJ for ; Wed, 21 Feb 2024 22:56:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KHnlCIhA; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KHnlCIhA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TfvqD6GvMz2ykt for ; Wed, 21 Feb 2024 22:55:36 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708516533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=KHnlCIhA07Nq1bAmW6MedzwqBPuXkFYPzE2sPHYfGZfOA8sAXHRKv5RNAXl8MYZzXTYg09 /mMEwE05IPR8KFnGwk8+cFg4GfhxE3pyDH8PnU/L2scgOI9NecOL7FW7aBbElZiqyVp2h/ xiLcsIYfIFcyT/toEZa3EoR0DrEK1f8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708516533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=KHnlCIhA07Nq1bAmW6MedzwqBPuXkFYPzE2sPHYfGZfOA8sAXHRKv5RNAXl8MYZzXTYg09 /mMEwE05IPR8KFnGwk8+cFg4GfhxE3pyDH8PnU/L2scgOI9NecOL7FW7aBbElZiqyVp2h/ xiLcsIYfIFcyT/toEZa3EoR0DrEK1f8= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-ilQpuAneNKSO__dtVzwRmw-1; Wed, 21 Feb 2024 06:55:31 -0500 X-MC-Unique: ilQpuAneNKSO__dtVzwRmw-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-5ce9b15f4ccso2844686a12.0 for ; Wed, 21 Feb 2024 03:55:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708516530; x=1709121330; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=c6HYTzOI+/N7euUTSrtptZb5KdJmki14ADQhK5QPnPAVhVGIe7wHVlODr/V3AMudBZ d1K61mW1/7YIp1HjH09TPBAav8+4K8o2IImToxD89s/xxHXzUddGsdz0ROk77NW64m2h VZxpvQQJdEUDMOru0dIWnhV5cvVO/8nqivXCxmDpFFTc8gzYshbLOtWyW5bGo/nhoQIt 1DnvnLBltL6IfGlzF+cwICYkT2j0cIii4gNFOvUWZHqnq3uZVlHPglAWS9ARAv5AM53O 02Nnw//ISATOUT0hXJ3j5wNDh3sgIHX987awNf3PLtSuvrtW3iTM0etTWfpbol+TaSI9 UbSg== X-Forwarded-Encrypted: i=1; AJvYcCX3R1f5b1UsRK71bjVlQ5/YcJfJBTBs9i6IRhgTUNs4vUexOPCYE21lpTkbB/HGRVobKGBbigGItmERUxHlJO0lz0Y1aQY9W3nWSVzYSQ== X-Gm-Message-State: AOJu0Yxu1R8ikluPA89uH0aAOASI8VHNZ+jyPh6TMg3vzsnxXghLygNj FqT6DVT/EAZUQ0sg0QqsKnI8L/OAYZRbHtNilDuRt5ifkkV45GF1T31a4tMsQfoKMJdBptXycsa mahe9aFmozEfEfx7SViJJpxCmJOTNaUVoHBlIBkgpb5N4wm1xd1BR88ozYyaR1nc= X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196505pzb.3.1708516530444; Wed, 21 Feb 2024 03:55:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRO+9lM9EY5N92dCc9bYoUlt/pUN8sgkXoKwNhU9AZ+BNLKu2lSvew+Aw+SPUl5ZIlIuODvw== X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196492pzb.3.1708516530136; Wed, 21 Feb 2024 03:55:30 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id b3-20020a170902a9c300b001dc0955c635sm4149309plr.244.2024.02.21.03.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 03:55:29 -0800 (PST) Date: Wed, 21 Feb 2024 19:55:17 +0800 From: Peter Xu To: Jason Gunthorpe Subject: Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-7-peterx@redhat.com> <20240115183748.GR734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115183748.GR734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Yang Shi , Andrew Jones , linux-mm@kvack.org, Matthew Wilcox , linux-riscv@lists.infradead.org, Andrea Arcangeli , Christoph Hellwig , "Aneesh Kumar K . V" , Vlastimil Babka , Axel Rasmussen , Rik van Riel , John Hubbard , "Kirill A . Shutemov" , linux-arm-kernel@lists.infradead.org, Lorenzo Stoakes , Muchun Song , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote: > > Drop that check, not only because it'll never be true for hugepd per any > > known plan, but also it paves way for reusing the function outside > > fast-gup. > > I didn't see any other caller of this function in this series? When > does this re-use happen?? It's reused in patch 12 ("mm/gup: Handle hugepd for follow_page()"). Thanks, -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BC7FC48BC3 for ; Wed, 21 Feb 2024 11:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AcJszMW5AGSNplR3iXLdk9Y1z7zpyuk4HF2MEYgqQmc=; b=0CIOoeoE4DaMil XIJAwEd0agGydUSp+yp4cQ38S52lPQ9fOsqyUgjvprS06NIst7CE/7W83gJaWHeve/z7Xrvc8Vgd1 JsNLhNXcB83vGQePL8aKlXmwQusqmesJ1zxbtBCszqMn9h8j4PfQeOHxdEc84E74UOB3lkUz6YMy7 5mowhNwGc7SNabqwg4wJfh2VrmnI+iwqRQm45j5HWKXF35KRA1K0Gu+e9+syyZA+nSND9FnQEre0u 0jZnRoF0a6BP7WQ5AlNunB4mZ5e8w+Pl3o5bmx/eIQmKBM7fe4OA6roCFcDD7piQxPF8F9gRTd9sN XYaYWosXBJ4oRshys3cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rclCL-00000000luf-2MWH; Wed, 21 Feb 2024 11:55:37 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rclCI-00000000ltE-0SZt for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 11:55:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708516533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=KHnlCIhA07Nq1bAmW6MedzwqBPuXkFYPzE2sPHYfGZfOA8sAXHRKv5RNAXl8MYZzXTYg09 /mMEwE05IPR8KFnGwk8+cFg4GfhxE3pyDH8PnU/L2scgOI9NecOL7FW7aBbElZiqyVp2h/ xiLcsIYfIFcyT/toEZa3EoR0DrEK1f8= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-330-XOWcPfZmN66tN6blfxfzsw-1; Wed, 21 Feb 2024 06:55:31 -0500 X-MC-Unique: XOWcPfZmN66tN6blfxfzsw-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-5ce9b15f4ccso2844687a12.0 for ; Wed, 21 Feb 2024 03:55:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708516530; x=1709121330; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=hGU4qbK200sOqCPzWXznIRml0lYgo0b3AYxM1KlsVJZaSTu5ER2w/SBKiP3zuqGjWB XmUQvi5Qr1QPcmOpMKZM9zHxrGXl0yLpI57RPnO7djGA5sGvzoxEk/5qClxIGskwE7Rp dRn/IaNeIIeqvTXzjRvWCAwmokMIxGcl8QECLkiHcMLW1jdGgcFLhJ7G7o5kvJeqr8wn snkibqFQIAs4Amd/IHgvCquxRrlSUNycKXbfVofu5edbeo9dgnJ0ykauvLF2J9HuzOv7 DXXt30mqr89Zy5jWhRWHI6MPvMOVT81nKabHEPCoAmbSkz/cTWa43/AwRmtv6aLwDpSm GrVg== X-Forwarded-Encrypted: i=1; AJvYcCVNyCV6BLmVeHL26qTqwf8lnKrQTUCZDKF55p5PrLOslFFyJse+UPX3p+ZyQhekU9Uti76SDEL51BJthCGK7f4EP28FALK4N4lO9qc94p0dJTXd49E= X-Gm-Message-State: AOJu0Yy6VORWwbvrHJ9Fhxt1O9HblGxR2ACNn2APeHg4bftoc8WFvskL CDWadA1eXC62vxN/HKnReqaaSrcsopqcxOktnf79fMBfk8waouluuzo+Za9Us4yfoev2kAOZLc3 sF2IjHtfCrS5QsG+WNpqYjCXXjdlJZ8/3OszK1lwE9+bomPjeNzXzmAPGiYSyVUre9edPOhKt X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196501pzb.3.1708516530442; Wed, 21 Feb 2024 03:55:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRO+9lM9EY5N92dCc9bYoUlt/pUN8sgkXoKwNhU9AZ+BNLKu2lSvew+Aw+SPUl5ZIlIuODvw== X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196492pzb.3.1708516530136; Wed, 21 Feb 2024 03:55:30 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id b3-20020a170902a9c300b001dc0955c635sm4149309plr.244.2024.02.21.03.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 03:55:29 -0800 (PST) Date: Wed, 21 Feb 2024 19:55:17 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-7-peterx@redhat.com> <20240115183748.GR734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115183748.GR734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_035535_078311_05E8667C X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote: > > Drop that check, not only because it'll never be true for hugepd per any > > known plan, but also it paves way for reusing the function outside > > fast-gup. > > I didn't see any other caller of this function in this series? When > does this re-use happen?? It's reused in patch 12 ("mm/gup: Handle hugepd for follow_page()"). Thanks, -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E34C48BC3 for ; Wed, 21 Feb 2024 11:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8ED5F6B007B; Wed, 21 Feb 2024 06:55:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89D536B007E; Wed, 21 Feb 2024 06:55:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73E426B0080; Wed, 21 Feb 2024 06:55:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 63BF86B007B for ; Wed, 21 Feb 2024 06:55:38 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2C52B40A2C for ; Wed, 21 Feb 2024 11:55:38 +0000 (UTC) X-FDA: 81815656356.29.4B3D2BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id B2B0A16000B for ; Wed, 21 Feb 2024 11:55:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GV0pdRqw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708516536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=g3lM5XCZA5P5LV2NrOXJ9L8JC0PpTCMRGjgzJ7YZvk55eN6YjW+eYbwfrjHq8EpT9YPcC+ Ox0oys0AoCLbXh8l8STLb2DNmI+8jBg1CFgpiv9Oind9Aq7+R9wXwX4YRrbAjmQ7NFHlWc Iit5i+tf8H5Spm51sQCRygL7ZBebfF4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GV0pdRqw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708516536; a=rsa-sha256; cv=none; b=V6orrDr38WvwwEY+AzVTcsKReymO4NsKrYni7k8u03d8razOWaTsXPD/n9tM497UbCefSH GAivjBoTIp04SAD9iJvwRAmK69qEep1u/YGBpobh1LXi1hj650L/FuT1XNMaXD9xo3TRy4 NVaKMP/+XNEsYYpvvFqahxucuLPvo38= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708516534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=GV0pdRqwCDFEojga+//XMYrng8iSA9UBdeFwI2m9v5LaeDyHONiCFJaHQqQLJjgB+JnkZ6 1l4BX64CQdGqU7BFTLacCKSCoECcFsdFvO9N+QkQ7QfPnhmfYwyuK+nXANndwjDl3nmUYS VvQQ8UYR8qBiW7PR13BlxrUNM1f0JAs= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-CAt2KnjVO36S6P-mmWZ_hw-1; Wed, 21 Feb 2024 06:55:32 -0500 X-MC-Unique: CAt2KnjVO36S6P-mmWZ_hw-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-6dbd919aba8so1474142b3a.0 for ; Wed, 21 Feb 2024 03:55:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708516530; x=1709121330; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=XWm5rsBlvgljYeKuEbzWTvU1Cu38wi5SG2OhUb4iLd1qZtmkZ9PIuBq3ar97oV8PcH 0hYpQELYxVrvuRl7ynmOgCKLrQ8M+ULgHa7qfzea3gob8ruB2jZfNNx8Moc120WOM1Gw vGL8zXsIEh2/f6qNEoF8M44mJxwvxwnMtabowKOJuqTNRHrlzoF6W71MjOzVIOkzWAsJ tFf512aJnFdIn4IXDVf6nibdncRLWMNzexDuXwM0cGMOyl1Dk7MajEGfNPTzgEgI9QdG 4P5BPk6Lt2pgXJo01E5arTIp3fUlYksyCom2TYEQcCQG4pQ7Z5D3sJp/t06rOlbmkzwb rCQg== X-Gm-Message-State: AOJu0YwPmt/49bQxuIzuP6aYXPe0P68m1xfyRoqajzpXG4oJYdmmW08C MUas4BHBMK0F5Rtw8B6csTt06NzaTVleeMnXMrkp2vyWPEn8n3bFDNI3NJy8VKCrAZI1x6iuxqW YPx3ptmUzmoBWtNU0cENv9RkjThnygozjvhn2E6NIDCc4yVuw X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196521pzb.3.1708516530464; Wed, 21 Feb 2024 03:55:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRO+9lM9EY5N92dCc9bYoUlt/pUN8sgkXoKwNhU9AZ+BNLKu2lSvew+Aw+SPUl5ZIlIuODvw== X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196492pzb.3.1708516530136; Wed, 21 Feb 2024 03:55:30 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id b3-20020a170902a9c300b001dc0955c635sm4149309plr.244.2024.02.21.03.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 03:55:29 -0800 (PST) Date: Wed, 21 Feb 2024 19:55:17 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-7-peterx@redhat.com> <20240115183748.GR734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115183748.GR734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Stat-Signature: 5qp5q5g73okkfr9zkabrq3edo3zqgkws X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B2B0A16000B X-HE-Tag: 1708516535-301789 X-HE-Meta: U2FsdGVkX19yDkZoaV8VtLOxnWznR3TVGThZOEnnrttuGwA1kq87PCK6Yvw+h99iNLsF4Xtm9Q1L+NdtCPPeIPcbIISvZh1ZPyUlStzsSEL+3Nw4unTW35lV4iWLPz8QGRWHC7w1+lr4iQiB/QlGwfe93SKTxeISKDaFoiCwUiXQHAYUtLxvzbLNqjlHX/JBtXk0KIHEIHjowM9N/JdhLGyHDsHTVqn71C/1XFQ12f8Tqq7Tn9UtAfN0AJ+jsa32zIa/savNi5vL5StPwpvgepIc7byI58SOb1fxFGpD0Ek3kxb5kOZMsQCj85Odak5rSe2l71wmPC2IumGBXCIuH2S0cRx4XoQ7sADltYBkx8NEd3lkbHXkhkvY/gMRFqSHVGOY8NLQjbr3iypYBMYGBZRlbJfWpNxJVXsGciREPR0jje4uy+fVoiDQb7iJzQDOKDxesiZ7l8kBgvSpvU1SxqOf1uJrka16YDQvGunwUJMBHEiBT0frr0f9aubLhDY5aXhjuQ7dJs5al0/q6neRXeh0+cOe41JEx8JQVBeJfrMuIWQIW/g2Aoxnt6skcgfZjuxk60p6+YlVYBy0djoNevtLEhBy+1Qtz8tPoRi2uEdjApVMNbSTKp+pekDg/br/r3bHhsGTWlSb/jKV6Wsq91yrvBn7gAZ63Zwt41B/5EM1szsbxLTGoFAiDwN8l5QJRDMtcaISkL8BvhgPvrCaHz3texjELR50p9kQPfVe9CTDkpfTWXUA/MkrXnJoUNz3HfbC91RhQ0HGuqMnhUydV9fLGZnLRoVGCjmOG80VOJs9Sxbtl0lsdz+K0byvydQ2s0c4+XEYrITgbULV/60DRvoVG6DkeFPaianLJ033h700wr4w5poHjQw+LVoC7JATDd31YqHXSgyok/Xb9lImX1BbboDTHE6e/Y27GzH66hMbBTRx5eMivDha9zHlpPPKLwEcuHZklMToqhAKbG/ H7ldcEru fYgWVmE5/44kDWBLlI6t2oV308IIEgKDKSXU3ZVIPsRKiLig1bPshXBcle2f3b/6hSo3gayspcUEjErHlouI/9tezfkjuIbF+CxYJ9UAPsA9XhArZjd1k2V7HG43k6STfVKx7sGBKyrVLGRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote: > > Drop that check, not only because it'll never be true for hugepd per any > > known plan, but also it paves way for reusing the function outside > > fast-gup. > > I didn't see any other caller of this function in this series? When > does this re-use happen?? It's reused in patch 12 ("mm/gup: Handle hugepd for follow_page()"). Thanks, -- Peter Xu