From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Wed, 21 Feb 2024 20:53:08 +0200 Subject: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type In-Reply-To: References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> <20240221183442.4124354-3-andriy.shevchenko@linux.intel.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Feb 21, 2024 at 10:47:13AM -0800, Florian Fainelli wrote: > On 2/21/24 10:31, Andy Shevchenko wrote: ... > > unsigned char iotype; /* io access style */ > > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */ > > Nit: I would name this UPIO_UNKNOWN, or UPIO_NOTSET, unset means to me that > it was previously set and we undid that action, whereas unknown or not set > means we never did. Works for me. I will wait for a few days / week to have more reviews and likely testings to be collected. Would be nice if you be able to test on (some of) the hardware in the list of modified drivers. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA908004E; Wed, 21 Feb 2024 18:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541606; cv=none; b=cur42VPAlvnufPaCSnBoNYkjHV+u+yQ6a0DH0HMMGuO96SZj1Sz0gjWlXY/e7v9Td4r4FOZmUfeAPaiMpAj3NIsm/iPp2+9JjHV4pimTy/YbDpF//PU9U+6DVQCEj7sMZzx44FRwg9VOIoOAKDzYnkPD/i/MUZE+lhLl8qStYtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541606; c=relaxed/simple; bh=eMGM5YzEKrkILV3+3vpXcMdr1HJpfGEmL2Nq2vxUdlA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rrusEhhm4f4NoEd5s13C3tWDNLv5SiW2iBisPtXCES2o/PzDrkTtzNUe7O5wAQ0+9eWPzlKWHMljERRPSsEzdJfW5ZYnw2xiohYl613z4qRJDhq3pvAZvkSXh/U35PZXOaxctgyuuLQ1syK9xJKVePwva98A5DbXl1D0LiUvTHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DzYocgmy; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DzYocgmy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708541605; x=1740077605; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eMGM5YzEKrkILV3+3vpXcMdr1HJpfGEmL2Nq2vxUdlA=; b=DzYocgmyYE5xVXo3eH3x0l1WnYqxOITEAbCnclvpCPDwPvLgc88Y7XAD JcT9L2g36sCA1fcnZgQljIEcSssFhg9vgUTOilcEeOijcpi8gIN4+17Vx BNckqNnH116PBTYZarBYpMEliBP+76mZYQRSHMwWt4ycuf5r47O60sNJc 4yeWYTDUPjFD+jJLY5gshzCbcVQC5MTx8wHoecEO2EyLF1Vf3UuMm+1Qx jwnitTyRubUOfKSYsM3P9hrkoZlVjXM41/wNR4dHN3PZ5CVaITiezbvDR hLd/i6Nu9KFpAZpfu/xgDMg12l62XYQZZX6qVMy01fyNxfRo3JukF5QmM Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="2871965" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="2871965" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 10:53:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="913353183" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="913353183" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 10:53:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rcriO-00000006QtU-2avs; Wed, 21 Feb 2024 20:53:08 +0200 Date: Wed, 21 Feb 2024 20:53:08 +0200 From: Andy Shevchenko To: Florian Fainelli Cc: Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org, Jiri Slaby , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Al Cooper , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Paul Cercueil , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu Subject: Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type Message-ID: References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> <20240221183442.4124354-3-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 21, 2024 at 10:47:13AM -0800, Florian Fainelli wrote: > On 2/21/24 10:31, Andy Shevchenko wrote: ... > > unsigned char iotype; /* io access style */ > > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */ > > Nit: I would name this UPIO_UNKNOWN, or UPIO_NOTSET, unset means to me that > it was previously set and we undid that action, whereas unknown or not set > means we never did. Works for me. I will wait for a few days / week to have more reviews and likely testings to be collected. Would be nice if you be able to test on (some of) the hardware in the list of modified drivers. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E723C5478A for ; Wed, 21 Feb 2024 18:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tBhNeyDzWv1Oe40EthsITvnoC8b3QYYOnhpKL8TEuN8=; b=bLbJdiu9OUPxHz Z/kYkp+8Jc8Vn5y0HphwXseXA2Yx6HPpJ6JYtZ3eBVPmIKDOYx4IuxMMiyoODnZvnhKtKV7auuzMX L+A3qfP9dUsxh0haiYb5P/cRkyIsZtk1oFHmKAzGr+fuDOBbL19D82k2nBjrs7cRmsAnD1uniKEvF eMLcH2UAZwlAUPvbfsyRT4ERNUVZ1immdfGhaZKdRFaQEQE2fxgqnxVcWcpMjdF785P17vvDcr7wZ zpGWxlv/WjfZCtAEycgTtnHqBJ3A6ld8mnIMk90nuNXoahMC5QclUGCVPhHVsnBIAT0ElntOrD7e3 VXZVzibQJGv4uWyaT2lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcrix-00000002BqA-1AEG; Wed, 21 Feb 2024 18:53:43 +0000 Received: from mgamail.intel.com ([192.198.163.14]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcrii-00000002Bnh-18oE; Wed, 21 Feb 2024 18:53:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708541608; x=1740077608; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eMGM5YzEKrkILV3+3vpXcMdr1HJpfGEmL2Nq2vxUdlA=; b=mOFOWcShVt+TbXX+ibdcm7vdw6dvP1Z1zcq5U17Q2n9Phb8z3yIVescX +mNuFsbNeuMT3JYJq30EhR8HosaAuCNF55XdUXbE+ybmMlbMIuHzKVK8s 2QPzgwGlPSm9c1qYzeO/P4EpiHVgIMgoVPHTHvdZyescHM0JRbmYarSWG pDMSwpMYwHhFPzEBXzQXMZ8UGiTogE4dB/DA/ZWRjdwR/MMhnowvDBbF+ dArh5oL01X4NOYgLeh0tYySkL8hpyH08pWsZ5Za/fTrUcjsgvQyO/hMM0 bmMt1sevjr2zuEm4qehgPHqr/GXqkYTZctzyJiApzwcNcBYhYXTGpnBTU w==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="2871970" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="2871970" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 10:53:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="913353183" X-IronPort-AV: E=Sophos;i="6.06,176,1705392000"; d="scan'208";a="913353183" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 10:53:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rcriO-00000006QtU-2avs; Wed, 21 Feb 2024 20:53:08 +0200 Date: Wed, 21 Feb 2024 20:53:08 +0200 From: Andy Shevchenko To: Florian Fainelli Cc: Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org, Jiri Slaby , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Al Cooper , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Paul Cercueil , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu Subject: Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type Message-ID: References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> <20240221183442.4124354-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_105330_595811_32F6E75F X-CRM114-Status: GOOD ( 14.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 21, 2024 at 10:47:13AM -0800, Florian Fainelli wrote: > On 2/21/24 10:31, Andy Shevchenko wrote: ... > > unsigned char iotype; /* io access style */ > > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */ > > Nit: I would name this UPIO_UNKNOWN, or UPIO_NOTSET, unset means to me that > it was previously set and we undid that action, whereas unknown or not set > means we never did. Works for me. I will wait for a few days / week to have more reviews and likely testings to be collected. Would be nice if you be able to test on (some of) the hardware in the list of modified drivers. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel