Re: [PATCH] drm/xe: Add debug prints for skipping rebinds

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Feb 20, 2024 at 07:27:43PM -0800, Matthew Brost wrote:
> Will help debug issues with VM binds.

worth adding more cases?

anyway,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 23a44ef85aa4..bf040df0d02b 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2287,6 +2287,7 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, struct xe_exec_queue *q,
>  				   struct xe_sync_entry *syncs, u32 num_syncs,
>  				   struct list_head *ops_list, bool last)
>  {
> +	struct xe_device *xe = vm->xe;
>  	struct xe_vma_op *last_op = NULL;
>  	struct drm_gpuva_op *__op;
>  	int err = 0;
> @@ -2362,6 +2363,9 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, struct xe_exec_queue *q,
>  						xe_vma_end(vma) -
>  						xe_vma_start(old);
>  					op->remap.start = xe_vma_end(vma);
> +					vm_dbg(&xe->drm, "REMAP:SKIP_PREV: addr=0x%016llx, range=0x%016llx",
> +					       (ULL)op->remap.start,
> +					       (ULL)op->remap.range);
>  				}
>  			}
>  
> @@ -2392,6 +2396,9 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, struct xe_exec_queue *q,
>  					op->remap.range -=
>  						xe_vma_end(old) -
>  						xe_vma_start(vma);
> +					vm_dbg(&xe->drm, "REMAP:SKIP_NEXT: addr=0x%016llx, range=0x%016llx",
> +					       (ULL)op->remap.start,
> +					       (ULL)op->remap.range);
>  				}
>  			}
>  			break;
> -- 
> 2.34.1
>