From: Keith Busch <kbusch@kernel.org>
To: Michael Kropaczek <michael.kropaczek@solidigm.com>
Cc: linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v1 0/1] nvme: Fix problem when booting from NVMe drive was leading to a hang.
Date: Thu, 22 Feb 2024 09:27:48 -0700 [thread overview]
Message-ID: <Zdd2BOp6DEC6N51V@kbusch-mbp> (raw)
In-Reply-To: <20240221084340.825068-1-michael.kropaczek@solidigm.com>
On Wed, Feb 21, 2024 at 12:43:40AM -0800, Michael Kropaczek wrote:
> @@ -2593,6 +2593,16 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown)
> nvme_wait_freeze_timeout(&dev->ctrl, NVME_IO_TIMEOUT);
> }
>
> + /*
> + * On certain host architectures/HW, DRAM was keeping memory contents over reboot-cycles.
> + * It was observed that certain controllers were accessing host memory after
> + * resetting which led to undefined state preventing proper initialization.
> + */
> + if (dev->hmb)
> + nvme_set_host_mem(dev, 0);
> +
> + nvme_free_host_mem(dev);
> +
Shouldn't this go in nvme_shutdown() instead? I don't think we want to
tear down the controller's host memory on every controller reset.
next prev parent reply other threads:[~2024-02-22 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 8:43 [PATCH v1 0/1] nvme: Fix problem when booting from NVMe drive was leading to a hang Michael Kropaczek
2024-02-22 16:27 ` Keith Busch [this message]
2024-02-22 20:02 ` Michael Kropaczek
2024-02-22 20:36 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdd2BOp6DEC6N51V@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=michael.kropaczek@solidigm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.