From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v1 1/1] kernel.h: Move lib/cmdline.c prototypes to string.h
Date: Thu, 22 Feb 2024 19:17:55 +0200 [thread overview]
Message-ID: <ZdeBwyCyFx13LTEC@smile.fi.intel.com> (raw)
In-Reply-To: <CAHp75VeqvxjqXjmF8ymEYevJkCoQVnkJiuBkccHuGsU_E14LzA@mail.gmail.com>
On Wed, Oct 04, 2023 at 12:27:41PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 4, 2023 at 2:39 AM Kees Cook <keescook@chromium.org> wrote:
> > On Tue, Oct 03, 2023 at 04:01:42PM +0300, Andy Shevchenko wrote:
> > > The lib/cmdline.c is basically a set of some small string parsers
> > > which are wide used in the kernel. Their prototypes belong to the
> > > string.h rather then kernel.h.
> >
> > I think these should live in string_helpers.h not string.h (which is, in
> > theory, supposed to be used for the standard C string library functions,
> > though that's not 100% currently)...
>
> These are being used in the early stages where usually we have
> string.h. So, I would argue, but if you insist, I can move them. What
> about lib/argv_slit.c then? Because semantically it's quite close to
> what the lib/cmdline.c is doing.
So, if no further ARs, can we got this applied and move on?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-22 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 13:01 [PATCH v1 1/1] kernel.h: Move lib/cmdline.c prototypes to string.h Andy Shevchenko
2023-10-03 23:39 ` Kees Cook
2023-10-04 9:27 ` Andy Shevchenko
2024-02-22 17:17 ` Andy Shevchenko [this message]
2024-02-23 17:41 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdeBwyCyFx13LTEC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.