From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Wei Fang <wei.fang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH net-next v6 5/8] net: phy: Immediately call adjust_link if only tx_lpi_enabled changes
Date: Fri, 23 Feb 2024 10:38:20 +0000 [thread overview]
Message-ID: <Zdh1nMWZDynP/AMc@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240223094425.691209-6-o.rempel@pengutronix.de>
On Fri, Feb 23, 2024 at 10:44:22AM +0100, Oleksij Rempel wrote:
> +static void phy_ethtool_set_eee_noneg(struct phy_device *phydev,
> + struct ethtool_keee *data)
> +{
> + if (phydev->eee_cfg.tx_lpi_enabled !=
> + data->tx_lpi_enabled) {
> + eee_to_eeecfg(data, &phydev->eee_cfg);
> + phydev->enable_tx_lpi = eeecfg_mac_can_tx_lpi(&phydev->eee_cfg);
> + if (phydev->link)
> + phy_link_up(phydev);
I'm not convinced this is a good idea. Hasn't phylib previously had
the guarantee that the link will go down between two link-up events?
So calling phy_link_up() may result in either the MAC driver ignoring
it, or modifying registers that are only supposed to be modified while
the MAC side is down.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-02-23 10:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 9:44 [PATCH net-next v6 0/8] net: ethernet: Rework EEE Oleksij Rempel
2024-02-23 9:44 ` [PATCH net-next v6 1/8] net: add helpers for EEE configuration Oleksij Rempel
2024-02-23 9:44 ` [PATCH net-next v6 2/8] net: phy: Add phydev->enable_tx_lpi to simplify adjust link callbacks Oleksij Rempel
2024-02-23 9:44 ` [PATCH net-next v6 3/8] net: phy: Add helper to set EEE Clock stop enable bit Oleksij Rempel
2024-02-23 9:44 ` [PATCH net-next v6 4/8] net: phy: Keep track of EEE configuration Oleksij Rempel
2024-02-23 9:44 ` [PATCH net-next v6 5/8] net: phy: Immediately call adjust_link if only tx_lpi_enabled changes Oleksij Rempel
2024-02-23 10:38 ` Russell King (Oracle) [this message]
2024-02-23 12:49 ` Oleksij Rempel
2024-02-23 13:17 ` Andrew Lunn
2024-02-23 13:26 ` Russell King (Oracle)
2024-02-23 17:53 ` Florian Fainelli
2024-02-24 17:57 ` Oleksij Rempel
2024-02-26 16:44 ` Andrew Lunn
2024-02-26 17:50 ` Florian Fainelli
2024-02-26 17:53 ` Russell King (Oracle)
2024-02-26 18:59 ` Andrew Lunn
2024-02-27 5:35 ` Oleksij Rempel
2024-02-27 16:12 ` Andrew Lunn
2024-02-23 9:44 ` [PATCH net-next v6 6/8] net: phy: Add phy_support_eee() indicating MAC support EEE Oleksij Rempel
2024-02-23 9:44 ` [PATCH net-next v6 7/8] net: fec: Move fec_enet_eee_mode_set() and helper earlier Oleksij Rempel
2024-02-23 9:44 ` [PATCH net-next v6 8/8] net: fec: Fixup EEE Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdh1nMWZDynP/AMc@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.