From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAC73C54E49 for ; Fri, 23 Feb 2024 09:45:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2818C41C49; Fri, 23 Feb 2024 09:45:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7HUOz3iBx0b6; Fri, 23 Feb 2024 09:45:11 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 37E5741C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1708681511; bh=+nH1F52q4rLe3ymlUZMyRqVEVVMZkXwzmavUZRGEwv4=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Ks6ZyNrcz5M3rE+M78jclzC8A6CV/OYo0tn+4Xfmtuid7MzqAyd9rs8RmsZXV+e8Y Ge64ZP6c3YFwYua931D0OdZklmIubwXnv3jH/K3tVTELchPUnVGg2WchavNy/LJ1uB ruOunxjNm92Xw0Ld5JNEzJzOX84z76Hl8u+hdqnJK7uMkNDAaPtVvWGm+Zbh6t2vub +pKUVjc5mxuOZT+o4njBxjdO7r/YErNo+Ze+aluIIDGhprBUnTz+jvf1KZ8qGetHAl Wul6cQ7duCqxVWrNILOcs/dzQF6oPChm7eScJc4mqrfC/dhZ8KSFamK7DhtZ5kud2L hnle92sIW2FSg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 37E5741C41; Fri, 23 Feb 2024 09:45:11 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id B9D551BF3C3 for ; Fri, 23 Feb 2024 09:45:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B26CB41C41 for ; Fri, 23 Feb 2024 09:45:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5y5zkS87Rh8J for ; Fri, 23 Feb 2024 09:45:08 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org C028640124 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C028640124 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by smtp2.osuosl.org (Postfix) with ESMTPS id C028640124 for ; Fri, 23 Feb 2024 09:45:05 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-33d509ab80eso90585f8f.3 for ; Fri, 23 Feb 2024 01:45:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708681503; x=1709286303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+nH1F52q4rLe3ymlUZMyRqVEVVMZkXwzmavUZRGEwv4=; b=UXYesaVhu6CkgYzlgbFGMzI67nIalJi+nCfkToWs09gDKV4+ax5eQX7pOFeUKm5M8E p/awjznQrheWwPdgJRY2VZ2z2tuvL2YSpeU/CwjZtEGctQk/1xpIEysXy9TEC2fJv+7j m6JVJ6TJlhl0ZyI2AJ6b7d3qt/h9NUKGgetovyLwchmvAfYezYtsI4HXObPu3tdSvwLb 35qeZwdnEJy+5to/0ZLwjgRawT+4o/tpCHjp8+7spbd5dLNKwIB7ZDGqdP+ZsBWr90Lt rTCWCmOndO0Sk3iglxbCMMngjzjN/nXNAUf6cEW1yuhn4dfSEY+Zccutrv+pZJAxxKqB PbBA== X-Forwarded-Encrypted: i=1; AJvYcCWMiqzfPLyVdjuUXEZ6KBePvwC9gvnSgx8Nl3rk3CnTZZA4WegZKzD1+1REHl54vZXyTgy9Vqs6Fx+J7teAaaR3+7BX9y6Ia5kNa1v+PdWBDA== X-Gm-Message-State: AOJu0YwmXHSakrHmwR1mta0EE7CE3bJ1YvLqCxCv49g987zzdZ5mpwbL 89JdymVEBpHHMDMprhxSD7HAZzA3UxiqAET+SU4ircrgSXTqrrBV3BBOQKfYS2w= X-Google-Smtp-Source: AGHT+IEMYZMDyaCNjC5G1U1WTbH2JglqVVhiwwy0U9OE9LYAfJieqXydgfrrbq/8v5nS0XunwGDuQQ== X-Received: by 2002:a5d:4e89:0:b0:33d:746b:f360 with SMTP id e9-20020a5d4e89000000b0033d746bf360mr956434wru.51.1708681503176; Fri, 23 Feb 2024 01:45:03 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id r5-20020adff105000000b003392206c808sm2139169wro.105.2024.02.23.01.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 01:45:02 -0800 (PST) Date: Fri, 23 Feb 2024 10:45:01 +0100 From: Jiri Pirko To: Jakub Kicinski Message-ID: References: <20240219100555.7220-1-mateusz.polchlopek@intel.com> <20240219100555.7220-5-mateusz.polchlopek@intel.com> <20240221153805.20fbaf47@kernel.org> <20240222150717.627209a9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222150717.627209a9@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1708681503; x=1709286303; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+nH1F52q4rLe3ymlUZMyRqVEVVMZkXwzmavUZRGEwv4=; b=DbJAnnML1kvSiyj/uH6u3GZuTgTf1ithg2eqWK9UP6jMEf0t8qw2Cyog71SlVfu6l7 sV1nTbHef+Rgu35ljduqCHnZePCTdeo42Ek811/gU8/7GftUeM+1l70On1nylj9RqV+X Om6nky5I9rPv8m36fkJuRRgDhprObWhPWMkilCC7glEWAanhjptCoBkC4khhwXHlzV+N ptZ2pOR9PlPFnHBNihKl7zsbP8udqBHvouQQQ0eIf3i1/AAWCfFIO8puo5VXbRVBeSEq fAlNNRxnrf9Vbhy+lyHx+T0BdfAizxc7Rj4wc+Rr9wsdnpr9Ta5tpmc90pQ45QXttmqO LDjQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=DbJAnnML Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mateusz Polchlopek , netdev@vger.kernel.org, Lukasz Czapnik , intel-wired-lan@lists.osuosl.org, horms@kernel.org, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Fri, Feb 23, 2024 at 12:07:17AM CET, kuba@kernel.org wrote: >On Thu, 22 Feb 2024 14:25:21 +0100 Mateusz Polchlopek wrote: >> >> This is kind of proprietary param similar to number of which were shot >> >> down for mlx5 in past. Jakub? >> > >> > I remain somewhat confused about what this does. >> > Specifically IIUC the problem is that the radix of each node is >> > limited, so we need to start creating multi-layer hierarchies >> > if we want a higher radix. Or in the "5-layer mode" the radix >> > is automatically higher? >> >> Basically, switching from 9 to 5 layers topology allows us to have 512 >> leaves instead of 8 leaves which improves performance. I will add this >> information to the commit message and Documentation too, when we get an >> ACK for devlink parameter. > >Sounds fine. Please update the doc to focus on the radix, rather than >the layers. Layers are not so important to the user. And maybe give an >example of things which won't be possible with 5-layer config. > >Jiri, I'm not aware of any other devices with this sort of trade off. >We shouldn't add the param if either: > - this can be changed dynamically as user instantiates rate limiters; > - we know other devices have similar needs. >If neither of those is true, param seems fine to me.. Where is this policy documented? If not, could you please? Let's make this policy clear for now and for the future. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4F165D46D for ; Fri, 23 Feb 2024 09:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708681506; cv=none; b=O+aa5St0i6mnXLUzBkFMokhm0bOuxgHpViRUU2DFlPx+pDbqkrcA+KBWcfMWAGg6Q8ZrZ7MPi59aEh5WDt9IK2gsJp+b0taWzbgjJDkjG1SnpmTPca5OsaqSUnubnlkiqNoef1TrNYW1uzik1AGu5+eNsXrnRtU/I5dhthYLSTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708681506; c=relaxed/simple; bh=RqtsaE056Krnim8QDKYiai6V0prmbpjnfSDFqfueVIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G8sOhukVQjivwBz2bSr65pHzcxLvA3R9c9bGo1rvdE4ULc7fEXqI1Wu6f3MRXArDSL1LtTQEgzWOv3a439kQAX/Ya3FvRdgN0QzzmmbmlvkKRinxLOhesUUH8jPjBD9SG7ia9FvGyzKW9/ooFX9BXNjIjAq40P3mqUrFTazgi+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=G5PstWH5; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="G5PstWH5" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-33d8d5165dbso101915f8f.1 for ; Fri, 23 Feb 2024 01:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1708681503; x=1709286303; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+nH1F52q4rLe3ymlUZMyRqVEVVMZkXwzmavUZRGEwv4=; b=G5PstWH59b5PaHlhyExmjmVqjjdcBLdm4VnkuvYwR8y8hKznjilKrBu2vGv2j5IHxu wL9mDgHthRgWac5HgbJ3yml+e/kBi2fZwxZ7/VJ0k+JWzqLSKAVwZNs6WRYsIErOfP3J B1v3rtDLJvilRxQqFmNDgl/HwVKnQfZRt3bRgu0zEAKTf2MVag8ZvGEm/6uRM/E0PA8j U4l1ZpHX0p/cnSPwAhz2iY/cJkYlaFCoWE6g3GSkKq+6FMWBNpP0NDE+RXdmRcMPq6qe sIlblTyClJpIDRW6zuyiCoztHvWv1UYZk4p7DkWppX74iv3/BEnMF2VkoW7NKcbUrcw9 zZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708681503; x=1709286303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+nH1F52q4rLe3ymlUZMyRqVEVVMZkXwzmavUZRGEwv4=; b=uGO5NFDSqoDtkrcHFcRYgSsotXMcMdiKa5JDlD2lpiFvvEPgXdgpFT6Y0voQEOpbrf ZaIDWDzohz/pPn9j9XbWAizaN77dDqgbbf26RtTAmPippfq+siLSMAaiOYKmEygPwmRx G0G1fZV7ydOWWGh8gkaCf2LWiQK1N4qoOi9gGSeTS9zh2rKJYy4so86TPF8j959PWmpe 5bgzifTNLa8660sRgyUFggLworMg5n1kIZbSxkixJhr7Q93Gj55smtV3t53LPQpza4ve FgKYovlC/nPyZm8YbZHme4viQVJvs8VNwFxMz9VNu+PNXjbRHA9V6HUn6BFV7sEWlSzt 2Syg== X-Forwarded-Encrypted: i=1; AJvYcCXPCkB70w772C3oAz82IEQb7TFye/4BT2fKQlT436/5BEF3cm4RUOUhsxiRaqRbpMMiJl1PSAZwrvF8d4Hd91sbiY5HS68K X-Gm-Message-State: AOJu0Yycb7YF7ytURYidGBcMCq521w+PTIj7itk7plHmU0r2I63I9l/F q6zTaTW339W7NbGQ8XrNRP1uBv0tfHGU8fBDHpiBaLl20Zu6AhWbc0zS7d5GrwY= X-Google-Smtp-Source: AGHT+IEMYZMDyaCNjC5G1U1WTbH2JglqVVhiwwy0U9OE9LYAfJieqXydgfrrbq/8v5nS0XunwGDuQQ== X-Received: by 2002:a5d:4e89:0:b0:33d:746b:f360 with SMTP id e9-20020a5d4e89000000b0033d746bf360mr956434wru.51.1708681503176; Fri, 23 Feb 2024 01:45:03 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id r5-20020adff105000000b003392206c808sm2139169wro.105.2024.02.23.01.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 01:45:02 -0800 (PST) Date: Fri, 23 Feb 2024 10:45:01 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: Mateusz Polchlopek , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, horms@kernel.org, przemyslaw.kitszel@intel.com, Lukasz Czapnik Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param Message-ID: References: <20240219100555.7220-1-mateusz.polchlopek@intel.com> <20240219100555.7220-5-mateusz.polchlopek@intel.com> <20240221153805.20fbaf47@kernel.org> <20240222150717.627209a9@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222150717.627209a9@kernel.org> Fri, Feb 23, 2024 at 12:07:17AM CET, kuba@kernel.org wrote: >On Thu, 22 Feb 2024 14:25:21 +0100 Mateusz Polchlopek wrote: >> >> This is kind of proprietary param similar to number of which were shot >> >> down for mlx5 in past. Jakub? >> > >> > I remain somewhat confused about what this does. >> > Specifically IIUC the problem is that the radix of each node is >> > limited, so we need to start creating multi-layer hierarchies >> > if we want a higher radix. Or in the "5-layer mode" the radix >> > is automatically higher? >> >> Basically, switching from 9 to 5 layers topology allows us to have 512 >> leaves instead of 8 leaves which improves performance. I will add this >> information to the commit message and Documentation too, when we get an >> ACK for devlink parameter. > >Sounds fine. Please update the doc to focus on the radix, rather than >the layers. Layers are not so important to the user. And maybe give an >example of things which won't be possible with 5-layer config. > >Jiri, I'm not aware of any other devices with this sort of trade off. >We shouldn't add the param if either: > - this can be changed dynamically as user instantiates rate limiters; > - we know other devices have similar needs. >If neither of those is true, param seems fine to me.. Where is this policy documented? If not, could you please? Let's make this policy clear for now and for the future.