From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
maple-tree@lists.infradead.org, rcu@vger.kernel.org
Subject: Re: [PATCH 0/1] Rosebush, a new hash table
Date: Fri, 23 Feb 2024 14:55:01 +0100 [thread overview]
Message-ID: <ZdijtQNFuziHnqH2@zx2c4.com> (raw)
In-Reply-To: <20240222203726.1101861-1-willy@infradead.org>
Hi Matthew,
On Thu, Feb 22, 2024 at 08:37:23PM +0000, Matthew Wilcox (Oracle) wrote:
> Rosebush is a resizing, scalable, cache-aware, RCU optimised hash table.
> I've written a load of documentation about how it works, mostly in
> Documentation/core-api/rosebush.rst but some is dotted through the
> rosebush.c file too.
If you're interested, WireGuard has some pretty primitive hashtables,
for which maybe Rosebush would be an interesting replacement:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireguard/peerlookup.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireguard/peerlookup.h#n17
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireguard/ratelimiter.c#n167
In peerlookup.c, note the "At the moment, we limit" comment for an idea
of some of the hairy issues involved in replacing these. But I wouldn't
be entirely opposed to it, if you see some interesting potential for
Rosebush here. That's a very tentative interest -- maybe it won't work
out in the end -- but nonetheless, seeing this piqued my curiosity. If
you're looking to see how this behaves in a place beyond dcache, this
might be something to play with.
Jason
next prev parent reply other threads:[~2024-02-23 13:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 20:37 [PATCH 0/1] Rosebush, a new hash table Matthew Wilcox (Oracle)
2024-02-22 20:37 ` [PATCH 1/1] rosebush: Add new data structure Matthew Wilcox (Oracle)
2024-02-25 6:38 ` Al Viro
2024-02-22 21:04 ` [lustre-devel] Fwd: [PATCH 0/1] Rosebush, a new hash table Andreas Dilger
2024-02-23 11:37 ` Peng Zhang
2024-02-23 13:55 ` Jason A. Donenfeld [this message]
2024-02-23 18:40 ` Kent Overstreet
2024-02-24 0:20 ` Herbert Xu
2024-02-24 22:10 ` David Laight
2024-02-25 0:50 ` Herbert Xu
2024-02-25 3:20 ` Kent Overstreet
2024-02-25 3:18 ` Kent Overstreet
2024-02-25 5:01 ` Matthew Wilcox
2024-02-25 5:32 ` Herbert Xu
2024-02-25 5:51 ` Kent Overstreet
2024-02-25 5:53 ` Herbert Xu
2024-02-25 6:14 ` Kent Overstreet
2024-02-25 6:17 ` Herbert Xu
2024-02-25 14:47 ` David Laight
2024-02-25 21:48 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdijtQNFuziHnqH2@zx2c4.com \
--to=jason@zx2c4.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maple-tree@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.