From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH] gpio: sim: don't fiddle with GPIOLIB private members
Date: Fri, 23 Feb 2024 16:54:54 +0200 [thread overview]
Message-ID: <ZdixvgZaW0-95zc8@smile.fi.intel.com> (raw)
In-Reply-To: <CAGETcx92GgwBpd58dLgquLFxqXiHK5QHGK3Rhkd9pC_4p7Ra6w@mail.gmail.com>
On Thu, Feb 22, 2024 at 05:01:04PM -0800, Saravana Kannan wrote:
> On Wed, Feb 21, 2024 at 4:59 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Feb 20, 2024 at 05:46:27PM -0800, Saravana Kannan wrote:
...
> > Is there any _good_ documentation for devlinks and all that fields in the
> > struct fwnode? Why should we use that without any understanding of the
> > purposes of that field. We, as device property developers, hadn't introduced
> > that field and never required it. It's an alien to device properties APIs.
>
> If I add some inline documentation for these fields, will you be more
> open to letting people use this as a way to look up devices? I'm happy
> to do that for you.
I consider documentation patches to be always welcome. But it doesn't mean
we allow to use that fields in device property APIs without a very good
justification.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-02-23 14:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 18:32 [PATCH] gpio: sim: don't fiddle with GPIOLIB private members Bartosz Golaszewski
2023-09-01 21:10 ` Andy Shevchenko
2023-09-02 14:40 ` Bartosz Golaszewski
2023-09-04 8:58 ` Andy Shevchenko
2023-09-04 9:22 ` Bartosz Golaszewski
2023-09-04 9:40 ` Andy Shevchenko
2023-09-04 9:47 ` Bartosz Golaszewski
2023-09-04 10:05 ` Andy Shevchenko
2023-09-04 10:12 ` Bartosz Golaszewski
2023-09-04 10:29 ` Andy Shevchenko
2024-02-21 1:46 ` Saravana Kannan
2024-02-21 9:34 ` Bartosz Golaszewski
2024-02-21 12:59 ` Andy Shevchenko
2024-02-23 1:01 ` Saravana Kannan
2024-02-23 14:54 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdixvgZaW0-95zc8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=kernel-team@android.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.