From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Kyle Huey <me@kylehuey.com>, Kyle Huey <khuey@kylehuey.com>,
Robert O'Callahan <robert@ocallahan.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf test: Test FASYNC with watermark wakeups.
Date: Fri, 23 Feb 2024 15:17:24 -0300 [thread overview]
Message-ID: <ZdjhNG1T6j6miiYg@x1> (raw)
In-Reply-To: <CAP-5=fXzidk9hLm5bek3q1crds4mEjdgpq=s0YCSzLCj1GtvzQ@mail.gmail.com>
On Fri, Feb 23, 2024 at 10:01:31AM -0800, Ian Rogers wrote:
> On Fri, Feb 23, 2024 at 9:35 AM Kyle Huey <me@kylehuey.com> wrote:
> > I think perhaps I'm barking up the wrong tree here. This seems like a
> > ton of work just to write a regression test. Maybe I should be doing
> > this in tools/testing/selftests instead?
> The problem is detecting support for the feature in the kernel. The
> BTF approach isn't that bad, a couple of finds, but I think in this
> case there isn't anything to be found to indicate the feature is
> present. I like the perf test as perf tests are a form of
> documentation. Perhaps just using TEST_SKIP here (rather than
> TEST_FAIL) is best and the skip_reason can be a presumed lack of
> kernel support.
But going forward the general expectation is that it should pass as
the feature _is_ present, isn't it?
- Arnaldo
prev parent reply other threads:[~2024-02-23 18:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 17:52 [PATCH 1/2] perf/ring_buffer: Trigger FASYNC signals for watermark wakeups Kyle Huey
2024-02-21 17:52 ` [PATCH 2/2] perf test: Test FASYNC with " Kyle Huey
2024-02-21 18:35 ` Ian Rogers
2024-02-22 17:55 ` Kyle Huey
2024-02-22 18:32 ` Ian Rogers
2024-02-22 18:41 ` Kyle Huey
2024-02-22 19:44 ` Ian Rogers
2024-02-22 19:54 ` Arnaldo Carvalho de Melo
2024-02-23 17:35 ` Kyle Huey
2024-02-23 17:59 ` Arnaldo Carvalho de Melo
2024-02-23 21:43 ` Robert O'Callahan
2024-02-24 2:27 ` Namhyung Kim
2024-02-24 15:58 ` Arnaldo Carvalho de Melo
2024-02-23 18:01 ` Ian Rogers
2024-02-23 18:17 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdjhNG1T6j6miiYg@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=khuey@kylehuey.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robert@ocallahan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.