From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: RFC [PATCH 2.6] I2C: w83627ehf: add fan_div no-op store method
Date: Thu, 19 May 2005 06:25:58 +0000 [thread overview]
Message-ID: <ZdowSWp7.1115978663.1398280.khali@localhost> (raw)
In-Reply-To: <bgt881pvivku9pn8t1bfki4hi8f243n72p@4ax.com>
Hi Grant,
> This small patch adds no-op fan_div store method to silence warning
> from 'sensors -s'. Compile tested.
No, sorry.
For one thing I do not want 2.6 drivers to be crippled with compatibility
tricks when we can easily move the tricks to user-space, as I explained
earlier.
For another... The w83627ehf driver does not exist before Linux 2.6. The
official version which will be included in 2.6.13 is the only one we
have to support, and it has the auto fan div functionality. So there is
absolutely no reason why a user would ever try to set the clock divider
manually. The fanN_div features are clearly tagged read-only in
libsensors, and the default configuration file doesn't attempt to set
them, so everything is consistent already. So what exactly were you
trying to fix in the first place please?
--
Jean Delvare
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:25 RFC [PATCH 2.6] I2C: w83627ehf: add fan_div no-op store method Grant Coady
2005-05-19 6:25 ` Jean Delvare [this message]
2005-05-19 6:25 ` Grant Coady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdowSWp7.1115978663.1398280.khali@localhost \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.