From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/5] xen/livepatch: fixes for the pre-apply / post-revert hooks
Date: Mon, 26 Feb 2024 09:40:17 +0100 [thread overview]
Message-ID: <ZdxOcc1O35lkTS4L@macbook> (raw)
In-Reply-To: <6143d253-1d5c-48c8-81b9-3652b21dd9c0@suse.com>
On Fri, Feb 23, 2024 at 11:48:10AM +0100, Jan Beulich wrote:
> On 30.11.2023 15:29, Roger Pau Monne wrote:
> > Hello,
> >
> > The follow series contain a misc of fixes mostly related to the usage of
> > the pre-apply / post-revert hooks. The norevert test is also fixed to
> > work as I think was expected. Finally both the no{apply,revert}
> > tests are fixed to build properly, as the files where previously
> > unhooked from the build system completely.
> >
> > I'm unsure how useful the apply and revert hooks really are, as without
> > calling the internal apply/revert functions the state of the payload
> > structure is quite likely inconsistent with the code expectations.
> >
> > Thanks, Roger.
> >
> > Roger Pau Monne (5):
> > xen/livepatch: register livepatch regions when loaded
> > xen/livepatch: search for symbols in all loaded payloads
> > xen/livepatch: fix norevert test attempt to open-code revert
> > xen/livepatch: fix norevert test hook setup typo
> > xen/livepatch: properly build the noapply and norevert tests
>
> With the R-b-s that have arrived, could you clarify in how far these
> can be committed out of order?
All can be applied out of order, except for the last one, that's
"xen/livepatch: properly build the noapply and norevert tests" as
applying that will enable the tests in osstest, and those will fail
without all the previous adjustments.
I was about to send v2 with the requested changes, but will wait for
you to commit 2/5 and 4/5.
Thanks, Roger.
next prev parent reply other threads:[~2024-02-26 8:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:29 [PATCH 0/5] xen/livepatch: fixes for the pre-apply / post-revert hooks Roger Pau Monne
2023-11-30 14:29 ` [PATCH 1/5] xen/livepatch: register livepatch regions when loaded Roger Pau Monne
2023-12-05 13:47 ` Jan Beulich
2023-12-05 15:04 ` Roger Pau Monné
2023-12-05 15:16 ` Jan Beulich
2024-02-23 9:45 ` Ross Lagerwall
2024-02-23 14:55 ` Roger Pau Monné
2023-11-30 14:29 ` [PATCH 2/5] xen/livepatch: search for symbols in all loaded payloads Roger Pau Monne
2024-02-23 10:11 ` Ross Lagerwall
2023-11-30 14:29 ` [PATCH 3/5] xen/livepatch: fix norevert test attempt to open-code revert Roger Pau Monne
2024-02-23 10:10 ` Ross Lagerwall
2024-02-26 8:16 ` Roger Pau Monné
2023-11-30 14:29 ` [PATCH 4/5] xen/livepatch: fix norevert test hook setup typo Roger Pau Monne
2024-02-23 10:13 ` Ross Lagerwall
2023-11-30 14:29 ` [PATCH 5/5] xen/livepatch: properly build the noapply and norevert tests Roger Pau Monne
2024-02-23 10:30 ` Ross Lagerwall
2024-02-23 10:48 ` [PATCH 0/5] xen/livepatch: fixes for the pre-apply / post-revert hooks Jan Beulich
2024-02-26 8:40 ` Roger Pau Monné [this message]
2024-02-26 9:26 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdxOcc1O35lkTS4L@macbook \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.