From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next] selftests: netdevsim: be less selective for FW for the devlink test
Date: Mon, 26 Feb 2024 10:24:54 +0100 [thread overview]
Message-ID: <ZdxY5vj22RSSUOXv@nanopsycho> (raw)
In-Reply-To: <20240224050658.930272-1-kuba@kernel.org>
Sat, Feb 24, 2024 at 06:06:58AM CET, kuba@kernel.org wrote:
>Commit 6151ff9c7521 ("selftests: netdevsim: use suitable existing dummy
>file for flash test") introduced a nice trick to the devlink flashing
>test. Instead of user having to create a file under /lib/firmware
>we just pick the first one that already exists.
>
>Sadly, in AWS Linux there are no files directly under /lib/firmware,
Ah :)
>only in subdirectories. Don't limit the search to -maxdepth 1.
>We can use the %P print format to get the correct path for files
>inside subdirectories:
>
>$ find /lib/firmware -type f -printf '%P\n' | head -1
>intel-ucode/06-1a-05
>
>The full path is /lib/firmware/intel-ucode/06-1a-05
>
>This works in GNU find, busybox doesn't have printf at all,
>so we're not making it worse.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2024-02-26 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 5:06 [PATCH net-next] selftests: netdevsim: be less selective for FW for the devlink test Jakub Kicinski
2024-02-26 9:24 ` Jiri Pirko [this message]
2024-02-27 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdxY5vj22RSSUOXv@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.