From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49F43C48BF6 for ; Mon, 26 Feb 2024 09:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d9rqMUzkw/gGiI04ZoK5ofnb75+8D3Wd7N+vcE7p+hw=; b=GU2xIEJeGR/Bqr xNHxW5+oYtuMwEQP024aLp2S4Bu2haoLnavWUvx8dOUqDRNQ3w66cqBmrxGzXmVDiMjMRCDxPaNLt HsAitfInJfWZXPZDaMK1d7vAsJ6dFjUon00UEyMt8c7rDGmiuh6EMmgCS5SSTKa5LufSC50+pRuUd D6RgUl+NN8TuoqsLvCFqxZnHWHAnRojzjPAe9LXGtr0kRtWvJJCcx/0WhTFlHIDTZxfZO4chh3pdy KVvkUkFrAWkazA7qQYKwNcsChwFzEc63zYHQLL8s6UI5XAS00Bdu+QIpZvGC6X20DIJ9ZVRv1TLgb y8nWB1ksDjPDJRhNgkzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reXBs-0000000HJFQ-0TQq; Mon, 26 Feb 2024 09:22:28 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reXBo-0000000HJEC-17E8 for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 09:22:26 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-33d32f74833so1603729f8f.3 for ; Mon, 26 Feb 2024 01:22:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1708939341; x=1709544141; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j8XfaiFpFxA90a4LK42YXfNdmNz9AouX/NgcsYVPG08=; b=TvNTL0/x8HyOLMGNrdKQ4Aff7TpseRRuJskZj9JTI8BE+Jma7YUQvfiMavVRY7u4tw +gvg5E0/4qYs+duuhGsW5gM7NXkkHSExqeToO/h1dhKyohBcJw4zhN8PTMrAOQwKcZzx o8OY52rYOMcHzFuvigwpdMKs+d15Qrhdls7XHkSRqFZrjDIb/yFF75GF8c/LoNaYWRqT qvDc4w2DBhpC89FezU7VoSNGqLwTpGgmSKQ+c7UAqOZv663nZqfz82U/4bMBZ7yeQpTe hTnc74VsxOGGndDWPENeh9syuxEkDGvPe5xCt3HntKSMMmmVJoInuwmjSjTbSpRcbrST 6TjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708939341; x=1709544141; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j8XfaiFpFxA90a4LK42YXfNdmNz9AouX/NgcsYVPG08=; b=i7W0f8JJD9t5ueEgFMRy6fMo/I0vLoWRw57wyVGahqELJIqOKvpfc2Q1WF+gv+yrbq 7papYVvLqRXVIBL6w5FyOGU/HzbaSBOS1Ovxlq6He5MgDLg18azdvO6iPa80uezvklHi INyRfrvI7nbyvVRaJxIVkkx7WFE/zEvYvSRDMVVk7ctf3KJ+xmtFbSSw+X/dtppYP4iV lx4CO1M5XBY+4bvmS88uZMj0AZofGlaWv1/H7myISm5I14SzL49aLD0eXoPNbd2H99Qb eaMQgAuVyOOk1zt6nroFUsDO1Aml+eQZ4vHYaDF8nc655LdgyZBPNL6oIiSwnGXcmNIG XSAA== X-Forwarded-Encrypted: i=1; AJvYcCVtdz4Bh+97zSSQo+Xx9JfYul0PPGHGQ976bZpfO2k40V5yQ7bMw4NWmQV/yTKQWiD2ZzNsZcQMWu3CgtGPhWHv6Scl+ag8qNHee9ny5AnFykneko4= X-Gm-Message-State: AOJu0YzMVHS+RRfnSZZf9qMoVuOekGF0FoKLJIzbcDZkr6GGuZmap3Dl FLkHTB4zYo8WwvR6sCsDC0PGz2H/UAwffeIZlmUysSWIJRW1uw9x5K5fcTAR44ClWZnzqRw9FYL t X-Google-Smtp-Source: AGHT+IFhByc7Z/s+hrcaeMhRiOLNXEQPUqLbBOTkrI67qidhCeOFDFWtzdBsTN1m+Ij8d6SU/mQ3XA== X-Received: by 2002:adf:e40f:0:b0:33d:a185:17ec with SMTP id g15-20020adfe40f000000b0033da18517ecmr4122739wrm.4.1708939341017; Mon, 26 Feb 2024 01:22:21 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id e11-20020adfe7cb000000b0033d071c0477sm7605769wrn.59.2024.02.26.01.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 01:22:20 -0800 (PST) Date: Mon, 26 Feb 2024 10:22:19 +0100 From: Jiri Pirko To: Jesper Nilsson Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@axis.com, Serge Semin Subject: Re: [PATCH net-next v3] net: stmmac: mmc_core: Drop interrupt registers from stats Message-ID: References: <20240223-stmmac_stats-v3-1-5d483c2a071a@axis.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240223-stmmac_stats-v3-1-5d483c2a071a@axis.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_012224_512706_53E292CF X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Feb 23, 2024 at 09:37:01PM CET, jesper.nilsson@axis.com wrote: >The MMC IPC interrupt status and interrupt mask registers are >of little use as Ethernet statistics, but incrementing counters >based on the current interrupt and interrupt mask registers >makes them actively misleading. > >For example, if the interrupt mask is set to 0x08420842, >the current code will increment by that amount each iteration, >leading to the following sequence of nonsense: > >mmc_rx_ipc_intr_mask: 969816526 >mmc_rx_ipc_intr_mask: 1108361744 > >These registers have been included in the Ethernet statistics >since the first version of MMC back in 2011 (commit 1c901a46d57). >That commit also mentions the MMC interrupts as >"something to add later (if actually useful)". > >If the registers are actually useful, they should probably >be part of the Ethernet register dump instead of statistics, >but for now, drop the counters for mmc_rx_ipc_intr and >mmc_rx_ipc_intr_mask completely. > >Reviewed-by: Serge Semin >Signed-off-by: Jesper Nilsson Reviewed-by: Jiri Pirko [...] >--- >base-commit: a08689109c5989acdc5c320de8e45324f6cfa791 >change-id: 20240216-stmmac_stats-e3561d460d0e Not sure what this is good for... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C74A81D69E for ; Mon, 26 Feb 2024 09:22:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708939344; cv=none; b=I1dp8Q6zJ0vSkgF6A+GEIUZVe4GqSFPjdvsl6B+OHIHMRw55OzgltnovGT6AFwAPU6yBG5b7HlhfHgBsPpelBWlppgOL6RMRSudohuIuE4exh86lp3J4ISX6AMGYEPd21v7hNstLijyQd/WevQeoiGc2hZ+HGigQ35kTyTUOxNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708939344; c=relaxed/simple; bh=j8XfaiFpFxA90a4LK42YXfNdmNz9AouX/NgcsYVPG08=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bDPW+qRw0M09PgduXStMd1Oq4GS5OqqzsCg+xq24vM81C7HYmhwo6ruE1jucZ1MMxmFbvViNbB+xWl1p0/kOJji/663jdEGj6uOVFC0DLzIpS2cph99D1cpqJC/gqu/uLlJGC+rDq+q/QWl3/Gj4kLBHCBrmUgXHic2JMK2Nb94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=1hX8+4ka; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="1hX8+4ka" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-33d066f8239so2083044f8f.1 for ; Mon, 26 Feb 2024 01:22:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1708939341; x=1709544141; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j8XfaiFpFxA90a4LK42YXfNdmNz9AouX/NgcsYVPG08=; b=1hX8+4ka2IXadTkHka4Jpdk+G2QU4NO3kxWy6hOWpJfarp0bgruourRNnGQ9SZ6UuM 00TY/PhF1f3X5yi5oDsC/Xk6ARAV6WKqtvTATOM89CJeZfN0DpGCNBMzHpxMBkDE/dWV UOg6zfckMBw4FoGBY2eM1B7FE3MAxBKnFICjV2aqMlzt4ZZ2QUk5JNAYgNwdB5tYBoO4 6x6yrPg3puiAo0QKR14OEEIfSAZrzhu4wt+Wc2DnmR9MCl4e213MnIG4zlzOS+S9s59y oKI0ua4TFTeRVxh7RVLTd3nmXcNPMI4dJvJp9IGVzAQFX9iwauzoII3lep/5gt9I8Mch O99g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708939341; x=1709544141; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j8XfaiFpFxA90a4LK42YXfNdmNz9AouX/NgcsYVPG08=; b=wSGpGQ73Am53QEpuGSCL+0M0tvAdgJkbqfNfdq4F6BwImLrld5lGrOakM+dMXjkbkI /CpFigedjBchlcu9644w68nmTbYGPcTrYvv/yeRDzgDLd8MYgk3AN0QjOYvRUnSET0qB tMkpCkxRR9HmU2dxsgLERe3W0cAGPUzYpW4Zpt7wNNwZ9SRH+mIhYS4wCbGyVbt8DXfX fPNTsFWArW+Jowi30JC3uZw9VevcgGEG8tYDNHJyQ0Y3yJjvvzW5J4nRXDheVuNUkx33 +OikB2gr+v4TVeLC7BD/TSxhddjjDkupAWDXmVptaELE7Sx0yVuW81AuX39LdAD3PRJC FNqg== X-Forwarded-Encrypted: i=1; AJvYcCUh/i/pyo5I6reCz6nu05AmQczwbxO9tmgcKnpo/lfW+T4R60Ml4u/yYnmr6eM9BECniaE1tZfIqsOBlD2g4u9sZvAmbT7XiIHDtKUw X-Gm-Message-State: AOJu0YzpJq5nr2X5L7rNytMXy+BWM/2JOg3yHPp2tztLnFEDovyI7pTt wX/4cR2ZeQVf3h1l0QCZnHRevHLoe+MXBfYNkEL4bh+I1KW6Q1ZqajZ1/Wdmavg= X-Google-Smtp-Source: AGHT+IFhByc7Z/s+hrcaeMhRiOLNXEQPUqLbBOTkrI67qidhCeOFDFWtzdBsTN1m+Ij8d6SU/mQ3XA== X-Received: by 2002:adf:e40f:0:b0:33d:a185:17ec with SMTP id g15-20020adfe40f000000b0033da18517ecmr4122739wrm.4.1708939341017; Mon, 26 Feb 2024 01:22:21 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id e11-20020adfe7cb000000b0033d071c0477sm7605769wrn.59.2024.02.26.01.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 01:22:20 -0800 (PST) Date: Mon, 26 Feb 2024 10:22:19 +0100 From: Jiri Pirko To: Jesper Nilsson Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@axis.com, Serge Semin Subject: Re: [PATCH net-next v3] net: stmmac: mmc_core: Drop interrupt registers from stats Message-ID: References: <20240223-stmmac_stats-v3-1-5d483c2a071a@axis.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223-stmmac_stats-v3-1-5d483c2a071a@axis.com> Fri, Feb 23, 2024 at 09:37:01PM CET, jesper.nilsson@axis.com wrote: >The MMC IPC interrupt status and interrupt mask registers are >of little use as Ethernet statistics, but incrementing counters >based on the current interrupt and interrupt mask registers >makes them actively misleading. > >For example, if the interrupt mask is set to 0x08420842, >the current code will increment by that amount each iteration, >leading to the following sequence of nonsense: > >mmc_rx_ipc_intr_mask: 969816526 >mmc_rx_ipc_intr_mask: 1108361744 > >These registers have been included in the Ethernet statistics >since the first version of MMC back in 2011 (commit 1c901a46d57). >That commit also mentions the MMC interrupts as >"something to add later (if actually useful)". > >If the registers are actually useful, they should probably >be part of the Ethernet register dump instead of statistics, >but for now, drop the counters for mmc_rx_ipc_intr and >mmc_rx_ipc_intr_mask completely. > >Reviewed-by: Serge Semin >Signed-off-by: Jesper Nilsson Reviewed-by: Jiri Pirko [...] >--- >base-commit: a08689109c5989acdc5c320de8e45324f6cfa791 >change-id: 20240216-stmmac_stats-e3561d460d0e Not sure what this is good for...