From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Steffen Bätz" <steffen@innosonix.de>
Cc: Fabio Estevam <festevam@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: mv88e6xxx: 6320/21 read cmode on serdes ports
Date: Mon, 26 Feb 2024 09:33:27 +0000 [thread overview]
Message-ID: <Zdxa5/mt84O4UMEh@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240226091325.53986-2-steffen@innosonix.de>
On Mon, Feb 26, 2024 at 10:13:24AM +0100, Steffen Bätz wrote:
> @@ -660,6 +660,16 @@ static void mv88e632x_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
>
> config->mac_capabilities = MAC_SYM_PAUSE | MAC_10 | MAC_100 |
> MAC_1000FD;
> +
> + /* Port 0/1 are serdes only ports */
> + if (port == 0 || port == 1) {
> + cmode = mv88e63xx_get_port_serdes_cmode(chip, port);
> + if (cmode < 0)
> + dev_err(chip->dev, "p%d: failed to read serdes cmode\n",
> + port);
> + else
> + mv88e6xxx_translate_cmode(cmode, supported);
> + }
Ah, ignore my comment on the other patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-02-26 9:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 9:13 [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing Steffen Bätz
2024-02-26 9:13 ` [PATCH net 2/2] net: dsa: mv88e6xxx: 6320/21 read cmode on serdes ports Steffen Bätz
2024-02-26 9:33 ` Russell King (Oracle) [this message]
2024-02-26 13:26 ` Andrew Lunn
2024-02-27 11:22 ` Fabio Estevam
2024-02-26 9:31 ` [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing Russell King (Oracle)
2024-02-26 13:23 ` Andrew Lunn
2024-02-27 11:22 ` Fabio Estevam
2024-02-28 2:21 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdxa5/mt84O4UMEh@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=steffen@innosonix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.