From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shahar Avidar <ikobh7@gmail.com>
Cc: gregkh@linuxfoundation.org, luca.ceresoli@bootlin.com,
benjamin.tissoires@redhat.com, elder@linaro.org, robh@kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: pi433: Move FIFO_THRESHOLD define to source file
Date: Mon, 26 Feb 2024 16:47:05 +0200 [thread overview]
Message-ID: <ZdykaQCdtqOrdOsC@smile.fi.intel.com> (raw)
In-Reply-To: <20240225173341.1278918-5-ikobh7@gmail.com>
On Sun, Feb 25, 2024 at 07:33:41PM +0200, Shahar Avidar wrote:
> FIFO_THRESHOLD is only being used by pi433_if.c source file
Same issue (and seems in all of your commit messages) — missing periods
at the end of the sentences. Respect English grammar, please.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-02-26 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 17:33 [PATCH 0/4] Fix defines in rf69.h Shahar Avidar
2024-02-25 17:33 ` [PATCH 1/4] staging: pi433: Remove a duplicated F_OSC define Shahar Avidar
2024-02-26 14:45 ` Andy Shevchenko
2024-02-27 22:17 ` Shahar Avidar
2024-02-25 17:33 ` [PATCH 2/4] staging: pi433: Remove the unused FREQUENCY define Shahar Avidar
2024-02-25 17:33 ` [PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define Shahar Avidar
2024-02-26 14:46 ` Andy Shevchenko
2024-02-25 17:33 ` [PATCH 4/4] staging: pi433: Move FIFO_THRESHOLD define to source file Shahar Avidar
2024-02-26 14:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdykaQCdtqOrdOsC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ikobh7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luca.ceresoli@bootlin.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.