From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 4/6] intel_device: fix warning on possible buffer overlflow on sprintf() calls
Date: Mon, 26 Feb 2024 21:35:51 +0200 [thread overview]
Message-ID: <ZdzoF1RrTGGi8703@intel.com> (raw)
In-Reply-To: <20240221185550.11943-4-info@metux.net>
On Wed, Feb 21, 2024 at 07:55:48PM +0100, Enrico Weigelt, metux IT consult wrote:
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> src/intel_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel_device.c b/src/intel_device.c
> index f28d3be1..06108ec3 100644
> --- a/src/intel_device.c
> +++ b/src/intel_device.c
> @@ -335,7 +335,7 @@ static int __intel_open_device__major_minor(int _major, int _minor)
> static int __intel_open_device__pci(const struct pci_device *pci)
> {
> struct stat st;
> - char path[256];
> + char path[PATH_MAX];
I had a slightly different take on this in
https://patchwork.freedesktop.org/series/115348/
I suppose I should actually push that stuff...
> DIR *dir;
> struct dirent *de;
> int base;
> --
> 2.39.2
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2024-02-26 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 18:55 [PATCH v2 1/6] sna: stop using obsolete type aliases Enrico Weigelt, metux IT consult
2024-02-21 18:55 ` [PATCH v2 2/6] sna: use GCPtr instead of GC * Enrico Weigelt, metux IT consult
2024-02-21 18:55 ` [PATCH v2 3/6] backlight: use system() instead of System() Enrico Weigelt, metux IT consult
2024-02-21 18:55 ` [PATCH v2 4/6] intel_device: fix warning on possible buffer overlflow on sprintf() calls Enrico Weigelt, metux IT consult
2024-02-26 18:57 ` Ville Syrjälä
2024-02-26 19:35 ` Ville Syrjälä [this message]
2024-02-21 18:55 ` [PATCH v2 5/6] stop using obsolete xf86BlockSIGIO() and xf86UnblockSIGIO() Enrico Weigelt, metux IT consult
2024-02-26 18:58 ` Ville Syrjälä
2024-02-21 18:55 ` [PATCH v2 6/6] uxa: stop calling deprecated xf86_reload_cursors() Enrico Weigelt, metux IT consult
2024-02-26 18:58 ` Ville Syrjälä
2024-02-21 22:51 ` ✗ Fi.CI.BUILD: failure for series starting with [v2,1/6] sna: stop using obsolete type aliases Patchwork
2024-02-26 18:57 ` [PATCH v2 1/6] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdzoF1RrTGGi8703@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=info@metux.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.