Re: [PATCH 4/5] drm/i915: Drop dead code for pvc

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Mar 11, 2024 at 10:35:20AM -0500, Lucas De Marchi wrote:
> On Mon, Mar 11, 2024 at 11:29:31AM -0400, Rodrigo Vivi wrote:
> > > @@ -2907,9 +2829,7 @@ engine_init_workarounds(struct intel_engine_cs *engine, struct i915_wa_list *wal
> > >  	if (engine->flags & I915_ENGINE_FIRST_RENDER_COMPUTE)
> > >  		general_render_compute_wa_init(engine, wal);
> > > 
> > > -	if (engine->class == COMPUTE_CLASS)
> > > -		ccs_engine_wa_init(engine, wal);
> > > -	else if (engine->class == RENDER_CLASS)
> > 
> > I don't believe we need to remove this chunk since we are not deleting the ccs_engine_wa_init.
> > If we want to keep that as a placeholder we should also keep the caller as well.
> 
> right... I had removed it but brought it back since I noticed the
> kernel-doc mentions and forgot to bring back the caller too. I will fix
> this in next rev.

thanks!
with that:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 
> 
> thanks
> Lucas De Marchi