From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED11FC5475B for ; Mon, 11 Mar 2024 21:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DXm+dv0F8WRcaIbQydNqY3t1UW2S3zBA7Lh4mVQHEz0=; b=xZ/o8h6aEcSK0280mUPIWjqvdW F6x20CSDZXUcdNpov58GAdtjqymjtY33bK+aLA6rGpfPrlVXQ4L1x4hjX6ZomTDjYTTGjkMJPH9ey MO2O1LQDxCo4sABLMYv33L4m2z5erIc0wzLhLOQ7czgm2c6rK45VOjpDkZtslsa5ZgR6NGl9BiNov BTzdMixla4ynWv+9x/MDRRC/LNlv4YSajS0D2BYpBFtG7X38uR83E8E+sIYMlp4Hgeut2esLpUWSh 6Gcp01a7QYBoW9px/LZTKQFI+DoB/gk2HQeCZgYfzkzM6wzyFybokn6MiaZwgHFVdFpFxSxJ8bVvd 02k3dDCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjng4-00000003KTv-1eJV; Mon, 11 Mar 2024 21:59:24 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjnfr-00000003KQo-3OBw; Mon, 11 Mar 2024 21:59:16 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rjnfa-0001zA-0X; Mon, 11 Mar 2024 21:58:54 +0000 Date: Mon, 11 Mar 2024 21:58:50 +0000 From: Daniel Golle To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: patchwork-bot+netdevbpf@kernel.org, Justin Swartz , dqfext@gmail.com, sean.wang@mediatek.com, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] net: dsa: mt7530: disable LEDs before reset Message-ID: References: <20240305043952.21590-1-justin.swartz@risingedge.co.za> <171019143163.14853.15330891015381229970.git-patchwork-notify@kernel.org> <2d206dbb-a27b-4139-a49e-331797d8ba34@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2d206dbb-a27b-4139-a49e-331797d8ba34@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240311_145911_880736_25545163 X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Mar 12, 2024 at 12:22:48AM +0300, Arınç ÜNAL wrote: > Why was this applied? I already explained it did not achieve anything. I agree that we were still debating about it, however, I do believe Justin that he truely observed this problem and the fix seemed appropriate to me. I've explained this in my previous email which you did not notice or at least haven't repied to: https://patchwork.kernel.org/project/netdevbpf/patch/20240305043952.21590-1-justin.swartz@risingedge.co.za/#25753421 In the end it probably depends on the electric capacity of the circuit connecting each LED, so it may not be reproducible on all boards and/or under all circumstances (temperature, humindity, ...). Disabling the LEDs and waiting for around 1mS before reset seems like a sensible thing to do, and I'm glad Justin took care of it. > > Arınç > > On 12.03.2024 00:10, patchwork-bot+netdevbpf@kernel.org wrote: > > Hello: > > > > This patch was applied to netdev/net-next.git (main) > > by Jakub Kicinski : > > > > On Tue, 5 Mar 2024 06:39:51 +0200 you wrote: > > > Disable LEDs just before resetting the MT7530 to avoid > > > situations where the ESW_P4_LED_0 and ESW_P3_LED_0 pin > > > states may cause an unintended external crystal frequency > > > to be selected. > > > > > > The HT_XTAL_FSEL (External Crystal Frequency Selection) > > > field of HWTRAP (the Hardware Trap register) stores a > > > 2-bit value that represents the state of the ESW_P4_LED_0 > > > and ESW_P4_LED_0 pins (seemingly) sampled just after the > > > MT7530 has been reset, as: > > > > > > [...] > > > > Here is the summary with links: > > - net: dsa: mt7530: disable LEDs before reset > > https://git.kernel.org/netdev/net-next/c/2920dd92b980 > > > > You are awesome, thank you! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFEC1C54E58 for ; Mon, 11 Mar 2024 21:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8WJ2fBpsNafIEszJ2F45LAYr4R35fXS3VQeODYMR7xM=; b=aNpa+vdTmSUnUv awuqKWg91cW2Z6zHHqYGFqBDEVHLapW5CASWMT6waIXVCVUg1UjvTKzf2ZxbDelqntwRMfUQ60Z42 2NlXVYZE51TyM289oZNHjroeWI+cywv3Nu2EmECkv+vk8DXbpkximpB9BIqKNq0ByNaL9fy/tMqyC IH52B8NSiHGgAfbADPLnA0FpMa5x/gU4IJBpzUVC0SpWgrseL44Hob461saBBkdd14wyD/qdEC7VV nslyinCvhZZmEwkZ0F2UkT6IQocqmWnZgt9KA8hpWUerB7EtTfJWsE79B8rM2Y3UUWadA2eM+xiE8 QmFyDt7Ps0Tt1MJ35S/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjng2-00000003KT1-3blo; Mon, 11 Mar 2024 21:59:22 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjnfr-00000003KQo-3OBw; Mon, 11 Mar 2024 21:59:16 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rjnfa-0001zA-0X; Mon, 11 Mar 2024 21:58:54 +0000 Date: Mon, 11 Mar 2024 21:58:50 +0000 From: Daniel Golle To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: patchwork-bot+netdevbpf@kernel.org, Justin Swartz , dqfext@gmail.com, sean.wang@mediatek.com, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] net: dsa: mt7530: disable LEDs before reset Message-ID: References: <20240305043952.21590-1-justin.swartz@risingedge.co.za> <171019143163.14853.15330891015381229970.git-patchwork-notify@kernel.org> <2d206dbb-a27b-4139-a49e-331797d8ba34@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2d206dbb-a27b-4139-a49e-331797d8ba34@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240311_145911_880736_25545163 X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXIgMTIsIDIwMjQgYXQgMTI6MjI6NDhBTSArMDMwMCwgQXLEsW7DpyDDnE5BTCB3 cm90ZToKPiBXaHkgd2FzIHRoaXMgYXBwbGllZD8gSSBhbHJlYWR5IGV4cGxhaW5lZCBpdCBkaWQg bm90IGFjaGlldmUgYW55dGhpbmcuCgpJIGFncmVlIHRoYXQgd2Ugd2VyZSBzdGlsbCBkZWJhdGlu ZyBhYm91dCBpdCwgaG93ZXZlciwgSSBkbyBiZWxpZXZlCkp1c3RpbiB0aGF0IGhlIHRydWVseSBv YnNlcnZlZCB0aGlzIHByb2JsZW0gYW5kIHRoZSBmaXggc2VlbWVkCmFwcHJvcHJpYXRlIHRvIG1l LgoKSSd2ZSBleHBsYWluZWQgdGhpcyBpbiBteSBwcmV2aW91cyBlbWFpbCB3aGljaCB5b3UgZGlk IG5vdCBub3RpY2UKb3IgYXQgbGVhc3QgaGF2ZW4ndCByZXBpZWQgdG86CgpodHRwczovL3BhdGNo d29yay5rZXJuZWwub3JnL3Byb2plY3QvbmV0ZGV2YnBmL3BhdGNoLzIwMjQwMzA1MDQzOTUyLjIx NTkwLTEtanVzdGluLnN3YXJ0ekByaXNpbmdlZGdlLmNvLnphLyMyNTc1MzQyMQoKSW4gdGhlIGVu ZCBpdCBwcm9iYWJseSBkZXBlbmRzIG9uIHRoZSBlbGVjdHJpYyBjYXBhY2l0eSBvZiB0aGUgY2ly Y3VpdApjb25uZWN0aW5nIGVhY2ggTEVELCBzbyBpdCBtYXkgbm90IGJlIHJlcHJvZHVjaWJsZSBv biBhbGwgYm9hcmRzIGFuZC9vcgp1bmRlciBhbGwgY2lyY3Vtc3RhbmNlcyAodGVtcGVyYXR1cmUs IGh1bWluZGl0eSwgLi4uKS4KCkRpc2FibGluZyB0aGUgTEVEcyBhbmQgd2FpdGluZyBmb3IgYXJv dW5kIDFtUyBiZWZvcmUgcmVzZXQgc2VlbXMgbGlrZQphIHNlbnNpYmxlIHRoaW5nIHRvIGRvLCBh bmQgSSdtIGdsYWQgSnVzdGluIHRvb2sgY2FyZSBvZiBpdC4KCgo+IAo+IEFyxLFuw6cKPiAKPiBP biAxMi4wMy4yMDI0IDAwOjEwLCBwYXRjaHdvcmstYm90K25ldGRldmJwZkBrZXJuZWwub3JnIHdy b3RlOgo+ID4gSGVsbG86Cj4gPiAKPiA+IFRoaXMgcGF0Y2ggd2FzIGFwcGxpZWQgdG8gbmV0ZGV2 L25ldC1uZXh0LmdpdCAobWFpbikKPiA+IGJ5IEpha3ViIEtpY2luc2tpIDxrdWJhQGtlcm5lbC5v cmc+Ogo+ID4gCj4gPiBPbiBUdWUsICA1IE1hciAyMDI0IDA2OjM5OjUxICswMjAwIHlvdSB3cm90 ZToKPiA+ID4gRGlzYWJsZSBMRURzIGp1c3QgYmVmb3JlIHJlc2V0dGluZyB0aGUgTVQ3NTMwIHRv IGF2b2lkCj4gPiA+IHNpdHVhdGlvbnMgd2hlcmUgdGhlIEVTV19QNF9MRURfMCBhbmQgRVNXX1Az X0xFRF8wIHBpbgo+ID4gPiBzdGF0ZXMgbWF5IGNhdXNlIGFuIHVuaW50ZW5kZWQgZXh0ZXJuYWwg Y3J5c3RhbCBmcmVxdWVuY3kKPiA+ID4gdG8gYmUgc2VsZWN0ZWQuCj4gPiA+IAo+ID4gPiBUaGUg SFRfWFRBTF9GU0VMIChFeHRlcm5hbCBDcnlzdGFsIEZyZXF1ZW5jeSBTZWxlY3Rpb24pCj4gPiA+ IGZpZWxkIG9mIEhXVFJBUCAodGhlIEhhcmR3YXJlIFRyYXAgcmVnaXN0ZXIpIHN0b3JlcyBhCj4g PiA+IDItYml0IHZhbHVlIHRoYXQgcmVwcmVzZW50cyB0aGUgc3RhdGUgb2YgdGhlIEVTV19QNF9M RURfMAo+ID4gPiBhbmQgRVNXX1A0X0xFRF8wIHBpbnMgKHNlZW1pbmdseSkgc2FtcGxlZCBqdXN0 IGFmdGVyIHRoZQo+ID4gPiBNVDc1MzAgaGFzIGJlZW4gcmVzZXQsIGFzOgo+ID4gPiAKPiA+ID4g Wy4uLl0KPiA+IAo+ID4gSGVyZSBpcyB0aGUgc3VtbWFyeSB3aXRoIGxpbmtzOgo+ID4gICAgLSBu ZXQ6IGRzYTogbXQ3NTMwOiBkaXNhYmxlIExFRHMgYmVmb3JlIHJlc2V0Cj4gPiAgICAgIGh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvbmV0ZGV2L25ldC1uZXh0L2MvMjkyMGRkOTJiOTgwCj4gPiAKPiA+ IFlvdSBhcmUgYXdlc29tZSwgdGhhbmsgeW91IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=