All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Anne Macedo <retpolanne@posteo.net>
Cc: Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf lock contention: skip traceiter functions
Date: Mon, 11 Mar 2024 16:53:03 -0300	[thread overview]
Message-ID: <Ze9hH5UzmnkFrTmB@x1> (raw)
In-Reply-To: <m24jdcbmg3.fsf@posteo.net>

On Mon, Mar 11, 2024 at 07:25:16PM +0000, Anne Macedo wrote:
> Anne Macedo <retpolanne@posteo.net> writes:
> > Namhyung Kim <namhyung@kernel.org> writes:
> >> I think it depends on the kernel version and configuration.  I remember
> >> I saw a different symbol on old kernels.  But it'd be hard to handle all
> >> the cases.  Let's have a single trace text section in the struct machine
> >> and use __traceiter_contention_begin only.  If it's not found you can
> >> fallback to trace_contention_begin.
 
> However, if we fallback to trace_contention_begin, we won't be able to
> filter out both __traceiter_contention_begin and trace_contention_begin
> at the same time.

I think for ARM we need to skip both, no? I.e. I agree with Anne.

- Arnaldo

  reply	other threads:[~2024-03-11 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-09 13:27 [PATCH v1] perf lock contention: skip traceiter functions Anne Macedo
2024-03-11 18:17 ` Namhyung Kim
2024-03-11 18:44   ` Anne Macedo
2024-03-11 19:25     ` Anne Macedo
2024-03-11 19:53       ` Arnaldo Carvalho de Melo [this message]
2024-03-11 22:29         ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ze9hH5UzmnkFrTmB@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=retpolanne@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.