From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC5C9111E; Thu, 29 Feb 2024 10:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709203476; cv=none; b=TXlHZOUSuPFayXYD4Hp4lQPLYFchcoNVIVQKrHWNe0Znrxatj9j7D3wUtN6YiK2jioULliPLXgDl7LNvobhlgARqCRcAG4frs84f9N9gOMyyypQvodA2rRLBaQERsxStiS6ghQ1AVRbFLnlO+GUu4fVvKJb+LZ49zV5A7TESINw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709203476; c=relaxed/simple; bh=jhhDWrQfbqTYlkzq71ZEnwk4+pwgB5CiiGI3IQ6of3c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e6WjkchgBAHv1Kzi5uAZz7pa+cti3sbGp8ESi4KUDFvFVIlSB+vQe0Ktnmhlm3FE1AeMnR+HUuwQOj7EL8a+XNiZlZbTCWN48qrP54Y8zWu/9GiBSWrCeDggWauBdOWbOvgD4WxpQIy4KT5y+rJOblnq7AOgep4VJPISLzhuJU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="21121343" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="21121343" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 02:44:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="913978704" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="913978704" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 02:44:29 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfdtp-00000008e0h-2kST; Thu, 29 Feb 2024 12:44:25 +0200 Date: Thu, 29 Feb 2024 12:44:25 +0200 From: "andy@kernel.org" To: Geert Uytterhoeven Cc: Chris Packham , Rob Herring , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "andrew@lunn.ch" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "ojeda@kernel.org" , "tzimmermann@suse.de" , "javierm@redhat.com" , "robin@protonic.nl" , "lee@kernel.org" , "pavel@ucw.cz" , "devicetree@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED Message-ID: References: <20240227212244.262710-1-chris.packham@alliedtelesis.co.nz> <20240227212244.262710-3-chris.packham@alliedtelesis.co.nz> <20240228140423.GA3307293-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Feb 29, 2024 at 10:24:33AM +0100, Geert Uytterhoeven wrote: > On Wed, Feb 28, 2024 at 9:02 PM Chris Packham > wrote: > > On 29/02/24 03:04, Rob Herring wrote: > > > On Wed, Feb 28, 2024 at 10:22:42AM +1300, Chris Packham wrote: ... > > > How does one know which GPIO is which segment? > > > > I've expanded the description in v3. > > > > + An array of GPIOs one per segment. The first GPIO corresponds to the A > > + segment the last GPIO corresponds to the G segment. > > > > Do you think that's sufficient or do I need to add more? In the driver > > itself I've put a little ascii art diagram of the segments. > > Given users are reading the bindings rather than the driver source, > I would move the diagram to the bindings. +1 here. We have a diagram already in UAPI headers, but that won't be (quickly) visible for the real users, duplicating in the code doesn't add any value, but adding it to DT description will be beneficial. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A922C48BF6 for ; Thu, 29 Feb 2024 10:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+U0x6hEBMp29na0fMVQp2E+HALuNmw/iH2raGDXuqD4=; b=wKWro9zfCa/RhR 0LUct4u7p0Zh0BcsPGl+eUq6glUHYYZ65ujIdiWfL+UVWAp5ja8AKxSo9uXdXV+3ccUubH2i7xpkX XzoQenDh2YeRK/4sepnDxs5jBEzAPFAVajLkvqIJiN2C4yb5GdA/3XRpSdI7W05v++vRpmXFzYMTL +ykGeZ3MZ3/5i3ZyIObKv4faIST0xoTZN+vuROrjxBtXP+ZQh0+r7F1O/ElZRzVfYiflKtCu/ayL3 6DpEJz1ThAIoCTy5DbvM/75IOgHC4ehGd5VVbX+BIf2cUhsT47amnMyCsUwlaVVTTzGkg8kS99JaE 2OLNHu4nSEeREqeewX5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfdu1-0000000DDBy-2FGr; Thu, 29 Feb 2024 10:44:37 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfdty-0000000DDBb-44RH for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 10:44:36 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="21121333" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="21121333" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 02:44:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="913978704" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="913978704" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 02:44:29 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfdtp-00000008e0h-2kST; Thu, 29 Feb 2024 12:44:25 +0200 Date: Thu, 29 Feb 2024 12:44:25 +0200 From: "andy@kernel.org" To: Geert Uytterhoeven Cc: Chris Packham , Rob Herring , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "andrew@lunn.ch" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "ojeda@kernel.org" , "tzimmermann@suse.de" , "javierm@redhat.com" , "robin@protonic.nl" , "lee@kernel.org" , "pavel@ucw.cz" , "devicetree@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED Message-ID: References: <20240227212244.262710-1-chris.packham@alliedtelesis.co.nz> <20240227212244.262710-3-chris.packham@alliedtelesis.co.nz> <20240228140423.GA3307293-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_024435_061896_8F7830B6 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMjksIDIwMjQgYXQgMTA6MjQ6MzNBTSArMDEwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IE9uIFdlZCwgRmViIDI4LCAyMDI0IGF0IDk6MDLigK9QTSBDaHJpcyBQYWNr aGFtCj4gPENocmlzLlBhY2toYW1AYWxsaWVkdGVsZXNpcy5jby5uej4gd3JvdGU6Cj4gPiBPbiAy OS8wMi8yNCAwMzowNCwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiA+IE9uIFdlZCwgRmViIDI4LCAy MDI0IGF0IDEwOjIyOjQyQU0gKzEzMDAsIENocmlzIFBhY2toYW0gd3JvdGU6CgouLi4KCj4gPiA+ IEhvdyBkb2VzIG9uZSBrbm93IHdoaWNoIEdQSU8gaXMgd2hpY2ggc2VnbWVudD8KPiA+Cj4gPiBJ J3ZlIGV4cGFuZGVkIHRoZSBkZXNjcmlwdGlvbiBpbiB2My4KPiA+Cj4gPiArIEFuIGFycmF5IG9m IEdQSU9zIG9uZSBwZXIgc2VnbWVudC4gVGhlIGZpcnN0IEdQSU8gY29ycmVzcG9uZHMgdG8gdGhl IEEKPiA+ICsgc2VnbWVudCB0aGUgbGFzdCBHUElPIGNvcnJlc3BvbmRzIHRvIHRoZSBHIHNlZ21l bnQuCj4gPgo+ID4gRG8geW91IHRoaW5rIHRoYXQncyBzdWZmaWNpZW50IG9yIGRvIEkgbmVlZCB0 byBhZGQgbW9yZT8gSW4gdGhlIGRyaXZlcgo+ID4gaXRzZWxmIEkndmUgcHV0IGEgbGl0dGxlIGFz Y2lpIGFydCBkaWFncmFtIG9mIHRoZSBzZWdtZW50cy4KPiAKPiBHaXZlbiB1c2VycyBhcmUgcmVh ZGluZyB0aGUgYmluZGluZ3MgcmF0aGVyIHRoYW4gdGhlIGRyaXZlciBzb3VyY2UsCj4gSSB3b3Vs ZCBtb3ZlIHRoZSBkaWFncmFtIHRvIHRoZSBiaW5kaW5ncy4KCisxIGhlcmUuIFdlIGhhdmUgYSBk aWFncmFtIGFscmVhZHkgaW4gVUFQSSBoZWFkZXJzLCBidXQgdGhhdCB3b24ndCBiZSAocXVpY2ts eSkKdmlzaWJsZSBmb3IgdGhlIHJlYWwgdXNlcnMsIGR1cGxpY2F0aW5nIGluIHRoZSBjb2RlIGRv ZXNuJ3QgYWRkIGFueSB2YWx1ZSwgYnV0CmFkZGluZyBpdCB0byBEVCBkZXNjcmlwdGlvbiB3aWxs IGJlIGJlbmVmaWNpYWwuCgotLSAKV2l0aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==