From: Tony Luck <tony.luck@intel.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Sohil Mehta <sohil.mehta@intel.com>,
Borislav Petkov <bp@alien8.de>,
"Naik, Avadhut" <avadnaik@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Avadhut Naik <avadhut.naik@amd.com>
Subject: Re: [PATCH] x86/mce: Dynamically size space for machine check records
Date: Thu, 29 Feb 2024 09:22:05 -0800 [thread overview]
Message-ID: <ZeC9PRltlRYBNS0I@agluck-desk3> (raw)
In-Reply-To: <b019fb64-fde5-4ade-964b-03a3a217dfd2@amd.com>
On Thu, Feb 29, 2024 at 10:49:18AM -0500, Yazen Ghannam wrote:
> On 2/28/2024 8:56 PM, Sohil Mehta wrote:
> > > + order = ilog2(sizeof(struct mce_evt_llist)) + 1;
> >
> > I didn't exactly understand why a +1 is needed here. Do you have a
> > pointer to somewhere to help understand this?
> >
> > Also, I think, a comment on top might be useful since this isn't obvious.
> >
>
> Would order_base_2() work here? It automatically rounds up to the next power.
Yes! That's exactly what is needed here. Thanks!
-Tony
next prev parent reply other threads:[~2024-02-29 17:22 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 22:56 [PATCH 0/2] Extend size of the MCE Records pool Avadhut Naik
2024-02-07 22:56 ` [PATCH 1/2] x86/MCE: " Avadhut Naik
2024-02-08 0:02 ` Luck, Tony
2024-02-08 17:41 ` Naik, Avadhut
2024-02-08 17:47 ` Naik, Avadhut
2024-02-08 18:39 ` Luck, Tony
2024-02-09 19:47 ` Naik, Avadhut
2024-02-08 21:09 ` Sohil Mehta
2024-02-09 19:52 ` Naik, Avadhut
2024-02-07 22:56 ` [PATCH 2/2] x86/MCE: Add command line option to extend " Avadhut Naik
2024-02-09 1:36 ` Sohil Mehta
2024-02-09 20:02 ` Naik, Avadhut
2024-02-09 20:09 ` Borislav Petkov
2024-02-09 20:35 ` Naik, Avadhut
2024-02-09 20:51 ` Borislav Petkov
2024-02-10 7:52 ` Borislav Petkov
2024-02-10 21:15 ` Naik, Avadhut
2024-02-11 11:14 ` Borislav Petkov
2024-02-12 2:54 ` Naik, Avadhut
2024-02-12 8:58 ` Borislav Petkov
2024-02-12 9:32 ` Borislav Petkov
2024-02-12 17:29 ` Luck, Tony
2024-02-12 17:54 ` Borislav Petkov
2024-02-12 18:45 ` Luck, Tony
2024-02-12 19:14 ` Borislav Petkov
2024-02-12 19:41 ` Luck, Tony
2024-02-12 21:37 ` Tony Luck
2024-02-12 22:08 ` Borislav Petkov
2024-02-12 22:19 ` Borislav Petkov
2024-02-12 22:42 ` Borislav Petkov
2024-02-28 23:14 ` [PATCH] x86/mce: Dynamically size space for machine check records Tony Luck
2024-02-29 0:39 ` Sohil Mehta
2024-02-29 0:44 ` Luck, Tony
2024-02-29 1:56 ` Sohil Mehta
2024-02-29 15:49 ` Yazen Ghannam
2024-02-29 17:22 ` Tony Luck [this message]
2024-02-29 17:21 ` Tony Luck
2024-02-29 23:56 ` Sohil Mehta
2024-02-29 6:42 ` Naik, Avadhut
2024-02-29 8:39 ` Borislav Petkov
2024-02-29 17:47 ` Tony Luck
2024-02-29 18:28 ` Naik, Avadhut
2024-02-29 18:38 ` Luck, Tony
2024-02-29 17:26 ` Tony Luck
2024-03-06 21:52 ` Naik, Avadhut
2024-03-06 22:07 ` Luck, Tony
2024-03-06 23:21 ` Naik, Avadhut
2024-02-15 20:18 ` [PATCH 2/2] x86/MCE: Add command line option to extend MCE Records pool Naik, Avadhut
2024-02-15 20:15 ` Naik, Avadhut
2024-02-15 20:14 ` Naik, Avadhut
2024-02-12 18:47 ` Yazen Ghannam
2024-02-12 18:58 ` Luck, Tony
2024-02-12 19:40 ` Naik, Avadhut
2024-02-12 20:18 ` Borislav Petkov
2024-02-12 20:51 ` Naik, Avadhut
2024-02-12 19:43 ` Yazen Ghannam
2024-02-12 19:49 ` Luck, Tony
2024-02-12 20:10 ` Borislav Petkov
2024-02-12 20:44 ` Paul E. McKenney
2024-02-12 21:18 ` Luck, Tony
2024-02-12 21:27 ` Borislav Petkov
2024-02-12 22:46 ` Paul E. McKenney
2024-02-12 22:53 ` Luck, Tony
2024-02-12 23:10 ` Borislav Petkov
2024-02-13 1:07 ` Paul E. McKenney
2024-02-09 20:16 ` Sohil Mehta
2024-02-09 20:28 ` Luck, Tony
2024-02-09 21:02 ` Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeC9PRltlRYBNS0I@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sohil.mehta@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.