From: Mark Rutland <mark.rutland@arm.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: catalin.marinas@arm.com, will@kernel.org, ardb@kernel.org,
broonie@kernel.org, masahiroy@kernel.org, robh@kernel.org,
scott@os.amperecomputing.com, joey.gouly@arm.com,
ndesaulniers@google.com, anshuman.khandual@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: Remove enable_daif macro
Date: Thu, 29 Feb 2024 14:30:23 +0000 [thread overview]
Message-ID: <ZeCU_-_lPblph8zC@FVFF77S0Q05N> (raw)
In-Reply-To: <20240229132802.1682026-2-ruanjinjie@huawei.com>
On Thu, Feb 29, 2024 at 09:28:01PM +0800, Jinjie Ruan wrote:
> Since commit bb8e93a287a5 ("arm64: entry: convert SError handlers to C"),
> the enable_daif assembler macro is no longer used anywhere, so remove it.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> arch/arm64/include/asm/assembler.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h
> index ce7b95cd6e79..ab8b396428da 100644
> --- a/arch/arm64/include/asm/assembler.h
> +++ b/arch/arm64/include/asm/assembler.h
> @@ -38,10 +38,6 @@
> msr daifset, #0xf
> .endm
>
> - .macro enable_daif
> - msr daifclr, #0xf
> - .endm
> -
I have no strong feelings either way on this; I had been waiting to remove this
along with disable_daif, but removing the latter requires some more substantial
work.
FWIW, for this as-is:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> /*
> * Save/restore interrupts.
> */
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-29 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 13:28 [PATCH 0/2] arm64: Remove enable_daif macro and rename disable_daif Jinjie Ruan
2024-02-29 13:28 ` [PATCH 1/2] arm64: Remove enable_daif macro Jinjie Ruan
2024-02-29 13:35 ` Mark Brown
2024-02-29 14:30 ` Mark Rutland [this message]
2024-02-29 13:28 ` [PATCH 2/2] arm64: Rename disable_daif to disable_all_int Jinjie Ruan
2024-02-29 14:24 ` Mark Rutland
2024-03-01 18:29 ` (subset) [PATCH 0/2] arm64: Remove enable_daif macro and rename disable_daif Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeCU_-_lPblph8zC@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=scott@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.