From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arturas Moskvinas <arturas.moskvinas@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
linus.walleij@linaro.org, u.kleine-koenig@pengutronix.de,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are reset
Date: Thu, 29 Feb 2024 20:25:07 +0200 [thread overview]
Message-ID: <ZeDMA373a7pieSOO@smile.fi.intel.com> (raw)
In-Reply-To: <f9e90eb2-60e5-4ae8-9f3f-92922294e981@gmail.com>
On Thu, Feb 29, 2024 at 07:24:09PM +0200, Arturas Moskvinas wrote:
> On 2/29/24 15:25, Bartosz Golaszewski wrote:
> > On Thu, Feb 29, 2024 at 1:23 PM Arturas Moskvinas
> > <arturas.moskvinas@gmail.com> wrote:
> > > Chip outputs are enabled[1] before actual reset is performed[2] which might
> > > cause pin output value to flip flop if previous pin value was set to 1
> > > in chip.
> > > Fix that behavior by making sure chip is fully reset before all outputs are
> > > enabled.
> > >
> > > Bartosz, does this look better?
> > ... if previous pin value was set to 1 period
> Andriy, Bartosz, is commit message ok?
LGTM! Please, send a v3 with it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-29 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 8:45 [PATCH v2] gpio: 74x164: Enable output pins after registers are reset Arturas Moskvinas
2024-02-29 8:54 ` Bartosz Golaszewski
2024-02-29 12:23 ` Arturas Moskvinas
2024-02-29 13:25 ` Bartosz Golaszewski
[not found] ` <f9e90eb2-60e5-4ae8-9f3f-92922294e981@gmail.com>
2024-02-29 17:39 ` Bartosz Golaszewski
2024-02-29 18:25 ` Andy Shevchenko [this message]
2024-02-29 10:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeDMA373a7pieSOO@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arturas.moskvinas@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.