From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Weilin Wang <weilin.wang@intel.com>,
Edward Baker <edward.baker@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
John Garry <john.g.garry@oracle.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Thomas Richter <tmricht@linux.ibm.com>,
James Clark <james.clark@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v1 02/20] perf jevents: Add idle metric for Intel models
Date: Fri, 1 Mar 2024 09:49:54 -0800 [thread overview]
Message-ID: <ZeIVQhfDMP7_bSJ8@tassilo> (raw)
In-Reply-To: <20240229001806.4158429-3-irogers@google.com>
> +def Idle() -> Metric:
> + cyc = Event("msr/mperf/")
> + tsc = Event("msr/tsc/")
> + low = max(tsc - cyc, 0)
> + return Metric(
> + "idle",
> + "Percentage of total wallclock cycles where CPUs are in low power state (C1 or deeper sleep state)",
> + d_ratio(low, tsc), "100%")
TBH I fail to see the advantage over the JSON. That's much more verbose
and we don't expect to have really complex metrics anyways.
And then we have a gigantic patch kit for what gain?
The motivation was the lack of comments in JSON? We could just add some
to the parser (e.g. with /* */ ). And we could allow an JSON array for the
expression to get multiple lines.
-Andi
next prev parent reply other threads:[~2024-03-01 17:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 0:17 [PATCH v1 00/20] Python generated Intel metrics Ian Rogers
2024-02-29 0:17 ` [PATCH v1 01/20] perf jevents: Add RAPL metrics for all Intel models Ian Rogers
2024-02-29 20:59 ` Liang, Kan
2024-03-01 1:02 ` Ian Rogers
2024-02-29 0:17 ` [PATCH v1 02/20] perf jevents: Add idle metric for " Ian Rogers
2024-03-01 17:49 ` Andi Kleen [this message]
2024-03-01 18:17 ` Ian Rogers
2024-03-01 21:34 ` Andi Kleen
2024-03-01 23:09 ` Ian Rogers
2024-02-29 0:17 ` [PATCH v1 03/20] perf jevents: Add smi metric group " Ian Rogers
2024-02-29 21:09 ` Liang, Kan
2024-03-01 0:54 ` Ian Rogers
2024-02-29 0:17 ` [PATCH v1 04/20] perf jevents: Add tsx " Ian Rogers
2024-02-29 21:15 ` Liang, Kan
2024-03-01 1:01 ` Ian Rogers
2024-03-01 14:52 ` Liang, Kan
2024-03-01 16:37 ` Ian Rogers
2024-03-01 17:26 ` Liang, Kan
2024-02-29 0:17 ` [PATCH v1 05/20] perf jevents: Add br metric group for branch statistics on Intel Ian Rogers
2024-02-29 21:17 ` Liang, Kan
2024-03-01 1:02 ` Ian Rogers
2024-02-29 0:17 ` [PATCH v1 06/20] perf jevents: Add software prefetch (swpf) metric group for Intel Ian Rogers
2024-02-29 0:17 ` [PATCH v1 07/20] perf jevents: Add ports metric group giving utilization on Intel Ian Rogers
2024-02-29 0:17 ` [PATCH v1 08/20] perf jevents: Add L2 metrics for Intel Ian Rogers
2024-02-29 0:17 ` [PATCH v1 09/20] perf jevents: Add load store breakdown metrics ldst " Ian Rogers
2024-02-29 0:17 ` [PATCH v1 10/20] perf jevents: Add ILP metrics " Ian Rogers
2024-02-29 0:17 ` [PATCH v1 11/20] perf jevents: Add context switch " Ian Rogers
2024-02-29 0:17 ` [PATCH v1 12/20] perf jevents: Add FPU " Ian Rogers
2024-02-29 0:17 ` [PATCH v1 13/20] perf jevents: Add cycles breakdown metric " Ian Rogers
2024-02-29 21:30 ` Liang, Kan
2024-03-01 0:48 ` Ian Rogers
2024-03-01 13:53 ` Liang, Kan
2024-02-29 0:17 ` [PATCH v1 14/20] perf jevents: Add Miss Level Parallelism (MLP) " Ian Rogers
2024-02-29 0:18 ` [PATCH v1 15/20] perf jevents: Add mem_bw " Ian Rogers
2024-02-29 0:18 ` [PATCH v1 16/20] perf jevents: Add local/remote "mem" breakdown metrics " Ian Rogers
2024-02-29 0:18 ` [PATCH v1 17/20] perf jevents: Add dir " Ian Rogers
2024-02-29 0:18 ` [PATCH v1 18/20] perf jevents: Add C-State metrics from the PCU PMU " Ian Rogers
2024-02-29 0:18 ` [PATCH v1 19/20] perf jevents: Add local/remote miss latency metrics " Ian Rogers
2024-02-29 0:18 ` [PATCH v1 20/20] perf jevents: Add upi_bw metric " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeIVQhfDMP7_bSJ8@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=edward.baker@intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=samantha.alt@intel.com \
--cc=tmricht@linux.ibm.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.