From: Jianhua Lu <lujianhua000@gmail.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: add usb pd negotiation support
Date: Sat, 2 Mar 2024 21:01:37 +0800 [thread overview]
Message-ID: <ZeMjMQtQbT7sUX6x@HP-Probook> (raw)
In-Reply-To: <2f6a5c83-69a4-480b-a235-c0d51feac31e@linaro.org>
On Sat, Mar 02, 2024 at 12:58:57AM +0100, Konrad Dybcio wrote:
> On 27.02.2024 13:45, Jianhua Lu wrote:
> > Add usb pd negotiation, but charging is controlled by pm8150b pmic,
> > so it can only charge battery with 5W,
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> > index 6f54f50a70b0..ed103b90f4e6 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> > @@ -636,7 +636,8 @@ &pm8150b_typec {
> > connector {
> > compatible = "usb-c-connector";
> >
> > - power-role = "source";
> > + op-sink-microwatt = <10000000>;
>
> Is 10W really the minimum value for this tablet to function as a sink?
>
After testing 1W, 5W and 10W, 10W is the minimum value for this device to function as a
sink.
>
prev parent reply other threads:[~2024-03-02 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 12:45 [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: add usb pd negotiation support Jianhua Lu
2024-03-01 23:58 ` Konrad Dybcio
2024-03-02 3:05 ` Jianhua Lu
2024-03-02 13:01 ` Jianhua Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeMjMQtQbT7sUX6x@HP-Probook \
--to=lujianhua000@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.