Re: [Buildroot] [PATCH 1/1] package/powertop: fix gettext build

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Steven Noonan <steven@uplinklabs.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/powertop: fix gettext build
Date: Sat, 2 Mar 2024 21:04:23 +0100	[thread overview]
Message-ID: <ZeOGR-mLVryLRXI0@landeda> (raw)
In-Reply-To: <CAPi7W83MYxj1qgLjDzNYSiN5R3ESKz7-o9-O=UrDLMP+ebTZ6A@mail.gmail.com>

Fabrice, All,

On 2024-03-02 20:12 +0100, Fabrice Fontaine spake thusly:
> Le sam. 2 mars 2024 à 19:26, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > > https://github.com/fenrus75/powertop/commit/d5c6aeb70d711722eb3f4dfa88b720c1b20eec4a
> > > The rationale was:
> > > "This patch is known to cause issues on platforms that are updated to
> > > gettext 0.20.2 or higher and wouldnt be able to move forward with
> > > building PowerTop sucessfully. Hence revert this patch."
> >
> > But that means that we will have to carr ythat patch forever, and rebase
> > it every time we update if configure.ac or po/Makefile.in.in change...
> 
> Indeed, I can open an issue to upstream but they are not very
> responsive as can be seen in the lack of progress on my PR for the
> first patch ...

[--SNIP--]
> > Did you try to set POWERTOP_AUTOPOINT = YES ?
> Yes and it doesn't work.

Weird... autopoint is there explicitly for this kind of issues (afaik).
So I tried here, and it did fix the build for the autobuilder failure
you reported, at least:

    diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
    index 0481caee07..506dba038d 100644
    --- a/package/powertop/powertop.mk
    +++ b/package/powertop/powertop.mk
    @@ -17,6 +17,7 @@ POWERTOP_DEPENDENCIES = \
     	$(if $(BR2_PACKAGE_PCIUTILS),pciutils) \
     	$(TARGET_NLS_DEPENDENCIES)

    +POWERTOP_AUTOPOINT = YES
     POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
     # 0001-add-disable-stack-protector-option.patch
     POWERTOP_AUTORECONF = YES

    $ make distclean
    $ wget -O .config 'http://autobuild.buildroot.org/results/bb80a7842d18651e5069f3a91f06a9c23218d260/defconfig'
    $ make olddefconfig
    $ make powertop-build

(I tried both with and without PPD, both succeeded with the patch
above.)

What was broken on your side?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot