From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Jeff LaBundy" <jeff@labundy.com>,
"Mattijs Korpershoek" <mkorpershoek@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"ye xingchen" <ye.xingchen@zte.com.cn>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: iqs269a - Use common error handling code in iqs269_parse_chan()
Date: Sun, 3 Mar 2024 14:31:45 -0800 [thread overview]
Message-ID: <ZeT6UUFNq1ujMW17@google.com> (raw)
In-Reply-To: <6bf9f962-cf75-459d-89f4-2546063fc154@web.de>
Hi Markus,
On Sat, Mar 02, 2024 at 09:24:53AM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 2 Mar 2024 09:15:20 +0100
>
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function implementation.
No, I do not think this is needed. However if you can introduce a fwnode
cleanup/free function (see include/linux/cleanup.h) maybe it would be
more useful and we could apply it to various drivers.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-03-03 22:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 8:24 [PATCH] Input: iqs269a - Use common error handling code in iqs269_parse_chan() Markus Elfring
2024-03-03 22:31 ` Dmitry Torokhov [this message]
2024-03-04 9:55 ` [PATCH v2] Input: iqs269a - Use scope-based resource management " Markus Elfring
2024-03-04 17:10 ` Jeff LaBundy
2024-03-04 17:13 ` Dmitry Torokhov
2024-03-04 17:48 ` [v2] " Markus Elfring
2024-03-04 18:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeT6UUFNq1ujMW17@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=jeff@labundy.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkorpershoek@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.