From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D9D72C840; Mon, 4 Mar 2024 09:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709543890; cv=none; b=skcJo4YL/R1QVzgEx+RAdYzDP0Qk4ZVUJagCGEVvCDPYDfauHLZ8mV2j5XynV9+vVPVFkr9FFKNG/yZZWtiHHiXf4dJBMS0HWhfRdds3ndtTO2FJVw5ts/6ojjOuWUDxGCpVcOriqKpr3/IbCspMi/w1BFUPuyfefFGYUKFl4X8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709543890; c=relaxed/simple; bh=2NE8g2addB4JbRzGr5d4FEp+f0iHBWz+jrXCpfZtwJQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k0FxgjCGnlFgbTG9jcAZceqfS0zVnyzXJpnD+Z2GZSrLkDtBbVId0rQohZkvEEG46JkZoCdpuehEB81/8qqyVI2ch3N/YjXK86Fot6DUEEvoQCHdN1DHq23xrLeV9vfzqk4ZvdT0kSC7IKFECeeWSSArk3D0CxeFcvQqcL+g3XQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NenlFay1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NenlFay1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C45EC433C7; Mon, 4 Mar 2024 09:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709543890; bh=2NE8g2addB4JbRzGr5d4FEp+f0iHBWz+jrXCpfZtwJQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NenlFay1MbxbJPHgLYvsg7O47VtPF6kw4AwX5TmQ7vPryNVNrM6qgfGylZQ5wUm1N p6sfyIKOmo039RTOvDQ7vXCjHVZkkNTOwRN0IVYd9X8CZVdLe6OOECVH/S8AwKn01p 1QELIvxo01dt4xoBTs2omBSR0DifRalsLaieDKNzL6PgG7oTGY6kOJp3zcnOXtztdp 3G3WLpDN6MyeWctiEL+6cKCCasoJIkcCpizPNjcn0QeqlVO3pT5wGVQkUWNGrY8ZcG d9fbzWOe/pmdiPBGVZDSHR3cyHkM+PRx1KD5IzzETy1OFnDP0pAMvQPDxZGp1YrZK8 XsizSg3llGdsw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rh4Sf-000000006L4-3Ei2; Mon, 04 Mar 2024 10:18:17 +0100 Date: Mon, 4 Mar 2024 10:18:17 +0100 From: Johan Hovold To: Anand Moon Cc: Christophe JAILLET , Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/4] usb: ehci-exynos: Use devm_clk_get_enabled() helpers Message-ID: References: <20240301193831.3346-1-linux.amoon@gmail.com> <20240301193831.3346-2-linux.amoon@gmail.com> <3d1c7682-d163-4bcf-bd41-d7db0c8f61d1@wanadoo.fr> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Mar 02, 2024 at 10:05:46PM +0530, Anand Moon wrote: > On Sat, 2 Mar 2024 at 21:19, Christophe JAILLET > wrote: > > Le 01/03/2024 à 20:38, Anand Moon a écrit : > > > The devm_clk_get_enabled() helpers: > > > - call devm_clk_get() > > > - call clk_prepare_enable() and register what is needed in order to > > > call clk_disable_unprepare() when needed, as a managed resource. > > > > > > This simplifies the code and avoids the calls to clk_disable_unprepare(). > > > > > > While at it, use dev_err_probe consistently, and use its return value > > > to return the error code. > > > @@ -260,25 +248,17 @@ static int exynos_ehci_suspend(struct device *dev) > > > > > > exynos_ehci_phy_disable(dev); > > > > > > - clk_disable_unprepare(exynos_ehci->clk); > > I don't think that removing clk_[en|dis]abble from the suspend and > > resume function is correct. > > > > The goal is to stop some hardware when the system is suspended, in order > > to save some power. > Yes correct, > > > > Why did you removed it? > devm_clk_get_enabled function register callback for clk_prepare_enable > and clk_disable_unprepare, so when the clock resource is not used it should get > disabled. > > [0] https://elixir.bootlin.com/linux/latest/source/drivers/clk/clk-devres.c#L75 > > I have also tested with rtc suspend & resume and did not find any issue. You seem to be totally confused about how devres works, and arguing back after Christophe points this out to you instead of going back and doing the homework you should have done before posting these patches is really not OK (e.g. as you're wasting other people's time). And you clearly did not test these patches enough to confirm that you didn't break the driver. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73314C54E41 for ; Mon, 4 Mar 2024 09:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C6ptI01Ry/Ox7zcwKDIApPv17htYb++4ahLm/iu36RM=; b=z/gQ1fsdjU2Jjf TsovY4I0V2tl78Bj8OAnGZztUkLdw67ygAyBkYknukwJtbahZMikbfzLL6Tei918WG3om7h1rpyKf Q6VNw0yy6ewbXETlcYx+TpMH3wN4HCCGoO+QXQc27UycIz50U3ovMxPfyYT8Wc4aUBd5VNDtYzloH hIC5QgwIhIsT4rafZyfZ6OiHIrGKAnl/p4lDDzYUqby3aDwq5kS0CgErIQyQibG53NrxmB6sgW76W 3vY2qA927aHPvpUuwSVxw6t5zn9ea3egvOjU8V8xdb6IWTLNMAbLU8a06KejLK2tmuU55f6ihrkvE tyqOsnE6e9IRtpzfud4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh4Sd-00000008K5G-0sct; Mon, 04 Mar 2024 09:18:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh4Sa-00000008K3Z-0gjv for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 09:18:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6D76660DB5; Mon, 4 Mar 2024 09:18:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C45EC433C7; Mon, 4 Mar 2024 09:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709543890; bh=2NE8g2addB4JbRzGr5d4FEp+f0iHBWz+jrXCpfZtwJQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NenlFay1MbxbJPHgLYvsg7O47VtPF6kw4AwX5TmQ7vPryNVNrM6qgfGylZQ5wUm1N p6sfyIKOmo039RTOvDQ7vXCjHVZkkNTOwRN0IVYd9X8CZVdLe6OOECVH/S8AwKn01p 1QELIvxo01dt4xoBTs2omBSR0DifRalsLaieDKNzL6PgG7oTGY6kOJp3zcnOXtztdp 3G3WLpDN6MyeWctiEL+6cKCCasoJIkcCpizPNjcn0QeqlVO3pT5wGVQkUWNGrY8ZcG d9fbzWOe/pmdiPBGVZDSHR3cyHkM+PRx1KD5IzzETy1OFnDP0pAMvQPDxZGp1YrZK8 XsizSg3llGdsw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rh4Sf-000000006L4-3Ei2; Mon, 04 Mar 2024 10:18:17 +0100 Date: Mon, 4 Mar 2024 10:18:17 +0100 From: Johan Hovold To: Anand Moon Cc: Christophe JAILLET , Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/4] usb: ehci-exynos: Use devm_clk_get_enabled() helpers Message-ID: References: <20240301193831.3346-1-linux.amoon@gmail.com> <20240301193831.3346-2-linux.amoon@gmail.com> <3d1c7682-d163-4bcf-bd41-d7db0c8f61d1@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_011812_278602_B0897F38 X-CRM114-Status: GOOD ( 23.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBNYXIgMDIsIDIwMjQgYXQgMTA6MDU6NDZQTSArMDUzMCwgQW5hbmQgTW9vbiB3cm90 ZToKPiBPbiBTYXQsIDIgTWFyIDIwMjQgYXQgMjE6MTksIENocmlzdG9waGUgSkFJTExFVAo+IDxj aHJpc3RvcGhlLmphaWxsZXRAd2FuYWRvby5mcj4gd3JvdGU6Cj4gPiBMZSAwMS8wMy8yMDI0IMOg IDIwOjM4LCBBbmFuZCBNb29uIGEgw6ljcml0IDoKCj4gPiA+IFRoZSBkZXZtX2Nsa19nZXRfZW5h YmxlZCgpIGhlbHBlcnM6Cj4gPiA+ICAgICAgLSBjYWxsIGRldm1fY2xrX2dldCgpCj4gPiA+ICAg ICAgLSBjYWxsIGNsa19wcmVwYXJlX2VuYWJsZSgpIGFuZCByZWdpc3RlciB3aGF0IGlzIG5lZWRl ZCBpbiBvcmRlciB0bwo+ID4gPiAgICAgICBjYWxsIGNsa19kaXNhYmxlX3VucHJlcGFyZSgpIHdo ZW4gbmVlZGVkLCBhcyBhIG1hbmFnZWQgcmVzb3VyY2UuCj4gPiA+Cj4gPiA+IFRoaXMgc2ltcGxp ZmllcyB0aGUgY29kZSBhbmQgYXZvaWRzIHRoZSBjYWxscyB0byBjbGtfZGlzYWJsZV91bnByZXBh cmUoKS4KPiA+ID4KPiA+ID4gV2hpbGUgYXQgaXQsIHVzZSBkZXZfZXJyX3Byb2JlIGNvbnNpc3Rl bnRseSwgYW5kIHVzZSBpdHMgcmV0dXJuIHZhbHVlCj4gPiA+IHRvIHJldHVybiB0aGUgZXJyb3Ig Y29kZS4KCj4gPiA+IEBAIC0yNjAsMjUgKzI0OCwxNyBAQCBzdGF0aWMgaW50IGV4eW5vc19laGNp X3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ID4gPgo+ID4gPiAgICAgICBleHlub3NfZWhj aV9waHlfZGlzYWJsZShkZXYpOwo+ID4gPgo+ID4gPiAtICAgICBjbGtfZGlzYWJsZV91bnByZXBh cmUoZXh5bm9zX2VoY2ktPmNsayk7Cgo+ID4gSSBkb24ndCB0aGluayB0aGF0IHJlbW92aW5nIGNs a19bZW58ZGlzXWFiYmxlIGZyb20gdGhlIHN1c3BlbmQgYW5kCj4gPiByZXN1bWUgZnVuY3Rpb24g aXMgY29ycmVjdC4KPiA+Cj4gPiBUaGUgZ29hbCBpcyB0byBzdG9wIHNvbWUgaGFyZHdhcmUgd2hl biB0aGUgc3lzdGVtIGlzIHN1c3BlbmRlZCwgaW4gb3JkZXIKPiA+IHRvIHNhdmUgc29tZSBwb3dl ci4KPiBZZXMgY29ycmVjdCwKPiA+Cj4gPiBXaHkgZGlkIHlvdSByZW1vdmVkIGl0PwoKPiBkZXZt X2Nsa19nZXRfZW5hYmxlZCAgZnVuY3Rpb24gcmVnaXN0ZXIgY2FsbGJhY2sgZm9yIGNsa19wcmVw YXJlX2VuYWJsZQo+IGFuZCBjbGtfZGlzYWJsZV91bnByZXBhcmUsIHNvIHdoZW4gdGhlIGNsb2Nr IHJlc291cmNlIGlzIG5vdCB1c2VkIGl0IHNob3VsZCBnZXQKPiBkaXNhYmxlZC4KPiAKPiBbMF0g aHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0ZXN0L3NvdXJjZS9kcml2ZXJzL2Ns ay9jbGstZGV2cmVzLmMjTDc1Cj4gCj4gSSBoYXZlIGFsc28gdGVzdGVkIHdpdGggcnRjIHN1c3Bl bmQgJiByZXN1bWUgYW5kIGRpZCBub3QgZmluZCBhbnkgaXNzdWUuCgpZb3Ugc2VlbSB0byBiZSB0 b3RhbGx5IGNvbmZ1c2VkIGFib3V0IGhvdyBkZXZyZXMgd29ya3MsIGFuZCBhcmd1aW5nIGJhY2sK YWZ0ZXIgQ2hyaXN0b3BoZSBwb2ludHMgdGhpcyBvdXQgdG8geW91IGluc3RlYWQgb2YgZ29pbmcg YmFjayBhbmQgZG9pbmcKdGhlIGhvbWV3b3JrIHlvdSBzaG91bGQgaGF2ZSBkb25lIGJlZm9yZSBw b3N0aW5nIHRoZXNlIHBhdGNoZXMgaXMgcmVhbGx5Cm5vdCBPSyAoZS5nLiBhcyB5b3UncmUgd2Fz dGluZyBvdGhlciBwZW9wbGUncyB0aW1lKS4KCkFuZCB5b3UgY2xlYXJseSBkaWQgbm90IHRlc3Qg dGhlc2UgcGF0Y2hlcyBlbm91Z2ggdG8gY29uZmlybSB0aGF0IHlvdQpkaWRuJ3QgYnJlYWsgdGhl IGRyaXZlci4KCkpvaGFuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==