From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C818648CC7; Mon, 4 Mar 2024 19:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709579810; cv=none; b=YWqHGL+GjTzIoZBOTHiqCMirKs9jlUeg63YpyYRK03jsyc52RCgLG/BTZz12WGrTCpLC2+VCbQ+Tw/7BzrEAUX2VJVQmbGuLvFVVMJy88avBoyfIpm5bXTedzj0Gsyb1wP9jahN11JBRANHQFXd7YlnHIc9W+4CvrSGGI2WYw4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709579810; c=relaxed/simple; bh=+BMvzZC/p8UJlJ/Yb/cPBGKXL8LNozl5FUzNxsYDVPA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uy0zOQPtMiOcVYt2DuxBRvsGERnKLZ34wXogTDg2A+NvFYJ+a6C6vV3bNR81f1yX5m6a3HiRZRqCQHzJJk7LWkjA4gei2FYmQ9/+kMb+lOOCI/t6u7GCN4PC6WJj1PlUhZb3pkhnRI5UgME9Wp2pDLAlVceOxtpB9UzNUAXDQng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="15498917" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="15498917" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 11:16:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="914113434" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="914113434" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 11:16:44 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rhDnl-00000009nWC-38oj; Mon, 04 Mar 2024 21:16:41 +0200 Date: Mon, 4 Mar 2024 21:16:41 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Chris Packham , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 4/4] ARM: dts: marvell: Indicate USB activity on x530 Message-ID: References: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> <20240301014203.2033844-5-chris.packham@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Mar 04, 2024 at 08:01:58PM +0100, Geert Uytterhoeven wrote: > On Mon, Mar 4, 2024 at 7:17 PM Andy Shevchenko > wrote: > > On Mon, Mar 4, 2024 at 11:57 AM Geert Uytterhoeven wrote: > > > On Sun, Mar 3, 2024 at 9:43 PM Andy Shevchenko > > > wrote: ... > > > So IMHO it would be a bad idea to make the DP mandatory. > > > > But I'm not talking about making it mandatory, I'm talking about the > > OK. > > > DP to be used as DP when it _is_ present and wired. If current > > platform wants to use DP for something else, I'm pretty much worried > > that this is the right thing to do. > > There is not much we can do about that. People can already model > such displays as individual LEDs, too. > And in some sense, the auxdisplay/linedisp driver for > "generic-gpio-7seg" imposes a policy, too. Does it? It's exactly targeting very specific HW configuration. The only question here is DP. > What if people want to e.g. use 4 7-seg displays to show a continuously > running snake? We have an ABI to update a "character" mapping, so it's possible to do, but it is not a main purpose of line display library. Free running 7-segment display does probably belong to LED framework in that sense (as just represents a 7 LEDs that user configured in a specific way in the physical world). In such case it's just the 7 LEDs on a single PCB. If you consider these limits as "policy", okay, but it's _hardware driven_ one, and not software. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2B22C54E49 for ; Mon, 4 Mar 2024 19:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ix4y/2gigIMnuxT9TeVQ5unZbQxprcPFA8GKSPhitZA=; b=vS9Rm8rvbS0cGG rq29ezKqL4Z300rnZnFX8i9au/M4759ofdmeIo8GPxPZIbDqByCT6FyVhbMI5TrM4j72eqSvn+KKn jLak7kkOvTD/pjtlWjtKuFufi4LRfABL7IIQu1SA2iCiaWu81UKYgG3aQqL4HRR7BcOIJGK1Esa39 0ohJ376vDvqdbuIyX3yhSbFU3ZO5QpDnlP68fCQh2iwjOawLq+GjSl25X+CIZYdI1+aFJNq4l0wCr fwu7Nzyj/dF86rqH0Qp5o1OdjEvSLpaV/ayqP1GYqQWkt53ScuqclXfLbSZj3QI4zB3VtBolMetyK yo7Hw1VFedBNQICKeeig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhDo8-0000000APx3-3GIh; Mon, 04 Mar 2024 19:17:04 +0000 Received: from mgamail.intel.com ([192.198.163.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhDnt-0000000APtZ-21wD for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 19:17:02 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="15498921" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="15498921" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 11:16:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="914113434" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="914113434" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 11:16:44 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rhDnl-00000009nWC-38oj; Mon, 04 Mar 2024 21:16:41 +0200 Date: Mon, 4 Mar 2024 21:16:41 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Chris Packham , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pavel@ucw.cz, lee@kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 4/4] ARM: dts: marvell: Indicate USB activity on x530 Message-ID: References: <20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz> <20240301014203.2033844-5-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_111701_110197_6BD5907B X-CRM114-Status: GOOD ( 24.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMDQsIDIwMjQgYXQgMDg6MDE6NThQTSArMDEwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IE9uIE1vbiwgTWFyIDQsIDIwMjQgYXQgNzoxN+KAr1BNIEFuZHkgU2hldmNo ZW5rbwo+IDxhbmR5LnNoZXZjaGVua29AZ21haWwuY29tPiB3cm90ZToKPiA+IE9uIE1vbiwgTWFy IDQsIDIwMjQgYXQgMTE6NTfigK9BTSBHZWVydCBVeXR0ZXJob2V2ZW4gPGdlZXJ0QGxpbnV4LW02 OGsub3JnPiB3cm90ZToKPiA+ID4gT24gU3VuLCBNYXIgMywgMjAyNCBhdCA5OjQz4oCvUE0gQW5k eSBTaGV2Y2hlbmtvCj4gPiA+IDxhbmR5LnNoZXZjaGVua29AZ21haWwuY29tPiB3cm90ZToKCi4u LgoKPiA+ID4gU28gSU1ITyBpdCB3b3VsZCBiZSBhIGJhZCBpZGVhIHRvIG1ha2UgdGhlIERQIG1h bmRhdG9yeS4KPiA+Cj4gPiBCdXQgSSdtIG5vdCB0YWxraW5nIGFib3V0IG1ha2luZyBpdCBtYW5k YXRvcnksIEknbSB0YWxraW5nIGFib3V0IHRoZQo+IAo+IE9LLgo+IAo+ID4gRFAgdG8gYmUgdXNl ZCBhcyBEUCB3aGVuIGl0IF9pc18gcHJlc2VudCBhbmQgd2lyZWQuIElmIGN1cnJlbnQKPiA+IHBs YXRmb3JtIHdhbnRzIHRvIHVzZSBEUCBmb3Igc29tZXRoaW5nIGVsc2UsIEknbSBwcmV0dHkgbXVj aCB3b3JyaWVkCj4gPiB0aGF0IHRoaXMgaXMgdGhlIHJpZ2h0IHRoaW5nIHRvIGRvLgo+IAo+IFRo ZXJlIGlzIG5vdCBtdWNoIHdlIGNhbiBkbyBhYm91dCB0aGF0LiBQZW9wbGUgY2FuIGFscmVhZHkg bW9kZWwKPiBzdWNoIGRpc3BsYXlzIGFzIGluZGl2aWR1YWwgTEVEcywgdG9vLgo+IEFuZCBpbiBz b21lIHNlbnNlLCB0aGUgYXV4ZGlzcGxheS9saW5lZGlzcCBkcml2ZXIgZm9yCj4gImdlbmVyaWMt Z3Bpby03c2VnIiBpbXBvc2VzIGEgcG9saWN5LCB0b28uCgpEb2VzIGl0PyBJdCdzIGV4YWN0bHkg dGFyZ2V0aW5nIHZlcnkgc3BlY2lmaWMgSFcgY29uZmlndXJhdGlvbi4gVGhlIG9ubHkKcXVlc3Rp b24gaGVyZSBpcyBEUC4KCj4gV2hhdCBpZiBwZW9wbGUgd2FudCB0byBlLmcuIHVzZSA0IDctc2Vn IGRpc3BsYXlzIHRvIHNob3cgYSBjb250aW51b3VzbHkKPiBydW5uaW5nIHNuYWtlPwoKV2UgaGF2 ZSBhbiBBQkkgdG8gdXBkYXRlIGEgImNoYXJhY3RlciIgbWFwcGluZywgc28gaXQncyBwb3NzaWJs ZSB0byBkbywgYnV0Cml0IGlzIG5vdCBhIG1haW4gcHVycG9zZSBvZiBsaW5lIGRpc3BsYXkgbGli cmFyeS4KCkZyZWUgcnVubmluZyA3LXNlZ21lbnQgZGlzcGxheSBkb2VzIHByb2JhYmx5IGJlbG9u ZyB0byBMRUQgZnJhbWV3b3JrIGluIHRoYXQKc2Vuc2UgKGFzIGp1c3QgcmVwcmVzZW50cyBhIDcg TEVEcyB0aGF0IHVzZXIgY29uZmlndXJlZCBpbiBhIHNwZWNpZmljIHdheSBpbgp0aGUgcGh5c2lj YWwgd29ybGQpLiBJbiBzdWNoIGNhc2UgaXQncyBqdXN0IHRoZSA3IExFRHMgb24gYSBzaW5nbGUg UENCLgoKSWYgeW91IGNvbnNpZGVyIHRoZXNlIGxpbWl0cyBhcyAicG9saWN5Iiwgb2theSwgYnV0 IGl0J3MgX2hhcmR3YXJlIGRyaXZlbl8Kb25lLCBhbmQgbm90IHNvZnR3YXJlLgoKLS0gCldpdGgg QmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28KCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=